Re: [DISCUSS] KIP-35 - Retrieve protocol version

Nice write-up. Just had a question, instead of returning an empty response back to the client, would it be better for the broker to return a response that gives some more info to the client regarding the min version they need to upgrade to in order to communicate with the broker. Thanks,

[jira] [Assigned] (KAFKA-2479) Add CopycatExceptions to indicate transient and permanent errors in a connector/task

[ https://issues.apache.org/jira/browse/KAFKA-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liquan Pei reassigned KAFKA-2479: - Assignee: Liquan Pei (was: Ewen Cheslack-Postava) > Add CopycatExceptions to indicate transient

[jira] [Commented] (KAFKA-2594) Add a key-value store that is a fixed-capacity in-memory LRU cache

[ https://issues.apache.org/jira/browse/KAFKA-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933849#comment-14933849 ] ASF GitHub Bot commented on KAFKA-2594: --- GitHub user rhauch opened a pull request:

[jira] [Created] (KAFKA-2591) Remove Persistent Data before Restoringafter a Fault

Guozhang Wang created KAFKA-2591: Summary: Remove Persistent Data before Restoringafter a Fault Key: KAFKA-2591 URL: https://issues.apache.org/jira/browse/KAFKA-2591 Project: Kafka Issue

[jira] [Commented] (KAFKA-2480) Handle non-CopycatExceptions from SinkTasks

[ https://issues.apache.org/jira/browse/KAFKA-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933632#comment-14933632 ] Guozhang Wang commented on KAFKA-2480: -- [~liquanpei] I saw you are already in the contributor list,

[jira] [Commented] (KAFKA-2573) Mirror maker system test hangs and eventually fails

[ https://issues.apache.org/jira/browse/KAFKA-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933633#comment-14933633 ] Dong Lin commented on KAFKA-2573: - [~ijuma] Thanks for referring me to this ticket. Yes, I think this is

[jira] [Commented] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

[ https://issues.apache.org/jira/browse/KAFKA-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933650#comment-14933650 ] Guozhang Wang commented on KAFKA-2592: -- The problem is that when we flush the rocksDB / change-log,

[jira] [Assigned] (KAFKA-2484) Add schema projection utilities

[ https://issues.apache.org/jira/browse/KAFKA-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liquan Pei reassigned KAFKA-2484: - Assignee: Liquan Pei (was: Ewen Cheslack-Postava) > Add schema projection utilities >

[jira] [Created] (KAFKA-2595) Processor thread dies due to an uncaught NoSuchElementException

Shaun Senecal created KAFKA-2595: Summary: Processor thread dies due to an uncaught NoSuchElementException Key: KAFKA-2595 URL: https://issues.apache.org/jira/browse/KAFKA-2595 Project: Kafka

[GitHub] kafka pull request: KAFKA-2594 Added InMemoryLRUCacheStore

GitHub user rhauch opened a pull request: https://github.com/apache/kafka/pull/256 KAFKA-2594 Added InMemoryLRUCacheStore Added a new `KeyValueStore` implementation called `InMemoryLRUCacheStore` that keeps a maximum number of entries in-memory, and as the size exceeds the

[jira] [Updated] (KAFKA-2595) Processor thread dies due to an uncaught NoSuchElementException

[ https://issues.apache.org/jira/browse/KAFKA-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaun Senecal updated KAFKA-2595: - Attachment: server.log.2015-09-23-09.gz Server logs for the day which appears to have caused the

[jira] [Comment Edited] (KAFKA-2222) Write "Input/output error" did not result in broker shutdown

[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933721#comment-14933721 ] Jason Rosenberg edited comment on KAFKA- at 9/28/15 6:25 PM: - Ok, so

[jira] [Commented] (KAFKA-2222) Write "Input/output error" did not result in broker shutdown

[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933721#comment-14933721 ] Jason Rosenberg commented on KAFKA-: Ok, so was this a read or a write, looking at the stack

[jira] [Commented] (KAFKA-2125) Infinite loop after controlled shutdown succeeds

[ https://issues.apache.org/jira/browse/KAFKA-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933724#comment-14933724 ] Jason Rosenberg commented on KAFKA-2125: Unfortunately, I've only seen this occur one time, so I

[jira] [Commented] (KAFKA-2580) Kafka Broker keeps file handles open for all log files (even if its not written to/read from)

[ https://issues.apache.org/jira/browse/KAFKA-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933781#comment-14933781 ] Joel Koshy commented on KAFKA-2580: --- [~guozhang] actually it is now at 400k. [~vinothchandar] yes that

[jira] [Commented] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

[ https://issues.apache.org/jira/browse/KAFKA-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933603#comment-14933603 ] Jay Kreps commented on KAFKA-2592: -- I think the impl strategy that Samza has is pretty good, it keeps an

[jira] [Created] (KAFKA-2593) KeyValueStores should not require use of the context's default serializers and deserializers

Randall Hauch created KAFKA-2593: Summary: KeyValueStores should not require use of the context's default serializers and deserializers Key: KAFKA-2593 URL: https://issues.apache.org/jira/browse/KAFKA-2593

[jira] [Commented] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

[ https://issues.apache.org/jira/browse/KAFKA-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933694#comment-14933694 ] Guozhang Wang commented on KAFKA-2592: -- Yes, this is not a correctness issue since we do not have

[jira] [Assigned] (KAFKA-2481) Allow copycat sinks to request periodic invocation of put even if no new data is available

[ https://issues.apache.org/jira/browse/KAFKA-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liquan Pei reassigned KAFKA-2481: - Assignee: Liquan Pei (was: Ewen Cheslack-Postava) > Allow copycat sinks to request periodic

Re: [DISCUSS] KIP-35 - Retrieve protocol version

I agree with Ewen that having the keys explicitly specified in the response is better. In addition to the supported protocol version, there are other interesting metadata at the broker level that could be of interest to things like admin tools (e.g., used disk space, remaining disk space, etc). I

[jira] [Commented] (KAFKA-2125) Infinite loop after controlled shutdown succeeds

[ https://issues.apache.org/jira/browse/KAFKA-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933562#comment-14933562 ] Jun Rao commented on KAFKA-2125: [~jbrosenb...@gmail.com], the logic for connection quotas gets moved to

[jira] [Commented] (KAFKA-2222) Write "Input/output error" did not result in broker shutdown

[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933589#comment-14933589 ] Jun Rao commented on KAFKA-: Currently, we only shut down the broker if it gets any IOException during

Re: 0.9.0.0 remaining jiras

I made a pass of those. KAFKA-2106 and KAFKA-1792 are related to improving the replica assignment. Since they likely involve a KIP discussion, it's probably too late to include them in 0.9.0.0. KAFKA-2434: This is on the old consumer. Any improvement that we do should probably be on the new

[jira] [Commented] (KAFKA-2593) KeyValueStores should not require use of the context's default serializers and deserializers

[ https://issues.apache.org/jira/browse/KAFKA-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933760#comment-14933760 ] ASF GitHub Bot commented on KAFKA-2593: --- GitHub user rhauch opened a pull request:

[jira] [Updated] (KAFKA-1991) Clean ControllerStats initialization

[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1991: --- Resolution: Not A Problem Status: Resolved (was: Patch Available) > Clean ControllerStats

[jira] [Commented] (KAFKA-2581) Run all existing ducktape tests with SSL-enabled clients and brokers

[ https://issues.apache.org/jira/browse/KAFKA-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933532#comment-14933532 ] Ismael Juma commented on KAFKA-2581: I'm not too familiar with ducktape (yet), so I'll leave it to

[jira] [Created] (KAFKA-2590) Kafka Streams Checklist

Guozhang Wang created KAFKA-2590: Summary: Kafka Streams Checklist Key: KAFKA-2590 URL: https://issues.apache.org/jira/browse/KAFKA-2590 Project: Kafka Issue Type: Task Reporter:

Re: [DISCUSS] KIP-35 - Retrieve protocol version

Having the version API can make clients more robust, so I'm in favor. One note on the addition of the "rack" field. Since this is a broker-specific setting, the client would have to query BrokerMetadata for every new broker it connects to (unless we also expose rack in TopicMetadata). This is also

[jira] [Commented] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

[ https://issues.apache.org/jira/browse/KAFKA-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933673#comment-14933673 ] Jay Kreps commented on KAFKA-2592: -- That is generally true for all output, though, right? Not more true

[jira] [Created] (KAFKA-2594) Add a key-value store that is a fixed-capacity in-memory LRU cache

Randall Hauch created KAFKA-2594: Summary: Add a key-value store that is a fixed-capacity in-memory LRU cache Key: KAFKA-2594 URL: https://issues.apache.org/jira/browse/KAFKA-2594 Project: Kafka

[jira] [Created] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

Guozhang Wang created KAFKA-2592: Summary: Stop Writing the Change-log in store.put() / delete() for Non-transactional Store Key: KAFKA-2592 URL: https://issues.apache.org/jira/browse/KAFKA-2592

[jira] [Commented] (KAFKA-2222) Write "Input/output error" did not result in broker shutdown

[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933736#comment-14933736 ] Jun Rao commented on KAFKA-: It's doing a write to the remote socket, but it's handling a read

[GitHub] kafka pull request: KAFKA-2593 Key value stores can use specified ...

GitHub user rhauch opened a pull request: https://github.com/apache/kafka/pull/255 KAFKA-2593 Key value stores can use specified serializers and deserializers Add support for the key value stores to use specified serializers and deserializers (aka, "serdes"). Prior to this change,

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

Hi, First, thanks for putting out a KIP for this. This is super important for production deployments of Kafka. Few questions: 1) Are we sure we want "as many racks as possible"? I'd want to balance between safety (more racks) and network utilization (traffic within a rack uses the

[GitHub] kafka pull request: KAFKA-2570: commit offsets on rebalance/close ...

GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/257 KAFKA-2570: commit offsets on rebalance/close when auto-commit is enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka

[jira] [Commented] (KAFKA-2570) New consumer should commit before every rebalance when auto-commit is enabled

[ https://issues.apache.org/jira/browse/KAFKA-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933950#comment-14933950 ] ASF GitHub Bot commented on KAFKA-2570: --- GitHub user hachikuji opened a pull request:

[jira] [Resolved] (KAFKA-2585) ConsoleConsumer should not hang infinitely upon exception

[ https://issues.apache.org/jira/browse/KAFKA-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2585. - Resolution: Fixed Fix Version/s: 0.9.0.0 Issue resolved by pull request 247

[jira] [Commented] (KAFKA-2585) ConsoleConsumer should not hang infinitely upon exception

[ https://issues.apache.org/jira/browse/KAFKA-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934105#comment-14934105 ] ASF GitHub Bot commented on KAFKA-2585: --- Github user asfgit closed the pull request at:

[GitHub] kafka pull request: KAFKA-2585; ConsoleConsumer should not hang in...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (KAFKA-2586) Enable SSL for inter-broker communication in SSL tests

[ https://issues.apache.org/jira/browse/KAFKA-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933392#comment-14933392 ] ASF GitHub Bot commented on KAFKA-2586: --- Github user asfgit closed the pull request at:

[jira] [Updated] (KAFKA-2586) Enable SSL for inter-broker communication in SSL tests

[ https://issues.apache.org/jira/browse/KAFKA-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2586: --- Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 252

[jira] [Created] (KAFKA-2588) ReplicaManager partitionCount metric should actually be replicaCount

Grant Henke created KAFKA-2588: -- Summary: ReplicaManager partitionCount metric should actually be replicaCount Key: KAFKA-2588 URL: https://issues.apache.org/jira/browse/KAFKA-2588 Project: Kafka

Build failed in Jenkins: Kafka-trunk #645

See Changes: [junrao] KAFKA-2586; Enable SSL for inter-broker communication when SSL is enabled in tests -- [...truncated 825 lines...] kafka.common.ConfigTest > testInvalidGroupIds PASSED

[jira] [Work started] (KAFKA-2588) ReplicaManager partitionCount metric should actually be replicaCount

[ https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2588 started by Grant Henke. -- > ReplicaManager partitionCount metric should actually be replicaCount >

[jira] [Commented] (KAFKA-2588) ReplicaManager partitionCount metric should actually be replicaCount

[ https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933448#comment-14933448 ] ASF GitHub Bot commented on KAFKA-2588: --- GitHub user granthenke opened a pull request:

[GitHub] kafka pull request: KAFKA-2588 ReplicaManager partitionCount metri...

GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/254 KAFKA-2588 ReplicaManager partitionCount metric should actually be re… …plicaCount You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (KAFKA-2588) ReplicaManager partitionCount metric should actually be replicaCount

[ https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2588: --- Status: Patch Available (was: In Progress) > ReplicaManager partitionCount metric should actually be

[jira] [Commented] (KAFKA-2448) BrokerChangeListener missed broker id path ephemeral node deletion event.

[ https://issues.apache.org/jira/browse/KAFKA-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933489#comment-14933489 ] Jun Rao commented on KAFKA-2448: [~becket_qin], normally, the firing of the watcher won't be delayed by

[jira] [Updated] (KAFKA-2589) Documentation bug: the default value for the "rebalance.backoff.ms" property is not specified correctly

[ https://issues.apache.org/jira/browse/KAFKA-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bogdan Dimitriu updated KAFKA-2589: --- Description: The documentation for 0.8.2.1 consumer properties specifies: |

[jira] [Created] (KAFKA-2589) Documentation bug: the default value for the "rebalance.backoff.ms" property is not specified correctly

Bogdan Dimitriu created KAFKA-2589: -- Summary: Documentation bug: the default value for the "rebalance.backoff.ms" property is not specified correctly Key: KAFKA-2589 URL:

[jira] [Commented] (KAFKA-2514) change default JVM options in kafka-run-class.sh

[ https://issues.apache.org/jira/browse/KAFKA-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933462#comment-14933462 ] ASF GitHub Bot commented on KAFKA-2514: --- Github user asfgit closed the pull request at:

[GitHub] kafka pull request: KAFKA-2514: change default JVM options in kafk...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (KAFKA-2514) change default JVM options in kafka-run-class.sh

[ https://issues.apache.org/jira/browse/KAFKA-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2514: --- Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 218

Build failed in Jenkins: Kafka-trunk #646

See Changes: [junrao] KAFKA-2514: change default JVM options in kafka-run-class.sh. -- [...truncated 2508 lines...] kafka.coordinator.ConsumerCoordinatorResponseTest >

[GitHub] kafka pull request: KAFKA-2586; Enable SSL for inter-broker commun...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: KAFKA-2482: Allow sink tasks to get their curr...

GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/249 KAFKA-2482: Allow sink tasks to get their current assignment, as well as pause and resume topic partitions. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (KAFKA-2482) Allow copycat sink tasks to pause/resume consumption of specific topic partitions

[ https://issues.apache.org/jira/browse/KAFKA-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2482: - Reviewer: Gwen Shapira Status: Patch Available (was: Open) > Allow copycat

[jira] [Comment Edited] (KAFKA-1804) Kafka network thread lacks top exception handler

[ https://issues.apache.org/jira/browse/KAFKA-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909940#comment-14909940 ] Patrick J. McNerthney edited comment on KAFKA-1804 at 9/28/15 6:33 AM:

[GitHub] kafka pull request: MINOR: Fix FileStreamSourceTask to create the ...

GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/251 MINOR: Fix FileStreamSourceTask to create the reader around System.in when using stdin as the input source. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request: HOTFIX: Checkstye fixes follow up for KAKFA-25...

GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/248 HOTFIX: Checkstye fixes follow up for KAKFA-2531. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ewencp/kafka hotfix-kafka-2531-checkstyle

[jira] [Updated] (KAFKA-2474) Add caching for converted Copycat schemas in JSONConverter

[ https://issues.apache.org/jira/browse/KAFKA-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2474: - Reviewer: Gwen Shapira Status: Patch Available (was: Open) > Add caching

[GitHub] kafka pull request: KAFKA-2474: Add caching of JSON schema convers...

GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/250 KAFKA-2474: Add caching of JSON schema conversions to JsonConverter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ewencp/kafka

[jira] [Commented] (KAFKA-2474) Add caching for converted Copycat schemas in JSONConverter

[ https://issues.apache.org/jira/browse/KAFKA-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14910109#comment-14910109 ] ASF GitHub Bot commented on KAFKA-2474: --- GitHub user ewencp opened a pull request:

[jira] [Created] (KAFKA-2586) Enable SSL for inter-broker communication in SSL tests

Ismael Juma created KAFKA-2586: -- Summary: Enable SSL for inter-broker communication in SSL tests Key: KAFKA-2586 URL: https://issues.apache.org/jira/browse/KAFKA-2586 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-2058) ProducerTest.testSendWithDeadBroker transient failure

[ https://issues.apache.org/jira/browse/KAFKA-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933107#comment-14933107 ] Rohinee Ashok Shinde commented on KAFKA-2058: - We have faced the same issue while running

[jira] [Commented] (KAFKA-2581) Run all existing ducktape tests with SSL-enabled clients and brokers

[ https://issues.apache.org/jira/browse/KAFKA-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933156#comment-14933156 ] Rajini Sivaram commented on KAFKA-2581: --- [~ewencp] [~ijuma] Thank you for the input. We would

Build failed in Jenkins: Kafka-trunk #647

See Changes: [cshapi] KAFKA-2585; ConsoleConsumer should not hang infinitely upon exception [cshapi] MINOR: Make indenting in `checkstyle.xml` and `import-control.xml` consistent -- [...truncated

[jira] [Commented] (KAFKA-2587) Transient test failure: `SimpleAclAuthorizerTest`

[ https://issues.apache.org/jira/browse/KAFKA-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934222#comment-14934222 ] Ismael Juma commented on KAFKA-2587: Another failure:

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934290#comment-14934290 ] Edward Ribeiro commented on KAFKA-2578: --- Thanks, mate! :) > Client Metadata internal state should

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review100885 ---

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/ --- (Updated Sept. 28, 2015, 11:13 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-28_16:13:02.patch > Add a request timeout to NetworkClient >

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review100880 --- core/src/main/scala/kafka/server/KafkaConfig.scala (line 67)

[jira] [Assigned] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned KAFKA-2578: - Assignee: Edward Ribeiro (was: Jason Gustafson) > Client Metadata internal state should

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934281#comment-14934281 ] Jason Gustafson commented on KAFKA-2578: [~eribeiro] Absolutely, feel free to assign to yourself..

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934308#comment-14934308 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard

Re: Review Request 36858: Patch for KAFKA-2120

> On Sept. 28, 2015, 11:04 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala, line > > 109 > > > > > > The request time outs in those classes are mainly used for

[jira] [Commented] (KAFKA-1804) Kafka network thread lacks top exception handler

[ https://issues.apache.org/jira/browse/KAFKA-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934173#comment-14934173 ] Sriharsha Chintalapani commented on KAFKA-1804: --- [~olindaspider] that sounds right to me.

[jira] [Commented] (KAFKA-1804) Kafka network thread lacks top exception handler

[ https://issues.apache.org/jira/browse/KAFKA-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934214#comment-14934214 ] Patrick J. McNerthney commented on KAFKA-1804: -- I was not planning on sending a patch. I have

[jira] [Commented] (KAFKA-2578) Client Metadata internal state should be synchronized

[ https://issues.apache.org/jira/browse/KAFKA-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934269#comment-14934269 ] Edward Ribeiro commented on KAFKA-2578: --- Hey, [~hachikuji], this patch is so trivial... would you

Re: Review Request 36858: Patch for KAFKA-2120

> On Sept. 28, 2015, 11:04 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala, line > > 109 > > > > > > The request time outs in those classes are mainly used for

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/ --- (Updated Sept. 28, 2015, 11:16 p.m.) Review request for kafka. Bugs:

[jira] [Created] (KAFKA-2596) Coordinator should return illegal generation for commits from unknown groups with non-negative generation

Jason Gustafson created KAFKA-2596: -- Summary: Coordinator should return illegal generation for commits from unknown groups with non-negative generation Key: KAFKA-2596 URL:

[DISCUSS] KIP-36 - Rack aware replica assignment

Hello Kafka Developers, I just created KIP-36 for rack aware replica assignment. https://cwiki.apache.org/confluence/display/KAFKA/KIP-36+Rack+aware+replica+assignment The goal is to utilize the isolation provided by the racks in data center and distribute replicas to racks to provide fault

Re: [DISCUSS] KIP-35 - Retrieve protocol version

Thanks for the writeup. I also think having a specific protocol for client-broker version negotiation is better. I'm wondering is it better to let the broker to decide the version to use? It might have some value If brokers have preference for a particular version. Using a global version is a

[jira] [Commented] (KAFKA-2587) Transient test failure: `SimpleAclAuthorizerTest`

[ https://issues.apache.org/jira/browse/KAFKA-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934498#comment-14934498 ] Parth Brahmbhatt commented on KAFKA-2587: - [~ijuma] I tried to reproduce this locally by running

[jira] [Work started] (KAFKA-2587) Transient test failure: `SimpleAclAuthorizerTest`

[ https://issues.apache.org/jira/browse/KAFKA-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2587 started by Parth Brahmbhatt. --- > Transient test failure: `SimpleAclAuthorizerTest` >

[GitHub] kafka pull request: KAFKA-2587:Increasing timeout for the test ver...

GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/kafka/pull/260 KAFKA-2587:Increasing timeout for the test verification. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Parth-Brahmbhatt/kafka

[jira] [Commented] (KAFKA-2587) Transient test failure: `SimpleAclAuthorizerTest`

[ https://issues.apache.org/jira/browse/KAFKA-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934499#comment-14934499 ] ASF GitHub Bot commented on KAFKA-2587: --- GitHub user Parth-Brahmbhatt opened a pull request:

[jira] [Commented] (KAFKA-2597) Add Eclipse directories to .gitignore

[ https://issues.apache.org/jira/browse/KAFKA-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934447#comment-14934447 ] ASF GitHub Bot commented on KAFKA-2597: --- GitHub user rhauch opened a pull request:

[GitHub] kafka pull request: KAFKA-2597: Add to .gitignore the Eclipse IDE ...

GitHub user rhauch opened a pull request: https://github.com/apache/kafka/pull/259 KAFKA-2597: Add to .gitignore the Eclipse IDE directories The ` .metadata` and `.recommenders` keep IDE workspace state and should not be committed. You can merge this pull request into a Git

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

I tend to like the idea of a pluggable locator. For example, we already have an interface for discovering information about the physical location of servers. I don't relish the idea of having to maintain data in multiple places. -Todd On Mon, Sep 28, 2015 at 4:48 PM, Aditya Auradkar <

[jira] [Created] (KAFKA-2597) Add Eclipse directories to .gitignore

Randall Hauch created KAFKA-2597: Summary: Add Eclipse directories to .gitignore Key: KAFKA-2597 URL: https://issues.apache.org/jira/browse/KAFKA-2597 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-2586) Enable SSL for inter-broker communication in SSL tests

[ https://issues.apache.org/jira/browse/KAFKA-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2586: --- Reviewer: Jun Rao Status: Patch Available (was: Open) [~junrao], can you please review?

[GitHub] kafka pull request: HOTFIX: Checkstye fixes follow up for KAKFA-25...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request: MINOR: Fix FileStreamSourceTask to create the ...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (KAFKA-2058) ProducerTest.testSendWithDeadBroker transient failure

[ https://issues.apache.org/jira/browse/KAFKA-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933260#comment-14933260 ] Bill Bejeck commented on KAFKA-2058: I've been trying to reproduce this error locally without much

[GitHub] kafka pull request: Enable SSL for inter-broker communication when...

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/252 Enable SSL for inter-broker communication when SSL is enabled in tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka