[jira] [Commented] (KAFKA-4368) Unclean shutdown breaks Kafka cluster

2016-11-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631715#comment-15631715 ] huxi commented on KAFKA-4368: - Could you paste the entire stack trace for both client and server ? > Unclean

Re: [DISCUSS] KIP-84: Support SASL/SCRAM mechanisms

2016-11-02 Thread Ewen Cheslack-Postava
I think the bump isn't strictly required, but if the client is KIP-35 aware, it can proactively choose a compatible SASL mechanism based on its initial ApiVersionRequest and avoid an extra connection round trip when there are client/broker version differences. Without this, a newer client would

[jira] [Commented] (KAFKA-4368) Unclean shutdown breaks Kafka cluster

2016-11-02 Thread Anukool Rattana (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631475#comment-15631475 ] Anukool Rattana commented on KAFKA-4368: Hi [~huxi_2b], Yes, although the broken broker comeback

[jira] [Commented] (KAFKA-4360) Controller may deadLock when autoLeaderRebalance encounter zk expired

2016-11-02 Thread Json Tu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631474#comment-15631474 ] Json Tu commented on KAFKA-4360: I'm sorry, I rollback one comment commit, and

[GitHub] kafka pull request #2094: KAFKA-4360:Controller may deadLock when autoLead...

2016-11-02 Thread xiguantiaozhan
GitHub user xiguantiaozhan opened a pull request: https://github.com/apache/kafka/pull/2094 KAFKA-4360:Controller may deadLock when autoLeaderRebalance encounter zk expired You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #2085: KAFKA-4360:Controller may deadLock when autoLead...

2016-11-02 Thread xiguantiaozhan
Github user xiguantiaozhan closed the pull request at: https://github.com/apache/kafka/pull/2085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (KAFKA-4368) Unclean shutdown breaks Kafka cluster

2016-11-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631259#comment-15631259 ] huxi commented on KAFKA-4368: - Do you mean the producer still cannot be able to send messages even after the

[jira] [Commented] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631227#comment-15631227 ] huxi commented on KAFKA-4370: - yes, compacted topics no longer accept messages without key and an exception is

Re: why cant SslTransportLayer be muted before handshake completion?

2016-11-02 Thread Harsha Chintalapani
HI Radai, One main reason is to keep the handshake details away from the application layer. i.e Kafka network layer which is sending Kafka protocols doesn't need to worry about the handshake details, all it needs is a validation that the connection is completed and it can start

[jira] [Commented] (KAFKA-4367) MirrorMaker shuts down gracefully without being stopped

2016-11-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631208#comment-15631208 ] huxi commented on KAFKA-4367: - Did you close the terminal where runs this command ? Based on the log, the JVM

[jira] [Resolved] (KAFKA-4348) On Mac OS, KafkaConsumer.poll returns 0 when there are still messages on Kafka server

2016-11-02 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi resolved KAFKA-4348. - Resolution: Duplicate Assignee: huxi > On Mac OS, KafkaConsumer.poll returns 0 when there are still

Re: why cant SslTransportLayer be muted before handshake completion?

2016-11-02 Thread Joel Koshy
Sriharsha can validate this, but I think the reason is that if we allow muting/unmuting at will (via those public APIs) that can completely mess up the handshake itself. It should be possible to pause/resume the handshake if that's what you'r elooking for but I'm not sure it is worth it for the

Re: [DISCUSS] KIP-82 - Add Record Headers

2016-11-02 Thread radai
my biggest issues with a "standard" wrapper format: 1. _ALL_ client _CODE_ (as opposed to kafka lib version) must be updated to know about the container, because any old naive code trying to directly deserialize its own payload would keel over and die (it needs to know to deserialize a container,

Re: [DISCUSS] KIP-82 - Add Record Headers

2016-11-02 Thread James Cheng
> On Nov 2, 2016, at 2:33 AM, Michael Pearce wrote: > > Thanks James for taking the time out. > > My comments per solution below you commented about. (I note you didn’t > comment on the 3rd at all , which is the current proposal in the kip) > 1) > a. This forces

why cant SslTransportLayer be muted before handshake completion?

2016-11-02 Thread radai
Hi, as part of testing my code for KIP-72 (broker memory control), i ran into the following code snippet in SslTransportLayer: public void removeInterestOps(int ops) { if (!key.isValid()) throw new CancelledKeyException(); else if (!handshakeComplete)

Build failed in Jenkins: kafka-trunk-jdk8 #1017

2016-11-02 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: Fix NPE when Connect offset contains non-primitive type -- [...truncated 12422 lines...] (topicPartition, new

[jira] [Commented] (KAFKA-4369) ZkClient is not closed upon streams shutdown

2016-11-02 Thread Andy Chambers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630582#comment-15630582 ] Andy Chambers commented on KAFKA-4369: -- I found this while developing a test fixture that starts up a

Re: Kafka Connect key.converter and value.converter properties for Avro encoding

2016-11-02 Thread Gwen Shapira
Both the Confluent Avro Converter and the Confluent Avro Serializer use the Schema Registry. The reason is, as Tommy Becker mentioned below, to avoid storing the entire schema in each record (which the JSON serializer in Apache Kafka does). It has few other benefits schema validation and such. If

Build failed in Jenkins: kafka-trunk-jdk7 #1668

2016-11-02 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: Fix NPE when Connect offset contains non-primitive type -- [...truncated 14343 lines...] org.apache.kafka.streams.processor.internals.assignment.TaskAssignorTest >

[GitHub] kafka-site pull request #28: Add Becket to the committers page

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread Lars Pfannenschmidt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Pfannenschmidt updated KAFKA-4370: --- Priority: Trivial (was: Minor) > CorruptRecordException when ProducerRecord

Re: [ANNOUNCE] New committer: Jiangjie (Becket) Qin

2016-11-02 Thread Eno Thereska
Congrats! Eno > On 1 Nov 2016, at 05:57, Harsha Chintalapani wrote: > > Congrats Becket! > -Harsha > > On Mon, Oct 31, 2016 at 2:13 PM Rajini Sivaram > wrote: > >> Congratulations, Becket! >> >> On Mon, Oct 31, 2016 at 8:38 PM, Matthias J. Sax

[jira] [Commented] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread Lars Pfannenschmidt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630350#comment-15630350 ] Lars Pfannenschmidt commented on KAFKA-4370: Ah... compaction was enabled on that topic for

[jira] [Commented] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630310#comment-15630310 ] Ismael Juma commented on KAFKA-4370: This should work, are there errors in the server log? >

Re: [DISCUSS] KIP-81: Max in-flight fetches

2016-11-02 Thread Mickael Maison
Thanks for all the feedback. I agree, throttling the requests sent will most likely result in a loss of throughput -> BAD ! As suggested, selectively reading from the socket should enable to control the memory usage without impacting performance. I've had look at that today and I can see how that

[jira] [Updated] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread Lars Pfannenschmidt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Pfannenschmidt updated KAFKA-4370: --- Priority: Minor (was: Major) > CorruptRecordException when ProducerRecord

[jira] [Created] (KAFKA-4370) CorruptRecordException when ProducerRecord constructed without key nor partition and send

2016-11-02 Thread Lars Pfannenschmidt (JIRA)
Lars Pfannenschmidt created KAFKA-4370: -- Summary: CorruptRecordException when ProducerRecord constructed without key nor partition and send Key: KAFKA-4370 URL:

Re: [DISCUSS] KIP-81: Max in-flight fetches

2016-11-02 Thread Jay Kreps
Hey Radai, I think there are a couple discussions here. The first is about what is the interface to the user. The other is about what is exposed in the protocol, and implementation details of reading requests. I strongly agree with giving the user a simple "use X MB of memory" config and we

Re: [DISCUSS] KIP-81: Max in-flight fetches

2016-11-02 Thread Gwen Shapira
+1 On Wed, Nov 2, 2016 at 10:34 AM, radai wrote: > In my opinion a lot of kafka configuration options were added using the > "minimal diff" approach, which results in very nuanced and complicated > configs required to indirectly achieve some goal. case in point -

Re: [DISCUSS] KIP-81: Max in-flight fetches

2016-11-02 Thread radai
In my opinion a lot of kafka configuration options were added using the "minimal diff" approach, which results in very nuanced and complicated configs required to indirectly achieve some goal. case in point - timeouts. The goal here is to control the memory requirement. the 1st config was max

Re: Kafka Connect key.converter and value.converter properties for Avro encoding

2016-11-02 Thread Tommy Becker
Although I can't speak to details of the Confluent packaging, anytime you're using Avro you need the schemas for the records you're working with. In an Avro data file the schema is included in the file itself. But when you're encoding individual records like in Kafka, most people instead

[GitHub] kafka pull request #2087: MINOR: Fix NPE when Connect offset contains non-pr...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka-site issue #28: Add Becket to the committers page

2016-11-02 Thread becketqin
Github user becketqin commented on the issue: https://github.com/apache/kafka-site/pull/28 I'll try to merge this myself :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] kafka pull request #2093: MINOR: Add description of how consumer wakeup acts...

2016-11-02 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/kafka/pull/2093 MINOR: Add description of how consumer wakeup acts if no threads are awakened I think the Javadoc should describe what happens if wakeup is called and no other thread is currently blocking. This may

[GitHub] kafka-site pull request #28: Add Becket to the committers page

2016-11-02 Thread becketqin
GitHub user becketqin opened a pull request: https://github.com/apache/kafka-site/pull/28 Add Becket to the committers page You can merge this pull request into a Git repository by running: $ git pull https://github.com/becketqin/kafka-site asf-site Alternatively you can

[jira] [Created] (KAFKA-4369) ZkClient is not closed upon streams shutdown

2016-11-02 Thread Ryan P (JIRA)
Ryan P created KAFKA-4369: - Summary: ZkClient is not closed upon streams shutdown Key: KAFKA-4369 URL: https://issues.apache.org/jira/browse/KAFKA-4369 Project: Kafka Issue Type: Bug

Re: 0.10.1.0 - KafkaConsumer.poll() blocks background heartbeat thread causing consumer to be considered dead?

2016-11-02 Thread Jaikiran Pai
Thanks Ismael. Just checked, that one doesn't look like it's the same issue, but could be a similar one. In that JIRA it looks like the issue was probably addressed for the commitSync call. However, in this specific instance the KafkaConsumer.poll(...) itself leads to locking the object

Re: 0.10.1.0 - KafkaConsumer.poll() blocks background heartbeat thread causing consumer to be considered dead?

2016-11-02 Thread Ismael Juma
Maybe https://issues.apache.org/jira/browse/KAFKA-4303? On 2 Nov 2016 10:15 am, "Jaikiran Pai" wrote: > We have been trying to narrow down an issue in 0.10.1 of Kafka in our > setups where our consumers are marked as dead very frequently causing > rebalances almost

0.10.1.0 - KafkaConsumer.poll() blocks background heartbeat thread causing consumer to be considered dead?

2016-11-02 Thread Jaikiran Pai
We have been trying to narrow down an issue in 0.10.1 of Kafka in our setups where our consumers are marked as dead very frequently causing rebalances almost every few seconds. The consumer (Java new API) then starts seeing exceptions like:

[jira] [Commented] (KAFKA-4362) Consumer can fail after reassignment of the offsets topic partition

2016-11-02 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628871#comment-15628871 ] Andrew Olson commented on KAFKA-4362: - Is there documentation that advises for a

[jira] [Commented] (KAFKA-4365) In case async producer closes the TCP connection to Kafka broker, last sent messages might be lost.

2016-11-02 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628696#comment-15628696 ] Rajini Sivaram commented on KAFKA-4365: --- [PR #1836|https://github.com/apache/kafka/pull/1836] for

[jira] [Updated] (KAFKA-3703) Handle close gracefully for consumers and producers with acks=0

2016-11-02 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-3703: -- Summary: Handle close gracefully for consumers and producers with acks=0 (was:

[jira] [Created] (KAFKA-4368) Unclean shutdown breaks Kafka cluster

2016-11-02 Thread Anukool Rattana (JIRA)
Anukool Rattana created KAFKA-4368: -- Summary: Unclean shutdown breaks Kafka cluster Key: KAFKA-4368 URL: https://issues.apache.org/jira/browse/KAFKA-4368 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-4367) MirrorMaker shuts down gracefully without being stopped

2016-11-02 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex updated KAFKA-4367: Description: Start: bin/kafka-mirror-maker.sh --new.consumer --consumer.config

[jira] [Updated] (KAFKA-4367) MirrorMaker shuts down gracefully without being stopped

2016-11-02 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex updated KAFKA-4367: Description: Start: bin/kafka-mirror-maker.sh --new.consumer --consumer.config

[jira] [Updated] (KAFKA-4367) MirrorMaker shuts down gracefully without being stopped

2016-11-02 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex updated KAFKA-4367: Description: Start: bin/kafka-mirror-maker.sh --new.consumer --consumer.config

[jira] [Created] (KAFKA-4367) MirrorMaker shuts down gracefully without being stopped

2016-11-02 Thread Alex (JIRA)
Alex created KAFKA-4367: --- Summary: MirrorMaker shuts down gracefully without being stopped Key: KAFKA-4367 URL: https://issues.apache.org/jira/browse/KAFKA-4367 Project: Kafka Issue Type: Bug

[GitHub] kafka pull request #2092: MINOR: remove commented out code and System.out.pr...

2016-11-02 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/2092 MINOR: remove commented out code and System.out.println Remove commented out code and System.out.println from KTableKTableJoinIntegrationTest You can merge this pull request into a Git repository by

[jira] [Work started] (KAFKA-4366) KafkaStreams.close() blocks indefinitely

2016-11-02 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4366 started by Damian Guy. - > KafkaStreams.close() blocks indefinitely >

[jira] [Assigned] (KAFKA-4366) KafkaStreams.close() blocks indefinitely

2016-11-02 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy reassigned KAFKA-4366: - Assignee: Damian Guy (was: Guozhang Wang) > KafkaStreams.close() blocks indefinitely >

[jira] [Commented] (KAFKA-4348) On Mac OS, KafkaConsumer.poll returns 0 when there are still messages on Kafka server

2016-11-02 Thread Yiquan Zhou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628551#comment-15628551 ] Yiquan Zhou commented on KAFKA-4348: Yes it's very likely the same issue as KAFKA-3135. I can

[GitHub] kafka pull request #2091: MINOR: Bug fixed

2016-11-02 Thread himani1
GitHub user himani1 opened a pull request: https://github.com/apache/kafka/pull/2091 MINOR: Bug fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/himani1/kafka minor_fix Alternatively you can review and apply these changes

[jira] [Commented] (KAFKA-4355) StreamThread intermittently dies with "Topic not found during partition assignment" when broker restarted

2016-11-02 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628442#comment-15628442 ] Michal Borowiecki commented on KAFKA-4355: -- KAFKA-4366 created for the KafkaSteams.close()

[jira] [Created] (KAFKA-4366) KafkaStreams.close() blocks indefinitely

2016-11-02 Thread Michal Borowiecki (JIRA)
Michal Borowiecki created KAFKA-4366: Summary: KafkaStreams.close() blocks indefinitely Key: KAFKA-4366 URL: https://issues.apache.org/jira/browse/KAFKA-4366 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-4365) In case async producer closes the TCP connection to Kafka broker, last sent messages might be lost.

2016-11-02 Thread Ciprian Pascu (JIRA)
Ciprian Pascu created KAFKA-4365: Summary: In case async producer closes the TCP connection to Kafka broker, last sent messages might be lost. Key: KAFKA-4365 URL: https://issues.apache.org/jira/browse/KAFKA-4365

Kafka Connect key.converter and value.converter properties for Avro encoding

2016-11-02 Thread david.franklin
I am using Kafka Connect in source mode i.e. using it to send events to Kafka topics. With the key.converter and value.converter properties set to org.apache.kafka.connect.storage.StringConverter I can attach a consumer to the topics and see the events in a readable form. This is helpful and

Re: [DISCUSS] KIP-82 - Add Record Headers

2016-11-02 Thread Michael Pearce
Thanks James for taking the time out. My comments per solution below you commented about. (I note you didn’t comment on the 3rd at all , which is the current proposal in the kip) 1) a. This forces all clients to have distinct knowledge of platform level implementation detail b. enforces

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-11-02 Thread Michael Pearce
Hi Joel , et al. Any comments on the below idea to handle roll out / compatibility of this feature, using a configuration? Does it make sense/clear? Does it add value? Do we want to enforce flag by default, or value by default, or both? Cheers Mike On 10/27/16, 4:47 PM, "Michael Pearce"

Re: [DISCUSS] KIP-87 - Add Compaction Tombstone Flag

2016-11-02 Thread Michael Pearce
Hi James, We would send currently our message headers wrapper so we can have some platform/audit data even on the delete available. We find having a custom wrapper means some of our internal platform pieces we currently cannot open source or share but would love to (see kip-82) This data

[jira] [Commented] (KAFKA-3986) completedReceives can contain closed channels

2016-11-02 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627907#comment-15627907 ] Jason Gustafson commented on KAFKA-3986: I think this is handled in the patch for KAFKA-3703:

[jira] [Commented] (KAFKA-4348) On Mac OS, KafkaConsumer.poll returns 0 when there are still messages on Kafka server

2016-11-02 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627866#comment-15627866 ] Jason Gustafson commented on KAFKA-4348: This sounds like the same issue as KAFKA-3135. We never