[jira] [Commented] (KAFKA-5055) Kafka Streams skipped-records-rate sensor producing nonzero values even when FailOnInvalidTimestamp is used as extractor

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990127#comment-15990127 ] Matthias J. Sax commented on KAFKA-5055: [~guozhang] Can you add Davor to the contributor list, so

[jira] [Commented] (KAFKA-5055) Kafka Streams skipped-records-rate sensor producing nonzero values even when FailOnInvalidTimestamp is used as extractor

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990126#comment-15990126 ] Matthias J. Sax commented on KAFKA-5055: [~dpoldrugo] Thanks a lot for looking into this. I agree

[jira] [Commented] (KAFKA-5055) Kafka Streams skipped-records-rate sensor producing nonzero values even when FailOnInvalidTimestamp is used as extractor

2017-04-29 Thread Davor Poldrugo (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990086#comment-15990086 ] Davor Poldrugo commented on KAFKA-5055: --- Hi guys! I think the problem is because of a bug in the

[jira] [Updated] (KAFKA-4593) Task migration during rebalance callback process could lead the obsoleted task's IllegalStateException

2017-04-29 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Borowiecki updated KAFKA-4593: - Description: 1. Assume 2 running threads A and B, and one task t1 just for simplicity.

[jira] [Assigned] (KAFKA-5137) Controlled shutdown timeout message improvement

2017-04-29 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-5137: Assignee: Umesh Chaudhary > Controlled shutdown timeout message improvement >

Re: new contributor

2017-04-29 Thread Guozhang Wang
Hello Bryan, I have added you to the list. Though KAFKA-5137 seems to be worked on by Umesh Chaudhary already, could you take a look at another ticket? Guozhang On Thu, Apr 27, 2017 at 8:23 PM, Bryan Karlovitz < bryan.a.karlov...@gmail.com> wrote: > Hello, > > My name is Bryan. I'd like to be

[jira] [Commented] (KAFKA-4785) Records from internal repartitioning topics should always use RecordMetadataTimestampExtractor

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989989#comment-15989989 ] Matthias J. Sax commented on KAFKA-4785: IMHO, KAFKA-4219 is quite different: This JIRA is a "bug

[jira] [Comment Edited] (KAFKA-4785) Records from internal repartitioning topics should always use RecordMetadataTimestampExtractor

2017-04-29 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989838#comment-15989838 ] Jeyhun Karimov edited comment on KAFKA-4785 at 4/29/17 6:08 PM: [~mjsax],

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2017-04-29 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989988#comment-15989988 ] Jeyhun Karimov commented on KAFKA-3745: --- [~sree2k] is there an update on issue? > Consider adding

[jira] [Commented] (KAFKA-4218) Enable access to key in ValueTransformer

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989985#comment-15989985 ] Matthias J. Sax commented on KAFKA-4218: Sounds reasonable. > Enable access to key in

[jira] [Commented] (KAFKA-3940) Log should check the return value of dir.mkdirs()

2017-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989979#comment-15989979 ] ASF GitHub Bot commented on KAFKA-3940: --- GitHub user mimaison opened a pull request:

[GitHub] kafka pull request #2944: KAFKA-3940: Replaced File.mkdir/mkdirs/delete by t...

2017-04-29 Thread mimaison
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2944 KAFKA-3940: Replaced File.mkdir/mkdirs/delete by their Files equivalent You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-29 Thread Matthias J. Sax
I understand that we cannot just break stuff (btw: also not for Streams!). But deprecating does not break anything, so I don't think it's a big deal to change the API as long as we keep the old API as deprecated. -Matthias On 4/29/17 9:28 AM, Jay Kreps wrote: > Hey Matthias, > > Yeah I agree,

[jira] [Comment Edited] (KAFKA-4772) Exploit #peek to implement #print() and other methods

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989947#comment-15989947 ] Matthias J. Sax edited comment on KAFKA-4772 at 4/29/17 5:05 PM: - The

[jira] [Commented] (KAFKA-4772) Exploit #peek to implement #print() and other methods

2017-04-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989947#comment-15989947 ] Matthias J. Sax commented on KAFKA-4772: The other PR is old and outdated. It seem the author did

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-29 Thread Jay Kreps
Hey Matthias, Yeah I agree, I'm not against change as a general thing! I also think if you look back on the last two years, we completely rewrote the producer and consumer APIs, reworked the binary protocol many times over, and added the connector and stream processing apis, both major new

[DISCUSS] KIP-146: Classloading Isolation in Connect

2017-04-29 Thread Konstantine Karantasis
* Because of KIP number collision, please disregard my previous KIP announcement and use this thread for discussion instead * Hi everyone, we aim to address dependency conflicts in Kafka Connect soon by applying class loading isolation. Feel free to take a look at KIP-146 here:

Re: Kafka-Streams: Cogroup

2017-04-29 Thread Kyle Winkelman
I don't seem to have permission. When logged in I can neither edit the main page nor create an additional KIP. Thanks, Kyle On Thu, Apr 27, 2017 at 12:35 PM, Eno Thereska wrote: > Hi Kyle, > > I believe Guozhang has now given you permission to edit the KIP wiki at >

[GitHub] kafka pull request #2943: kafka-5413: Windows platform does not offer kafka-...

2017-04-29 Thread amethystic
GitHub user amethystic opened a pull request: https://github.com/apache/kafka/pull/2943 kafka-5413: Windows platform does not offer kafka-broker-api-versions.bat Added kafka-broker-api-versions.bat for Windows platform You can merge this pull request into a Git repository by

[jira] [Created] (KAFKA-5143) Windows platform does not offer kafka-broker-api-versions.bat

2017-04-29 Thread huxi (JIRA)
huxi created KAFKA-5143: --- Summary: Windows platform does not offer kafka-broker-api-versions.bat Key: KAFKA-5143 URL: https://issues.apache.org/jira/browse/KAFKA-5143 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-4785) Records from internal repartitioning topics should always use RecordMetadataTimestampExtractor

2017-04-29 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989838#comment-15989838 ] Jeyhun Karimov commented on KAFKA-4785: --- [~mjsax], as it is discussed in KAFKA-4218 , we can group

[jira] [Commented] (KAFKA-4218) Enable access to key in ValueTransformer

2017-04-29 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989837#comment-15989837 ] Jeyhun Karimov commented on KAFKA-4218: --- [~mjsax], thanks for your comments. I absolutely agree on

Re: KIP-82 Record Headers Update

2017-04-29 Thread Michael Pearce
Hi All, This is all committed now. There are a few minor changes that had to be made, due to Java 8 features not yet able to use, awaiting KIP-118. • Header static interface method: “static Header create(String key, byte[] value)” o This required java8 as interface static method o Jason

[jira] [Commented] (KAFKA-5142) KIP-145 - Expose Record Headers in Kafka Connect

2017-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989790#comment-15989790 ] ASF GitHub Bot commented on KAFKA-5142: --- GitHub user michaelandrepearce opened a pull request:

[DISCUSS] KIP 145 - Expose Record Headers in Kafka Connect

2017-04-29 Thread Michael Pearce
Hi All, Now KIP-82 is committed I would like to discuss extending the work to expose it in Kafka Connect, its primary focus being so connectors that may do similar tasks as MirrorMakers, either Kafka->Kafka or JMS-Kafka would be able to replicate the headers. It would be ideal but not

[GitHub] kafka pull request #2942: KAFKA-5142: Expose Record Headers in Kafka Connect

2017-04-29 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/kafka/pull/2942 KAFKA-5142: Expose Record Headers in Kafka Connect as per KIP-145 Add constructors to Connect/Source/SinkRecord to take Iterable add accessor method to ConnectRecord "Headers

[jira] [Created] (KAFKA-5142) KIP-145 - Expose Record Headers in Kafka Connect

2017-04-29 Thread Michael Andre Pearce (IG) (JIRA)
Michael Andre Pearce (IG) created KAFKA-5142: Summary: KIP-145 - Expose Record Headers in Kafka Connect Key: KAFKA-5142 URL: https://issues.apache.org/jira/browse/KAFKA-5142 Project: Kafka