Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Sriram Subramanian
+1 On Fri, Sep 8, 2017 at 3:04 PM, Guozhang Wang wrote: > +1, thanks. > > On Fri, Sep 8, 2017 at 1:54 PM, Bill Bejeck wrote: > > > +1 > > > > Thanks, > > Bill > > > > On Fri, Sep 8, 2017 at 4:51 PM, Matthias J. Sax > > wrote: > > >

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Sriram Subramanian
+1 On Fri, Sep 8, 2017 at 4:33 PM, Randall Hauch wrote: > +1 (non-binding) > > Randall > > On Fri, Sep 8, 2017 at 6:32 PM, Ted Yu wrote: > > > Hi, > > Please take a look at the following and cast your vote: > > > >

[jira] [Created] (KAFKA-5865) Expiring batches with idempotence enabled could cause data loss.

2017-09-08 Thread Apurva Mehta (JIRA)
Apurva Mehta created KAFKA-5865: --- Summary: Expiring batches with idempotence enabled could cause data loss. Key: KAFKA-5865 URL: https://issues.apache.org/jira/browse/KAFKA-5865 Project: Kafka

[jira] [Resolved] (KAFKA-5845) KafkaController should send LeaderAndIsrRequest to broker which starts very soon after shutdown

2017-09-08 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-5845. - Resolution: Won't Fix > KafkaController should send LeaderAndIsrRequest to broker which starts very >

[GitHub] kafka pull request #3803: KAFKA-5845; KafkaController should send LeaderAndI...

2017-09-08 Thread lindong28
Github user lindong28 closed the pull request at: https://github.com/apache/kafka/pull/3803 ---

Re: [VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Randall Hauch
+1 (non-binding) Randall On Fri, Sep 8, 2017 at 6:32 PM, Ted Yu wrote: > Hi, > Please take a look at the following and cast your vote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 197+Connect+REST+API+should+include+the+connector+type+ >

[VOTE] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Ted Yu
Hi, Please take a look at the following and cast your vote: https://cwiki.apache.org/confluence/display/KAFKA/KIP- 197+Connect+REST+API+should+include+the+connector+type+ when+describing+a+connector Thanks

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Randall Hauch
Looks good to me! Thanks again! I say go ahead and ask for a vote in a new thread. Randall On Fri, Sep 8, 2017 at 6:22 PM, Ted Yu wrote: > Lowercase constants are generated by the enum. > > Updated KIP again. > > On Fri, Sep 8, 2017 at 4:08 PM, Randall Hauch

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Ted Yu
Lowercase constants are generated by the enum. Updated KIP again. On Fri, Sep 8, 2017 at 4:08 PM, Randall Hauch wrote: > One more thing. I wonder if we should use lowercase constants for the types > rather than mixed case: "sink" and "source" (rather than "Sink" and >

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Randall Hauch
One more thing. I wonder if we should use lowercase constants for the types rather than mixed case: "sink" and "source" (rather than "Sink" and "Source"). Thoughts? On Fri, Sep 8, 2017 at 6:02 PM, Ted Yu wrote: > Updated the KIP accordingly. > > Cheers > > On Fri, Sep 8,

[GitHub] kafka pull request #3822: KAFKA-5792: Fix Transient failure in KafkaAdminCli...

2017-09-08 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3822 KAFKA-5792: Fix Transient failure in KafkaAdminClientTest.testHandleT… …imeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Ted Yu
Updated the KIP accordingly. Cheers On Fri, Sep 8, 2017 at 3:57 PM, Randall Hauch wrote: > Hi, Ted. Thanks for the quick turn around. > > I didn't remember that the response to the "/connectors/{name}/config" is > the actual configuration, so we probably shouldn't add "type"

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Randall Hauch
Hi, Ted. Thanks for the quick turn around. I didn't remember that the response to the "/connectors/{name}/config" is the actual configuration, so we probably shouldn't add "type" there. Sorry about that. And in the "/connector/{name}/status" response, I wonder if it would be better to embed the

Build failed in Jenkins: kafka-trunk-jdk7 #2739

2017-09-08 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: make Printed copy ctor protected [wangguoz] MINOR: make Consumed copy ctor protected -- [...truncated 922.29 KB...]

Build failed in Jenkins: kafka-trunk-jdk8 #1999

2017-09-08 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5853; implement WindowedKStream [damian.guy] KAFKA-5815; add Printed class and KStream#print(printed) [ismael] KAFKA-5790, KAFKA-5607; Improve error handling in SocketServer to

[GitHub] kafka pull request #3821: Catch JsonMappingException subclass

2017-09-08 Thread rhardouin
GitHub user rhardouin opened a pull request: https://github.com/apache/kafka/pull/3821 Catch JsonMappingException subclass `InvalidTypeIdException` cannot be catched currently You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Guozhang Wang
+1, thanks. On Fri, Sep 8, 2017 at 1:54 PM, Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Fri, Sep 8, 2017 at 4:51 PM, Matthias J. Sax > wrote: > > > We want to deprecate it for 1.0.0 release. Unclear how long to keep it. > > > > The point is, that

Build failed in Jenkins: kafka-trunk-jdk7 #2738

2017-09-08 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-5852: Add filter, filterNot, mapValues and Materialized to KTable -- [...truncated 2.50 MB...]

Build failed in Jenkins: kafka-trunk-jdk8 #1998

2017-09-08 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Update dependencies for 1.0.0 part 2 -- [...truncated 771.18 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

Jenkins build is back to normal : kafka-0.11.0-jdk7 #303

2017-09-08 Thread Apache Jenkins Server
See

[GitHub] kafka pull request #3820: KAFKA-5864; ReplicaFetcherThread.processPartitionD...

2017-09-08 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3820 KAFKA-5864; ReplicaFetcherThread.processPartitionData() should throw KafkaStorageException if replica is offline You can merge this pull request into a Git repository by running: $ git

[jira] [Created] (KAFKA-5864) ReplicaFetcherThread.processPartitionData() should throw KafkaStorageException if replica is offline

2017-09-08 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5864: --- Summary: ReplicaFetcherThread.processPartitionData() should throw KafkaStorageException if replica is offline Key: KAFKA-5864 URL: https://issues.apache.org/jira/browse/KAFKA-5864

[GitHub] kafka pull request #3816: MINOR: make Consumed copy ctor protected

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3816 ---

[GitHub] kafka pull request #3817: MINOR: make Printed copy ctor protected

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3817 ---

[GitHub] kafka pull request #3819: [DO NOT MERGE] KAFKA-5576: RocksDB upgrade to 5.7....

2017-09-08 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3819 [DO NOT MERGE] KAFKA-5576: RocksDB upgrade to 5.7.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-rocksDB-573

[GitHub] kafka pull request #3807: KAFKA-5852: Add filter, filterNot, mapValues and M...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3807 ---

[jira] [Resolved] (KAFKA-5852) Add filter, filterNot, mapValues and Materialized to KTable

2017-09-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-5852. -- Resolution: Fixed Issue resolved by pull request 3807

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Bill Bejeck
+1 Thanks, Bill On Fri, Sep 8, 2017 at 4:51 PM, Matthias J. Sax wrote: > We want to deprecate it for 1.0.0 release. Unclear how long to keep it. > > The point is, that the parameter will just be ignored after it got > deprecated and thus has no effect anymore when

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Matthias J. Sax
We want to deprecate it for 1.0.0 release. Unclear how long to keep it. The point is, that the parameter will just be ignored after it got deprecated and thus has no effect anymore when running the tool. Thus, we can keep it as long as we think some people might have scripts that used the

[jira] [Created] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

2017-09-08 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5863: - Summary: Potential null dereference in DistributedHerder#reconfigureConnector() Key: KAFKA-5863 URL: https://issues.apache.org/jira/browse/KAFKA-5863 Project: Kafka

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Ted Yu
bq. parameter `--zookeper` that will be deprecated. Can you clarify in which release the parameter will be deprecated and in which release it will be removed ? On Fri, Sep 8, 2017 at 1:15 PM, Matthias J. Sax wrote: > Hi, > > I want to propose KIP-198 for 1.0.0 release.

Jenkins build is back to normal : kafka-trunk-jdk7 #2737

2017-09-08 Thread Apache Jenkins Server
See

[VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-08 Thread Matthias J. Sax
Hi, I want to propose KIP-198 for 1.0.0 release. It's about removing ZK dependency from Streams application reset tool. It's a fairly simply KIP, such I want to start the vote immediately. https://cwiki.apache.org/confluence/display/KAFKA/KIP-198%3A+Remove+ZK+dependency+from+Streams+Reset+Tool

Build failed in Jenkins: kafka-0.11.0-jdk7 #302

2017-09-08 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-5797: Handle metadata not available in store registration -- [...truncated 862.40 KB...] kafka.api.SaslScramSslEndToEndAuthorizationTest >

[jira] [Created] (KAFKA-5862) Remove ZK dependency from Streams reset tool

2017-09-08 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5862: -- Summary: Remove ZK dependency from Streams reset tool Key: KAFKA-5862 URL: https://issues.apache.org/jira/browse/KAFKA-5862 Project: Kafka Issue Type:

Build failed in Jenkins: kafka-trunk-jdk7 #2736

2017-09-08 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5815; add Printed class and KStream#print(printed) -- [...truncated 2.51 MB...]

Re: [VOTE] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-08 Thread Jason Gustafson
+1. Thanks for the KIP. On Fri, Sep 8, 2017 at 8:17 AM, Sumant Tambe wrote: > Updated. > > On 8 September 2017 at 02:04, Ismael Juma wrote: > > > Thanks for the KIP. +1 (binding) from me. Just a minor suggestion, I > would > > mention the following under

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Ted Yu
Thanks for the reminder, Randall. I have modified the KIP to include these two endpoints. On Fri, Sep 8, 2017 at 11:00 AM, Randall Hauch wrote: > Hi, Ted. > > Thanks for creating this KIP and for working on the implementation. The > proposal looks great for the

[GitHub] kafka pull request #3818: MINOR: KAFKA-5742 follow-up, fix incorrect method ...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3818 ---

[GitHub] kafka pull request #3631: KAFKA-5708: jackson upgrade (2.8.5 -> 2.9.1)

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3631 ---

Re: [DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Randall Hauch
Hi, Ted. Thanks for creating this KIP and for working on the implementation. The proposal looks great for the "/connectors/{name}" endpoint, but there are several others that we need to consider as well so that the responses are all consistent. In particular, look at "/connectors/{name}/status"

[GitHub] kafka pull request #3548: KAFKA-5790, KAFKA-5607; Improve error handling in ...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3548 ---

[jira] [Created] (KAFKA-5861) KStream stop( withTimeout ) - does not work under load conditions in the multithreaded KStream application

2017-09-08 Thread Seweryn Habdank-Wojewodzki (JIRA)
Seweryn Habdank-Wojewodzki created KAFKA-5861: - Summary: KStream stop( withTimeout ) - does not work under load conditions in the multithreaded KStream application Key: KAFKA-5861 URL:

[GitHub] kafka pull request #3818: MINOR: KAFKA-5742 follow-up, fix incorrect method ...

2017-09-08 Thread xvrl
GitHub user xvrl opened a pull request: https://github.com/apache/kafka/pull/3818 MINOR: KAFKA-5742 follow-up, fix incorrect method name @ewencp @ijuma You can merge this pull request into a Git repository by running: $ git pull https://github.com/xvrl/kafka fix-startswith

[GitHub] kafka pull request #3817: MINOR: make Printed copy ctor protected

2017-09-08 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3817 MINOR: make Printed copy ctor protected You can merge this pull request into a Git repository by running: $ git pull https://github.com/dguy/kafka printed-ctor-protected Alternatively you can

[jira] [Resolved] (KAFKA-2392) Kafka Server does not accept 0 as a port

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-2392. -- Resolution: Fixed Kafka supports port 0 for unit tests. As mentioned in the previous comment,

[GitHub] kafka pull request #3768: KAFKA-5815: add Printed class and KStream#print(pr...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3768 ---

[GitHub] kafka pull request #3816: MINOR: make Consumed copy ctor protected

2017-09-08 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3816 MINOR: make Consumed copy ctor protected You can merge this pull request into a Git repository by running: $ git pull https://github.com/dguy/kafka consumed-ctor Alternatively you can review

[GitHub] kafka pull request #3806: KAFKA-5797: Handle metadata not available in store...

2017-09-08 Thread guozhangwang
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3806 ---

[DISCUSS] KIP-197: Include Connector type in Connector REST API

2017-09-08 Thread Ted Yu
Hi, Please take a look at: https://cwiki.apache.org/confluence/display/KAFKA/KIP-197+Connect+REST+API+should+include+the+connector+type+when+describing+a+connector Thanks

[jira] [Created] (KAFKA-5860) Prevent non-consecutive partition ids

2017-09-08 Thread Tom Bentley (JIRA)
Tom Bentley created KAFKA-5860: -- Summary: Prevent non-consecutive partition ids Key: KAFKA-5860 URL: https://issues.apache.org/jira/browse/KAFKA-5860 Project: Kafka Issue Type: Improvement

[jira] [Resolved] (KAFKA-2319) After controlled shutdown: IllegalStateException: Kafka scheduler has not been started

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-2319. -- Resolution: Fixed This was fixed in newer versions. Pl reopen if you think the issue still exists >

[VOTE] KIP-195: AdminClient.createPartitions()

2017-09-08 Thread Tom Bentley
I would like to start the vote on KIP-195 which adds an AdminClient API for increasing the number of partitions of a topic. The details are here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-195%3A+AdminClient.createPartitions Cheers, Tom

Re: Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Kamal Chandraprakash
Selvamalar, It's a self service. Please send a mail to ` dev-unsubscr...@kafka.apache.org` and `users-unsubscr...@kafka.apache.org` to unsubscribe from the `dev On Fri, Sep 8, 2017 at 10:02 PM, Selvamalar Arunkumar < selvamalar.arunku...@walmart.com> wrote: > Please remove my email id from

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Ismael Juma
Hi Tom, Maybe we should disallow the creation of partitions while a reassignment is in progress. As you pointed out, there are weird edge cases. We can relax the restriction later, if needed. Ismael On Fri, Sep 8, 2017 at 5:28 PM, Tom Bentley wrote: > I've gone with

Build failed in Jenkins: kafka-trunk-jdk7 #2735

2017-09-08 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5853; implement WindowedKStream -- [...truncated 922.88 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[jira] [Resolved] (KAFKA-1817) AdminUtils.createTopic vs kafka-topics.sh --create with partitions

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1817. -- Resolution: Fixed Fixed in KAFKA-1737 > AdminUtils.createTopic vs kafka-topics.sh --create with

RE: Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Selvamalar Arunkumar
Please remove my email id from the group. Regards, SelvaMalar Connect With http://www.walmart.com/ https://twitter.com/Walmart 805 Moberly Lane Bentonville, AR 72716-0560 Save Money. Live Better. -Original Message- From: Tom Bentley [mailto:t.j.bent...@gmail.com] Sent: Friday,

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Tom Bentley
I've gone with createPartitions() and NewPartitions. To answer my own question about the replication factor, the current code (specifically AdminUtils.addPartitions()) just uses the size of the replica list of the first partition as the replication factor for the whole topic. I don't think this

[jira] [Resolved] (KAFKA-1608) Windows: Error: Could not find or load main class org.apache.zookeeper.server.quorum.QuorumPeerMain

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1608. -- Resolution: Fixed This was fixed in newer versions. Pl reopen if you think the issue still exists >

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-08 Thread Rajini Sivaram
Thank you, Jun. If there are no other concerns by the end of the day, I will close the vote tomorrow. On Fri, Sep 8, 2017 at 5:09 PM, Jun Rao wrote: > Hi, Raijini, > > Thanks for the explanation. We can leave those as they are then. > > Jun > > On Thu, Sep 7, 2017 at 3:23

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-08 Thread Jun Rao
Hi, Raijini, Thanks for the explanation. We can leave those as they are then. Jun On Thu, Sep 7, 2017 at 3:23 AM, Rajini Sivaram wrote: > Hi all, > > I have added one more metric to KIP-188 to show the current status of > broker's ZooKeeper connections. Please let me

Re: request for permission to create KIP

2017-09-08 Thread Guozhang Wang
Hello Ted, I have granted you the permission. Cheers. Guozhang On Fri, Sep 8, 2017 at 8:25 AM, Ted Yu wrote: > Hi, > My wiki username is tedyu > > Can someone grant me permission to create KIP ? > > Thanks > -- -- Guozhang

[GitHub] kafka pull request #3809: KAFKA-5853: implement WindowedKStream

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3809 ---

[jira] [Resolved] (KAFKA-5853) Add WindowedKStream interface and implemenation

2017-09-08 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-5853. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 3809

[jira] [Resolved] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-251. - Resolution: Won't Fix Closing inactive issue as per above comments. > The ConsumerStats MBean's

Jenkins build is back to normal : kafka-trunk-jdk8 #1997

2017-09-08 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Tom Bentley
Putting aside the naming question for a moment, I have an implementation question: I'm looking at applying the createTopicPolicy to the new partition count. (As mentioned elsewhere, this is necessary to avoid creating a trivial loophole in the policy where a user creates and then modifies a topic

Re: [VOTE] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-09-08 Thread Tom Bentley
Since no one has objected, I conclude that this KIP is again accepted. Thanks, Tom On 7 September 2017 at 22:31, Guozhang Wang wrote: > Hi Tom, > > The updated part in "AdminClient:electPreferredLeaders()" looks reasonable > to me. If there is no objections from the voted

request for permission to create KIP

2017-09-08 Thread Ted Yu
Hi, My wiki username is tedyu Can someone grant me permission to create KIP ? Thanks

Re: [VOTE] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-08 Thread Sumant Tambe
Updated. On 8 September 2017 at 02:04, Ismael Juma wrote: > Thanks for the KIP. +1 (binding) from me. Just a minor suggestion, I would > mention the following under "Public Interfaces": > > Default value of delivery.timeout.ms = 120 seconds > Default value of retries will be

Re: [VOTE] KIP-131 - Add access to OffsetStorageReader from SourceConnector

2017-09-08 Thread Gwen Shapira
Basically, you are saying that the part where the comment says: "Offset data should only be read during startup or reconfiguration of a task." is incorrect? because the API extension allows reading offset data at any point in the lifecycle, right? On Fri, Sep 8, 2017 at 5:18 AM Florian Hussonnois

Build failed in Jenkins: kafka-trunk-jdk7 #2734

2017-09-08 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Update dependencies for 1.0.0 part 2 -- [...truncated 923.81 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[GitHub] kafka pull request #3791: MINOR: Update dependencies for 1.0.0 release

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3791 ---

Build failed in Jenkins: kafka-trunk-jdk7 #2733

2017-09-08 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-4260; Disallow non-routable address in advertised.listeners [ismael] KAFKA-5656; Support bulk attributes request on KafkaMbean where some --

Build failed in Jenkins: kafka-trunk-jdk8 #1996

2017-09-08 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5832; add Consumed and change StreamBuilder to use it -- [...truncated 4.17 MB...] kafka.api.LegacyAdminClientTest >

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Ted Yu
I think increasePartitions is better name, implying there are already partitions. bq. use cases for non-consecutive partition ids. +1 on not supporting non-consecutive partition ids Cheers On Fri, Sep 8, 2017 at 5:34 AM, Ismael Juma wrote: > Hmm, maybe it should be

[jira] [Resolved] (KAFKA-5656) Support bulk attributes request on KafkaMbean where some attributes do not exist

2017-09-08 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5656. Resolution: Fixed Fix Version/s: 1.0.0 > Support bulk attributes request on KafkaMbean where

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Ismael Juma
Hmm, maybe it should be createPartitions for symmetry with createTopics? Ismael On Fri, Sep 8, 2017 at 12:33 PM, Tom Bentley wrote: > Hi Paolo, > > Thanks for commenting. > > The main reason I suggested `NumPartitionsIncrease` rather than just > `NumPartitions` was in

[GitHub] kafka pull request #3582: KAFKA-5656: Support bulk attributes request on Kaf...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3582 ---

[GitHub] kafka pull request #3815: KAFKA-5846; Used Singleton NoOpConsumerRebalanceLi...

2017-09-08 Thread Kamal15
GitHub user Kamal15 opened a pull request: https://github.com/apache/kafka/pull/3815 KAFKA-5846; Used Singleton NoOpConsumerRebalanceListener in the Kafka… …Consumer#subscribe call. - I haven't removed the internal class 'NoOpConsumerRebalanceListener', as it might

Re: [VOTE] KIP-131 - Add access to OffsetStorageReader from SourceConnector

2017-09-08 Thread Florian Hussonnois
Hi Shapira, We only expose the OffsetStorageReader to connector which relies on KafkaOffsetBackingStore. The store continuesly consumes offsets from kafka so I think we can't have stale data. Le 8 sept. 2017 06:13, "Randall Hauch" a écrit : > The KIP and PR expose the

[GitHub] kafka pull request #3382: KAFKA-4260: Check for nonroutable address in adver...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3382 ---

[GitHub] kafka pull request #2439: KAFKA-2700: Delete topic should remove the corresp...

2017-09-08 Thread omkreddy
Github user omkreddy closed the pull request at: https://github.com/apache/kafka/pull/2439 ---

[jira] [Resolved] (KAFKA-5592) Connection with plain client to SSL-secured broker causes OOM

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-5592. -- Resolution: Duplicate Marking this as duplicate of KAFKA-4493. > Connection with plain client to

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Paolo Patierno
My 2 cents about naming ... PartitionCount or NumPartitions sound better to me providing an "absolute" value (as today the kafka-topics script work) for an idempotent operation while the NumPartitionsIncrease name sounds to me like the "increment" value. Paolo Patierno Senior Software

[jira] [Resolved] (KAFKA-4638) Outdated and misleading link in section "End-to-end Batch Compression"

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-4638. -- Resolution: Duplicate Resolving as duplicate of KAFKA-5686. PR Raised for KAFKA-5686 > Outdated and

[GitHub] kafka pull request #3577: MINOR: Added some tips for running a single test f...

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3577 ---

[GitHub] kafka pull request #3670: MINOR: fixed StickyAssignor javadoc

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3670 ---

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Tom Bentley
Hi Ismael, Thanks for the comments. My bad for not noticing the custom assignment requirement. The current > proposal has the following example (I updated it a little so that 2 > partitions are added): > > increasePartitionCount(4, asList(asList(1, 2), asList(2, 3)) > > Why not simply provide

[jira] [Resolved] (KAFKA-1037) switching to gzip compression no error message for missing snappy jar on classpath

2017-09-08 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1037. -- Resolution: Fixed This has been fixed in newer versions. > switching to gzip compression no error

Re: [VOTE] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-08 Thread Ismael Juma
Thanks for the KIP. +1 (binding) from me. Just a minor suggestion, I would mention the following under "Public Interfaces": Default value of delivery.timeout.ms = 120 seconds Default value of retries will be changed to MAX_INT request.timeout.ms – current meaning, but messages are not expired

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-08 Thread Ismael Juma
Thanks! On Fri, Sep 8, 2017 at 6:09 AM, Sumant Tambe wrote: > Just did :) > > On 7 September 2017 at 17:52, Ismael Juma wrote: > > > Can we please start the vote on this KIP? The KIP must be accepted by > next > > Wednesday in order to make the cut for

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Ismael Juma
My bad for not noticing the custom assignment requirement. The current proposal has the following example (I updated it a little so that 2 partitions are added): increasePartitionCount(4, asList(asList(1, 2), asList(2, 3)) Why not simply provide the assignment? For example, if you want to add 2

[GitHub] kafka pull request #3814: KAFKA-4504: update retention.bytes config descript...

2017-09-08 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/3814 KAFKA-4504: update retention.bytes config description You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka KAFKA-4504 Alternatively

Re: [DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-09-08 Thread Tom Bentley
Hi Jun, The patches that I've got currently wait for the elections to complete before returning the response. Is that the semantic you wanted? Cheers, Tom On 7 September 2017 at 22:14, Jun Rao wrote: > Hi, Tom, > > It seems that it's useful to know whether the leader is

Re: [DISCUSS] KIP-195: AdminClient.increasePartitions

2017-09-08 Thread Tom Bentley
Hi Ted and Ismael, Thanks for the comments. Ted, I've fixed the KIP for your comments. Ismael, see responses inline: On 8 September 2017 at 02:00, Ismael Juma wrote: > Thanks Tom. Thanks for the KIP. A few comments: > > 1. Does the `PartitionCount` class still make sense

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

2017-09-08 Thread Edoardo Comar
I am late to the party and my +1 vote is useless - but I took eventually the time to go through it and it's a great improvement. It'd enable us to carry along with the Principal a couple of additional attributes without the hacks we're doing today :-) cheers

[jira] [Resolved] (KAFKA-5832) Add Consumed class and overloads to StreamBuilder

2017-09-08 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-5832. --- Resolution: Fixed Issue resolved by pull request 3784 [https://github.com/apache/kafka/pull/3784] >