Re: [VOTE] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-09 Thread Ted Yu
+1 for the KIP. For delivery.timeout.ms , since it should be >= linger.ms + request.timeout.ms + retry.backoff.ms , it seems the default value should be max(120 seconds, linger.ms + request.timeout.ms + retry.backoff.ms). Cheers On Fri, Sep 8, 2017 at 2:04 AM, Ismael Juma

Re: [VOTE] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-09 Thread Becket Qin
+1. Thanks for the KIP, Sumant and Joel. On Fri, Sep 8, 2017 at 11:33 AM, Jason Gustafson wrote: > +1. Thanks for the KIP. > > On Fri, Sep 8, 2017 at 8:17 AM, Sumant Tambe wrote: > > > Updated. > > > > On 8 September 2017 at 02:04, Ismael Juma

Re: [DISCUSS] KIP-190: Handle client-ids consistently between clients and brokers

2017-09-09 Thread Mickael Maison
Hi Gwen, thanks for taking a look at the KIP. I understand your concern trying to make the transition as smooth as possible. However there are several issues with the way client-ids with special characters are handled: Client-ids that contain invalid ObjectName characters (colon, equals, etc)

[jira] [Resolved] (KAFKA-5798) Couldnt connect to mysql using mysql.jdbc driver

2017-09-09 Thread Randall Hauch (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5798. -- Resolution: Invalid Closing as invalid, since this involves connectors that are not part of

Re: [VOTE] KIP-131 - Add access to OffsetStorageReader from SourceConnector

2017-09-09 Thread Randall Hauch
Gwen, I've had more time to look into the code. First, the OffsetStorageReader JavaDoc says: "OffsetStorageReader provides access to the offset storage used by sources. This can be used by connectors to determine offsets to start consuming data from. This is most commonly used during

Re: [VOTE] KIP-198: Remove ZK dependency from Streams Reset Tool

2017-09-09 Thread Damian Guy
+1 On Sat, 9 Sep 2017 at 03:46, Sriram Subramanian wrote: > +1 > > On Fri, Sep 8, 2017 at 3:04 PM, Guozhang Wang wrote: > > > +1, thanks. > > > > On Fri, Sep 8, 2017 at 1:54 PM, Bill Bejeck wrote: > > > > > +1 > > > > > > Thanks, > > >

Build failed in Jenkins: kafka-0.11.0-jdk7 #304

2017-09-09 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-5792; Fix Transient failure in -- [...truncated 2.44 MB...] org.apache.kafka.streams.state.internals.ChangeLoggingKeyValueBytesStoreTest >

Build failed in Jenkins: kafka-trunk-jdk7 #2740

2017-09-09 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-5792; Fix Transient failure in -- [...truncated 2.51 MB...] org.apache.kafka.streams.KafkaStreamsTest >

Build failed in Jenkins: kafka-trunk-jdk8 #2000

2017-09-09 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-5792; Fix Transient failure in -- [...truncated 933.04 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[jira] [Resolved] (KAFKA-5792) Transient failure in KafkaAdminClientTest.testHandleTimeout

2017-09-09 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5792. Resolution: Fixed > Transient failure in KafkaAdminClientTest.testHandleTimeout >

[GitHub] kafka pull request #3822: KAFKA-5792: Fix Transient failure in KafkaAdminCli...

2017-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3822 ---