[KAFKA-7382] Guarantee atleast one replica of partition to be alive during topic creation

2018-11-12 Thread Suman B N
Team, Review and merge - https://github.com/apache/kafka/pull/5822. One round of review has been done by Mani Kumar Reddy in PR - https://github.com/apache/kafka/pull/5665. -- *Suman* *OlaCabs*

Heads up: javac warnings are now treated as errors

2018-11-12 Thread Ismael Juma
Hi all, As part of KAFKA-7612, all javac warnings were fixed or suppressed. To prevent them from reappearing, javac warnings are now treated as errors. We still have some scalac warnings (see KAFKA-7614 for details on what's needed to eliminate them) and 3 xlint warnings are not yet enabled

Re: [DISCUSS] KIP-388 Add observer interface to record request and response

2018-11-12 Thread Lincong Li
Thanks Mayuresh, Ismael and Colin for your feedback! I updated the KIP basing on your feedback. The change is basically that two interfaces are introduced to prevent the internal classes from being exposed. These two interfaces contain getters that allow user to extract information from request

[jira] [Resolved] (KAFKA-7612) Fix javac warnings and enable warnings as errors

2018-11-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-7612. Resolution: Fixed Fix Version/s: 2.2.0 > Fix javac warnings and enable warnings as errors >

[jira] [Resolved] (KAFKA-7605) Flaky Test `SaslMultiMechanismConsumerTest.testCoordinatorFailover`

2018-11-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-7605. Resolution: Fixed Fix Version/s: 2.2.0 > Flaky Test

[jira] [Created] (KAFKA-7620) ConfigProvider is broken for connect when TTL is not null

2018-11-12 Thread Ye Ji (JIRA)
Ye Ji created KAFKA-7620: Summary: ConfigProvider is broken for connect when TTL is not null Key: KAFKA-7620 URL: https://issues.apache.org/jira/browse/KAFKA-7620 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-11-12 Thread Becket Qin
Hi Dong, That is a good point. But I think the STALE_BROKER_EPOCH error may still be sent to the broker. For example, think about the following case: 1. Broker sends a ControlledShutdownRequest to the controller 2. Broker had a ZK session timeout 3. Broker created the ephemeral node 4.

Build failed in Jenkins: kafka-trunk-jdk8 #3194

2018-11-12 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Remove unused IteratorTemplate (#5903) -- [...truncated 2.49 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Jenkins build is back to normal : kafka-2.1-jdk8 #53

2018-11-12 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #3193

2018-11-12 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-7518: Fix FutureRecordMetadata.get when TimeUnit is not ms (#5815) -- [...truncated 2.73 MB...]

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2018-11-12 Thread Florian Hussonnois
Hi Matthias, Sorry I was absent for a while. I have started a new PR for this KIP. It is still in progress for now. I'm working on it. https://github.com/apache/kafka/pull/5909 Le ven. 19 oct. 2018 à 20:13, Matthias J. Sax a écrit : > What is the status of this KIP? > > -Matthias > > On

Jenkins build is back to normal : kafka-trunk-jdk11 #91

2018-11-12 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk11 #90

2018-11-12 Thread Apache Jenkins Server
See Changes: [junrao] KAFKA-7557: optimize LogManager.truncateFullyAndStartAt() (#5848) -- [...truncated 2.33 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-12 Thread Stanislav Kozlovski
Thank you, everybody, for the votes and discussion. The KIP has passed with 3 binding votes (Harsha, Jun, Dong) and 1 non-binding vote (Kevin) @jun, I added a note on the KIP stating that this isn't related to the Yammer metrics Best, Stanislav On Thu, Nov 8, 2018 at 10:54 PM Dong Lin wrote:

Build failed in Jenkins: kafka-trunk-jdk8 #3192

2018-11-12 Thread Apache Jenkins Server
See Changes: [junrao] KAFKA-7557: optimize LogManager.truncateFullyAndStartAt() (#5848) -- [...truncated 2.49 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Srinivas Reddy
Thank you all for votes. Here is the summary of all votes. Binding votes: Colin McCabe Harsha Chintalapani Becket Qin Non binding votes: Viktor Somogyi-Vass Daniele Ascione Mickael Maison Vahid Hashemian I am concluding this voting thread and mark this KIP as accepted. Thanks --

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-11-12 Thread Dong Lin
Hey Becket, Patrick, Currently we expect that controller can only receive ControlledShutdownRequest with outdated broker epoch in two cases: 1) the ControlledShutdownRequest was sent by the broker before it has restarted; and 2) there is bug. In case 1), it seems that ControlledShutdownResponse

Re: [VOTE] KIP-354 Time-based log compaction policy

2018-11-12 Thread xiongqi wu
Hi all, Can I have one more vote on this KIP? Any comment is appreciated. https://cwiki.apache.org/confluence/display/KAFKA/KIP-354%3A+Add+a+Maximum+Log+Compaction+Lag Xiongqi (Wesley) Wu On Fri, Nov 9, 2018 at 7:56 PM xiongqi wu wrote: > Thanks Dong. > I have updated the KIP. > > Xiongqi

[jira] [Resolved] (KAFKA-7452) Deleting snapshot files after check-pointing log recovery offsets can slow down replication when truncation happens

2018-11-12 Thread Zhanxiang (Patrick) Huang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanxiang (Patrick) Huang resolved KAFKA-7452. -- Resolution: Duplicate KAFKA-7557 fixed this. > Deleting snapshot

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-11-12 Thread Patrick Huang
Hi Becket, I think you are right. STALE_BROKER_EPOCH only makes sense when the broker detects outdated control requests and wants the controller to know about that. For ControlledShutdownRequest, the controller should just ignore the request with stale broker epoch since the broker does not

[jira] [Resolved] (KAFKA-7557) optimize LogManager.truncateFullyAndStartAt()

2018-11-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-7557. Resolution: Fixed Fix Version/s: 2.2.0 merged to trunk > optimize

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-12 Thread Boyang Chen
Thanks Mayuresh for the feedback! Do you have a quick example for passing in consumer config dynamically? I mainly use Kafka Streams at my daily work so probably missing the idea how to do it in the current consumer setting. For differentiating session timeout and registration timeout, I would

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Vahid Hashemian
+1 (non-binding) Thanks for the KIP. --Vahid On Mon, Nov 12, 2018, 04:06 Mickael Maison wrote: > +1 (non-binding) > Thanks for the KIP! > On Mon, Nov 12, 2018 at 5:16 AM Becket Qin wrote: > > > > Thanks for the KIP. +1 (binding). > > > > On Mon, Nov 12, 2018 at 9:59 AM Harsha Chintalapani >

[jira] [Created] (KAFKA-7619) Trogdor - Allow filtering tasks by state in /coordinator/tasks endpoint

2018-11-12 Thread Stanislav Kozlovski (JIRA)
Stanislav Kozlovski created KAFKA-7619: -- Summary: Trogdor - Allow filtering tasks by state in /coordinator/tasks endpoint Key: KAFKA-7619 URL: https://issues.apache.org/jira/browse/KAFKA-7619

[jira] [Created] (KAFKA-7618) Trogdor - Fix /tasks endpoint parameters

2018-11-12 Thread Stanislav Kozlovski (JIRA)
Stanislav Kozlovski created KAFKA-7618: -- Summary: Trogdor - Fix /tasks endpoint parameters Key: KAFKA-7618 URL: https://issues.apache.org/jira/browse/KAFKA-7618 Project: Kafka Issue

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Mickael Maison
+1 (non-binding) Thanks for the KIP! On Mon, Nov 12, 2018 at 5:16 AM Becket Qin wrote: > > Thanks for the KIP. +1 (binding). > > On Mon, Nov 12, 2018 at 9:59 AM Harsha Chintalapani wrote: > > > +1 (binding) > > > > -Harsha > > On Nov 11, 2018, 3:49 PM -0800, Daniele Ascione , > > wrote: > > > +1

Jenkins build is back to normal : kafka-trunk-jdk11 #89

2018-11-12 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-11-12 Thread Becket Qin
Hi Patrick, I am wondering why the controller should send STALE_BROKER_EPOCH error to the broker if the broker epoch is stale? Would this be a little confusing to the current broker if the request was sent by a broker with previous epoch? Should the controller just ignore those requests in that

[jira] [Created] (KAFKA-7617) Document security primitives

2018-11-12 Thread Viktor Somogyi (JIRA)
Viktor Somogyi created KAFKA-7617: - Summary: Document security primitives Key: KAFKA-7617 URL: https://issues.apache.org/jira/browse/KAFKA-7617 Project: Kafka Issue Type: Task