Build failed in Jenkins: kafka-2.1-jdk8 #174

2019-04-26 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-8254: Pass Changelog as Topic in Suppress Serdes (#6602) (#6641) -- [...truncated 696.02 KB...] records = consumer.poll(100)

Build failed in Jenkins: kafka-trunk-jdk8 #3586

2019-04-26 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-7862 & KIP-345 part-one: Add static membership logic to JoinGroup [wangguoz] MINOR: In-memory stores cleanup (#6595) [wangguoz] KAFKA-8029: In memory session store (#6525)

[jira] [Created] (KAFKA-8300) kafka broker did not recovery from quota limit after quota setting is removed

2019-04-26 Thread Yu Yang (JIRA)
Yu Yang created KAFKA-8300: -- Summary: kafka broker did not recovery from quota limit after quota setting is removed Key: KAFKA-8300 URL: https://issues.apache.org/jira/browse/KAFKA-8300 Project: Kafka

[jira] [Created] (KAFKA-8299) Add type-safe instantiation of generic classes to AbstractConfig

2019-04-26 Thread Chris Egerton (JIRA)
Chris Egerton created KAFKA-8299: Summary: Add type-safe instantiation of generic classes to AbstractConfig Key: KAFKA-8299 URL: https://issues.apache.org/jira/browse/KAFKA-8299 Project: Kafka

Re: [DISCUSS] KIP-460: Admin Leader Election RPC

2019-04-26 Thread Jose Armando Garcia Sancio
Hi all, Jason, Colin and I discuss this KIP offline and decided to make the following changes. 1. Change the ElectLeadersRequest RPC so that only one election type can be specified and it applies to all of the topic partitions enumerated. We think that this makes the API easier to use

Jenkins build is back to normal : kafka-2.2-jdk8 #94

2019-04-26 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

2019-04-26 Thread Chris Egerton
Hi Magesh, Changes look good to me! Excited to see this happen, hope the KIP passes :) Cheers, Chris On Fri, Apr 26, 2019 at 1:44 PM Magesh Nandakumar wrote: > Hi Chris, > > I have updated the KIP to reflect the changes that we discussed for the > prefix. Thanks for all your inputs. > >

[jira] [Created] (KAFKA-8298) ConcurrentModificationException Possible when optimizing for repartition nodes

2019-04-26 Thread Bill Bejeck (JIRA)
Bill Bejeck created KAFKA-8298: -- Summary: ConcurrentModificationException Possible when optimizing for repartition nodes Key: KAFKA-8298 URL: https://issues.apache.org/jira/browse/KAFKA-8298 Project:

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

2019-04-26 Thread Magesh Nandakumar
Hi Chris, I have updated the KIP to reflect the changes that we discussed for the prefix. Thanks for all your inputs. Thanks, Magesh On Thu, Apr 25, 2019 at 2:18 PM Chris Egerton wrote: > Hi Magesh, > > Agreed that we should avoid `dlq.admin`. I also don't have a strong opinion > between

Re: [VOTE] KIP-434: Dead replica fetcher and log cleaner metrics

2019-04-26 Thread Jason Gustafson
Thanks, that works for me. +1 By the way, we don't normally port KIPs to older releases, but I wonder if it's worth making an exception here. From recent experience, it tends to be the older versions that are more prone to fetcher failures. Thoughts? -Jason On Fri, Apr 26, 2019 at 5:18 AM

[jira] [Resolved] (KAFKA-8029) Add in-memory bytes-only session store implementation

2019-04-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8029. -- Resolution: Fixed Fix Version/s: 2.3.0 > Add in-memory bytes-only session store

[jira] [Resolved] (KAFKA-7862) Modify JoinGroup logic to incorporate group.instance.id change

2019-04-26 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-7862. Resolution: Fixed > Modify JoinGroup logic to incorporate group.instance.id change >

[jira] [Created] (KAFKA-8297) Kafka Streams ConsumerRecordFactory yields difficult compiler error about generics

2019-04-26 Thread Michael Drogalis (JIRA)
Michael Drogalis created KAFKA-8297: --- Summary: Kafka Streams ConsumerRecordFactory yields difficult compiler error about generics Key: KAFKA-8297 URL: https://issues.apache.org/jira/browse/KAFKA-8297

[jira] [Created] (KAFKA-8296) Kafka Streams branch method raises type warnings

2019-04-26 Thread Michael Drogalis (JIRA)
Michael Drogalis created KAFKA-8296: --- Summary: Kafka Streams branch method raises type warnings Key: KAFKA-8296 URL: https://issues.apache.org/jira/browse/KAFKA-8296 Project: Kafka Issue

[jira] [Created] (KAFKA-8295) Optimize count() using RocksDB merge operator

2019-04-26 Thread Sophie Blee-Goldman (JIRA)
Sophie Blee-Goldman created KAFKA-8295: -- Summary: Optimize count() using RocksDB merge operator Key: KAFKA-8295 URL: https://issues.apache.org/jira/browse/KAFKA-8295 Project: Kafka

[jira] [Created] (KAFKA-8294) Batch StopReplica requests with partition deletion and add test cases

2019-04-26 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-8294: -- Summary: Batch StopReplica requests with partition deletion and add test cases Key: KAFKA-8294 URL: https://issues.apache.org/jira/browse/KAFKA-8294 Project:

Build failed in Jenkins: kafka-1.0-jdk7 #268

2019-04-26 Thread Apache Jenkins Server
See Changes: [rhauch] MINOR: Backport two system test changes for Connect to give more startup -- [...truncated 1.41 MB...]

[jira] [Resolved] (KAFKA-8254) Suppress incorrectly passes a null topic to the serdes

2019-04-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8254. -- Resolution: Fixed Fix Version/s: (was: 2.1.2) Resolved for trunk / 2.2 now, will

[jira] [Created] (KAFKA-8293) Messages undelivered when small quotas applied

2019-04-26 Thread Kirill Kulikov (JIRA)
Kirill Kulikov created KAFKA-8293: - Summary: Messages undelivered when small quotas applied Key: KAFKA-8293 URL: https://issues.apache.org/jira/browse/KAFKA-8293 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Boyang Chen
Thanks for the explanation Matthias! Will enhance the KIP motivation by your example. From: Matthias J. Sax Sent: Friday, April 26, 2019 3:42 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams Thanks for the KIP! I

Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver

2019-04-26 Thread Jukka Karvanen
Yes, my understanding was also that this KIP cover all the requirement of KIP-451. Relating to KIP-448. What kind of alignment did you think about? Some thoughts after reading also the comments in KAFKA-6460: To my understand these KIP-448 mock classes need to be fed somehow into

KAFKA-8238

2019-04-26 Thread Sagar
Hi all, I would like to start contributing to the Kafka project. I looked at the newbie tickets and thought I could start with this:(?) https://issues.apache.org/jira/browse/KAFKA-8238 Or if there's anything else that I can look at, please let me know. Sagar.

Re: [DISCUSS] KIP-455: Create an Administrative API for Replica Reassignment

2019-04-26 Thread Viktor Somogyi-Vass
Hi Colin, How would the changed kafka-reassign-partitions.sh command work? Would it automatically figure out the controller node if you pass some bootstrap nodes with --bootstrap-server or are we deferring this implementation to the users? Thanks, Viktor On Sat, Apr 20, 2019 at 1:51 AM Colin

Re: [VOTE] KIP-434: Dead replica fetcher and log cleaner metrics

2019-04-26 Thread Viktor Somogyi-Vass
Let me have a second thought, I'll just add the clientId instead to follow the convention, so it'll change DeadFetcherThreadCount but with the clientId tag. On Fri, Apr 26, 2019 at 11:29 AM Viktor Somogyi-Vass < viktorsomo...@gmail.com> wrote: > Hi Jason, > > Yea I think it could make sense. In

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

2019-04-26 Thread Matthias J. Sax
What is the status of this KIP? -Matthias On 3/18/19 5:11 PM, Guozhang Wang wrote: > Hello Wladimir, > > Thanks for the replies. > > What do you mean by "the community has opted for the second more complex > solution"? Could you elaborate a bit more? > > Guozhang > > > On Sun, Mar 17, 2019

Re: [VOTE] KIP-434: Dead replica fetcher and log cleaner metrics

2019-04-26 Thread Viktor Somogyi-Vass
Hi Jason, Yea I think it could make sense. In this case I would rename the DeadFetcherThreadCount to DeadReplicaFetcherThreadCount and introduce the metric you're referring to as DeadLogDirFetcherThreadCount. I'll update the KIP to reflect this. Viktor On Thu, Apr 25, 2019 at 8:07 PM Jason

Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver

2019-04-26 Thread Matthias J. Sax
Btw: there is also KIP-448. I was wondering if it might be required or helpful to align the design of both with each other. Thoughts? On 4/25/19 11:22 PM, Matthias J. Sax wrote: > Thanks for the KIP! > > I was just comparing this KIP with KIP-451 (even if I did not yet make a > sorrow read

Re: [DISCUSS] KIP-448: Add State Stores Unit Test Support to Kafka Streams Test Utils

2019-04-26 Thread Matthias J. Sax
What is the status of this KIP? Btw: there is also KIP-456. I was wondering if it might be required or helpful to align the design of both with each other. Thoughts? -Matthias On 4/11/19 12:17 AM, Matthias J. Sax wrote: > Thanks for the KIP. Only one initial comment (Sophie mentioned this >

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-04-26 Thread Matthias J. Sax
There was a discussion about metric on KIP-439. Would be good if we could incorporate those thought into this discussion. -Matthias On 3/29/19 10:56 AM, Guozhang Wang wrote: > Hello folks, > > I'd like to propose the following KIP to improve the Kafka Streams metrics > mechanism to users. This

Re: [DISCUSS] KIP-439: Deprecate Interface WindowStoreIterator

2019-04-26 Thread Matthias J. Sax
Thanks for the input Guozhang. I was not aware of those dependencies. It might be good to align this KIP with the metrics cleanup. Not sure atm, if we should use different metric names for different overloads, even if those have the same method name? If we rename all method to `range()` and use

Re: [DISCUSSION] KIP-418: A method-chaining way to branch KStream

2019-04-26 Thread Matthias J. Sax
Thanks for updating the KIP and your answers. > this is to make the name similar to String#split >> that also returns an array, right? The intend was to avoid name duplication. The return type should _not_ be an array. The current proposal is stream.branch() .branch(Predicate)

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

2019-04-26 Thread Matthias J. Sax
Thanks for the KIP. Overall, I agree with the sentiment of the KIP. The current semantics of `KafkaStreams#close(timeout)` are not well defined. Also the general client inconsistencies are annoying. > This KIP make any change on public interfaces; however, it makes a subtle > change to the

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Matthias J. Sax
Thanks for the KIP! I agree that the change makes sense, and not only for the static group membership case. For example, if a user `closes()` a `KafkaStreams` client and creates a new one (for example to recover failed threads), while the JVM is still running, it is more intuitive that the

Re: [DISCUSS] KIP-401 TransformerSupplier/ProcessorSupplier enhancements

2019-04-26 Thread Matthias J. Sax
Hi, sorry for the long pause. Just trying to catch up here. I think it save to allow `addStateStore()` to be idempotent for the same `StoreBuilder` object. In fact, the `name` is "hard coded" and thus it's not really possible to use the same `StoreBuilder` object to create different stores. I

KAFKA-8037 - KTable/GlobalKTable may restore bad data from source topic

2019-04-26 Thread Patrik Kleindl
Hello During an incident analysis it was discovered that the restoration process of state stores which are based directly on a source topic (=not a changelog topic) is not protected against undeserializable recods in the same way normal processing is with the LogAndContinueExceptionHandler.

[jira] [Resolved] (KAFKA-8200) TopologyTestDriver should offer an iterable signature of readOutput

2019-04-26 Thread Patrik Kleindl (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrik Kleindl resolved KAFKA-8200. --- Resolution: Won't Do Discarded in favor of 

Re: [DISCUSS] KIP-451: Make TopologyTestDriver output iterable

2019-04-26 Thread Patrik Kleindl
Hi It's fine by me, I'll consider doing the PR a good exercise ;-) I'll discard it for the moment, if there should be any hold-up for KIP-456 to make it into the 2.3 release then we could still revive this one because it is mostly done already. best regards and thanks to Jukka for his great work!

Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver

2019-04-26 Thread Matthias J. Sax
Thanks for the KIP! I was just comparing this KIP with KIP-451 (even if I did not yet make a sorrow read over this KIP), and I agree that there is a big overlap. It seems that KIP-456 might subsume KIP-451. Let's wait on Patrick's input to see how to proceed. -Matthias On 4/25/19 12:03 AM,

[DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Boyang Chen
Hey friends, I would like to start discussion for a very small KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-462%3A+Use+local+thread+id+for+KStreams it is trying to avoid sharing thread-id increment between multiple stream instances configured in one JVM. This is an important fix

[VOTE] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Boyang Chen
Hey friends, I would like to start the vote for KIP-462: https://cwiki.apache.org/confluence/display/KAFKA/KIP-462%3A+Use+local+thread+id+for+KStreams if you have questions, feel free to raise in the discussion thread, not this one. Thank you! Boyang

Re: [DISCUSS] KIP-451: Make TopologyTestDriver output iterable

2019-04-26 Thread Matthias J. Sax
Thanks for the discussion! After skipping over KIP-456, I was also wondering what the overlap of both KIPs are, and if KIP-456 might actually subsume KIP-451. If we all agree on this, I would recommend to discard KIP-451 in favor of KIP-456. I'll also follow up on KIP-456 DISCUSS thread to get