Build failed in Jenkins: kafka-2.2-jdk8 #102

2019-05-03 Thread Apache Jenkins Server
See Changes: [bill] KAFKA-8323: Close RocksDBStore's BloomFilter (#6672) -- [...truncated 2.70 MB...] kafka.controller.PartitionLeaderElectionAlgorithmsTest >

Build failed in Jenkins: kafka-trunk-jdk8 #3600

2019-05-03 Thread Apache Jenkins Server
See Changes: [bbejeck] KAFKA-8323: Close RocksDBStore's BloomFilter (#6672) -- [...truncated 4.80 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Build failed in Jenkins: kafka-trunk-jdk11 #484

2019-05-03 Thread Apache Jenkins Server
See Changes: [bbejeck] KAFKA-8323: Close RocksDBStore's BloomFilter (#6672) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building

Re: [DISCUSS] KIP-455: Create an Administrative API for Replica Reassignment

2019-05-03 Thread Colin McCabe
On Tue, Apr 30, 2019, at 23:33, George Li wrote: > Hi Colin, > > Thanks for KIP-455!  yes. KIP-236, etc. will depend on it.  It is the > good direction to go for the RP  > > Regarding storing the new reassignments & original replicas at the > topic/partition level.  I have some concerns when

Re: [VOTE] KIP-454: Expansion of the ConnectClusterState interface

2019-05-03 Thread Randall Hauch
Nice job, Chris! +1 (binding) On Thu, May 2, 2019 at 8:16 PM Magesh Nandakumar wrote: > Thanks a lot for the work on this KIP Chris. > > +1(non-binding) > > On Thu, May 2, 2019, 4:56 PM Chris Egerton wrote: > > > Hi all, > > > > I'd like to start a vote for KIP-454: > > > > >

[jira] [Resolved] (KAFKA-8323) Memory leak of BloomFilter Rocks object

2019-05-03 Thread Bill Bejeck (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-8323. Resolution: Fixed cherry-picked to 2.2 as well > Memory leak of BloomFilter Rocks object >

Re: [VOTE] KIP-411: Make default Kafka Connect worker task client IDs distinct

2019-05-03 Thread Arjun Satish
Maybe we can say something like: This change can have an indirect impact on resource usage by a Connector. For example, systems that were enforcing quotas using a "consumer-[id]" client id will now have to update their configs to enforce quota on "connector-consumer-[id]". For systems that were

[jira] [Resolved] (KAFKA-7946) Flaky Test DeleteConsumerGroupsTest#testDeleteNonEmptyGroup

2019-05-03 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vahid Hashemian resolved KAFKA-7946. Resolution: Fixed Fix Version/s: 2.2.1 > Flaky Test

[jira] [Created] (KAFKA-8324) User constructed RocksObjects leak memory

2019-05-03 Thread Sophie Blee-Goldman (JIRA)
Sophie Blee-Goldman created KAFKA-8324: -- Summary: User constructed RocksObjects leak memory Key: KAFKA-8324 URL: https://issues.apache.org/jira/browse/KAFKA-8324 Project: Kafka Issue

[jira] [Created] (KAFKA-8323) Memory leak of BloomFilter Rocks object

2019-05-03 Thread Sophie Blee-Goldman (JIRA)
Sophie Blee-Goldman created KAFKA-8323: -- Summary: Memory leak of BloomFilter Rocks object Key: KAFKA-8323 URL: https://issues.apache.org/jira/browse/KAFKA-8323 Project: Kafka Issue

[jira] [Created] (KAFKA-8322) Flaky test: SslTransportLayerTest.testListenerConfigOverride

2019-05-03 Thread Dhruvil Shah (JIRA)
Dhruvil Shah created KAFKA-8322: --- Summary: Flaky test: SslTransportLayerTest.testListenerConfigOverride Key: KAFKA-8322 URL: https://issues.apache.org/jira/browse/KAFKA-8322 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk8 #3599

2019-05-03 Thread Apache Jenkins Server
See Changes: [github] MINOR: Upgrade dependencies for Kafka 2.3 (#6665) -- [...truncated 4.80 MB...] org.apache.kafka.streams.internals.WindowStoreFacadeTest >

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread Vahid Hashemian
Hi Sophie, Thanks for the heads-up. Once the fix is confirmed, could you please create a ticket for it and assign it to 2.2.1 release? Thanks, --Vahid On Fri, May 3, 2019 at 3:24 PM Sophie Blee-Goldman wrote: > Hey Vahid, > > We also have another minor bug fix we just uncovered and are hoping

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread Sophie Blee-Goldman
Hey Vahid, We also have another minor bug fix we just uncovered and are hoping to get in today although I don't think there's a ticket for it atm...just waiting for the build to pass. Thanks for volunteering! Cheers, Sophie On Fri, May 3, 2019 at 3:16 PM Vahid Hashemian wrote: > Hi John, > >

[jira] [Created] (KAFKA-8321) Flaky Test kafka.server.DynamicConfigTest.shouldFailWhenChangingClientIdUnknownConfig

2019-05-03 Thread Bill Bejeck (JIRA)
Bill Bejeck created KAFKA-8321: -- Summary: Flaky Test kafka.server.DynamicConfigTest.shouldFailWhenChangingClientIdUnknownConfig Key: KAFKA-8321 URL: https://issues.apache.org/jira/browse/KAFKA-8321

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread Vahid Hashemian
Hi John, Thanks for confirming. I'll wait for final bug fix PR for this issue to get merged so we can safely resolve the ticket. That makes it easier with the release script. Hopefully, the current build passes. --Vahid On Fri, May 3, 2019 at 3:07 PM John Roesler wrote: > Hi Vahid, > > The

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread John Roesler
Hi Vahid, The fix is merged to 2.2. The ticket isn't resolved yet, because the tests failed on the 2.1 merge, but I think the 2.2.1 release is unblocked now. Thanks, -John On Fri, May 3, 2019 at 10:41 AM Vahid Hashemian wrote: > Thanks for the filter fix and the heads up John. > I'll wait for

[jira] [Created] (KAFKA-8320) Connect Error handling is using the RetriableException from common package

2019-05-03 Thread Magesh kumar Nandakumar (JIRA)
Magesh kumar Nandakumar created KAFKA-8320: -- Summary: Connect Error handling is using the RetriableException from common package Key: KAFKA-8320 URL: https://issues.apache.org/jira/browse/KAFKA-8320

Re: [DISCUSS] KIP-465: Add Consolidated Connector Endpoint to Connect REST API

2019-05-03 Thread Alex Liu
Good question, `info` is probably the best name for it. The updated output on the wiki looks reasonable to me. Alex On Fri, May 3, 2019 at 2:24 PM dan wrote: > thanks. i think this make sense. > > i'm thinking we should just use repeated queryparams for this, so > `?expand=status=config` > >

Re: [DISCUSS] KIP-465: Add Consolidated Connector Endpoint to Connect REST API

2019-05-03 Thread dan
thanks. i think this make sense. i'm thinking we should just use repeated queryparams for this, so `?expand=status=config` another thing is what do you think we should use for the `/` endpoint? was thinking `?expand=info` output could look like w:kafka norwood$ curl -s '

Re: [VOTE] KIP-411: Make default Kafka Connect worker task client IDs distinct

2019-05-03 Thread Paul Davidson
Thanks Arjun. I updated the KIP to mention the impact on quotas. Please let me know if you think I need more detail. The paragraph I added was: Since the default client.id values are changing, this will also affect any > user that has quotas defined against the current defaults. The current >

[jira] [Reopened] (KAFKA-8240) Source.equals() can fail with NPE

2019-05-03 Thread Bill Bejeck (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reopened KAFKA-8240: This needs to get cherry-picked back to 2.2 and 2.1 so reopening.  I'll resolve once that happens. >

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

2019-05-03 Thread Randall Hauch
I personally like those extra methods, rather than relying upon the generic properties. But I'm fine if others think they should be removed. I'm also fine with not deprecating the Connect version of the builder. On Fri, May 3, 2019 at 11:27 AM Almog Gavra wrote: > Ack. KIP updated :) Perhaps

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

2019-05-03 Thread Almog Gavra
Ack. KIP updated :) Perhaps instead of deprecating the Connect builder, then, we can indeed just subclass it and move some of the less common build methods (e.g. uncleanLeaderElection) there. On Fri, May 3, 2019 at 11:20 AM Randall Hauch wrote: > Thanks for updating, Almog. I have a few

Build failed in Jenkins: kafka-trunk-jdk11 #483

2019-05-03 Thread Apache Jenkins Server
See Changes: [github] MINOR: Upgrade dependencies for Kafka 2.3 (#6665) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

2019-05-03 Thread Randall Hauch
Thanks for updating, Almog. I have a few suggestions specific to the builder: 1. The AK pattern for builder classes that are nested is to name the class "Builder" and to make it publicly visible. We should follow that pattern here, too. 2. The builder's private constructor makes it impossible to

[jira] [Resolved] (KAFKA-8308) Update jetty for security vulnerability CVE-2019-10241

2019-05-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-8308. Resolution: Fixed Assignee: Ismael Juma (was: Lee Dongjin) Fix Version/s: 2.3.0

Build failed in Jenkins: kafka-trunk-jdk8 #3598

2019-05-03 Thread Apache Jenkins Server
See Changes: [bbejeck] KAFKA-8240: Fix NPE in Source.equals() (#6589) -- [...truncated 2.40 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-03 Thread Mickael Maison
+1 (non binding) Thanks for the KIP On Thu, May 2, 2019 at 11:02 PM Colin McCabe wrote: > > +1 (binding) > > thanks, Jose. > > best, > Colin > > On Wed, May 1, 2019, at 14:44, Jose Armando Garcia Sancio wrote: > > Hi all, > > > > I would like to start the voting for KIP-460: > >

[jira] [Resolved] (KAFKA-8240) Source.equals() can fail with NPE

2019-05-03 Thread Bill Bejeck (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-8240. Resolution: Fixed > Source.equals() can fail with NPE > - > >

Re: [DISCUSS] KIP-419 Safely notify Kafka Connect SourceTask is stopped

2019-05-03 Thread Andrew Schofield
Hi Vahid, Thanks for taking a look at this KIP. - The KIP is proposing a new interface because the existing "stop()" interface isn't called at the end of the SourceTask's existence. It's a signal to the task to stop, rather than a signal that it has actually stopped. Essentially, if the task has

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread Vahid Hashemian
Thanks for the filter fix and the heads up John. I'll wait for that to go through then. --Vahid On Fri, May 3, 2019 at 8:33 AM John Roesler wrote: > Thanks for volunteering, Vahid! > > I noticed that the "unresolved issues" filter on the plan page was still > set to 2.1.1 (I fixed it). > >

Re: [DISCUSS] 2.2.1 Bug Fix Release

2019-05-03 Thread John Roesler
Thanks for volunteering, Vahid! I noticed that the "unresolved issues" filter on the plan page was still set to 2.1.1 (I fixed it). There's one blocker left: https://issues.apache.org/jira/browse/KAFKA-8289, but it's merged to trunk and we're cherry-picking to 2.2 today. Thanks again! -John On

[jira] [Created] (KAFKA-8319) Flaky Test KafkaStreamsTest.statefulTopologyShouldCreateStateDirectory

2019-05-03 Thread Bill Bejeck (JIRA)
Bill Bejeck created KAFKA-8319: -- Summary: Flaky Test KafkaStreamsTest.statefulTopologyShouldCreateStateDirectory Key: KAFKA-8319 URL: https://issues.apache.org/jira/browse/KAFKA-8319 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk11 #482

2019-05-03 Thread Apache Jenkins Server
See Changes: [bbejeck] KAFKA-8240: Fix NPE in Source.equals() (#6589) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

Re: [DISCUSS] KIP-398: Support reading trust store from classpath

2019-05-03 Thread Noa Resare
Thank you for your input, Jun, Colina and Rajini! It seems not that quick responding either :) I would like to maintain that the SSL trust store is conceptually different from the other pieces of configuration that is mentioned such as key stores and GSSAPI keytabs. The trust store is not

[jira] [Created] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

2019-05-03 Thread John Roesler (JIRA)
John Roesler created KAFKA-8318: --- Summary: Session Window Aggregations generate an extra tombstone Key: KAFKA-8318 URL: https://issues.apache.org/jira/browse/KAFKA-8318 Project: Kafka Issue