Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Manikumar
+1 (binding). Thanks for the KIP. Thanks, Manikumar On Tue, Mar 31, 2020 at 11:24 AM Maulin Vasavada wrote: > Hi all, > > So far we got 3 Binding votes. I am planning to keep the voting phase open > until Tuesday 10 PM Pacific Time which will be more than 72 hours from the > first binding vote

[jira] [Created] (KAFKA-9789) if one machine has four broker, i want three is cluster ,how do ?

2020-03-30 Thread startjava (Jira)
startjava created KAFKA-9789: Summary: if one machine has four broker, i want three is cluster ,how do ? Key: KAFKA-9789 URL: https://issues.apache.org/jira/browse/KAFKA-9789 Project: Kafka Issu

Build failed in Jenkins: kafka-trunk-jdk8 #4386

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9777; Remove txn purgatory to fix race condition on txn completion -- [...truncated 2.95 MB...] org.apache.kafka.streams.TestTopicsTest > te

Build failed in Jenkins: kafka-2.4-jdk8 #181

2020-03-30 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9706: Handle null in keys or values when Flatten transformation is -- [...truncated 5.58 MB...] org.apache.kafka.streams.TestTopicsTest > t

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Maulin Vasavada
Hi all, So far we got 3 Binding votes. I am planning to keep the voting phase open until Tuesday 10 PM Pacific Time which will be more than 72 hours from the first binding vote on Thursday 12:36 PM Pacific Time. Thanks Maulin On Mon, Mar 30, 2020 at 10:32 PM Maulin Vasavada wrote: > Hi all, >

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Maulin Vasavada
Hi all, I updated the Javadoc in the KIP details and the actual SslEngineFactory interface for shouldBeRebuilt(). For the first comment, probably I'll try to address it tomorrow. Thanks Maulin On Mon, Mar 30, 2020 at 7:44 PM Maulin Vasavada wrote: > Thanks Jun Rao for your vote and comments. >

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Harsha Chintalapani
Thanks for putting the KIP together. This is going to help quite a bit in customizing SSL. +1 (binding). Thanks, Harsha On Mon, Mar 30, 2020 at 7:44 PM Maulin Vasavada wrote: > Thanks Jun Rao for your vote and comments. > > For 1) Earlier it was the security.ssl package but after a review I ch

Build failed in Jenkins: kafka-trunk-jdk8 #4385

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9706: Handle null in keys or values when Flatten transformation is [github] KAFKA-9719: Streams with EOS-beta should fail fast for older brokers ---

Build failed in Jenkins: kafka-2.3-jdk8 #194

2020-03-30 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9706: Handle null in keys or values when Flatten transformation is -- [...truncated 2.98 MB...] kafka.log.LogValidatorTest > testRecompres

Build failed in Jenkins: kafka-trunk-jdk11 #1306

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9706: Handle null in keys or values when Flatten transformation is [github] KAFKA-9719: Streams with EOS-beta should fail fast for older brokers [github] KAFKA-9777; Remove txn pur

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Maulin Vasavada
Thanks Jun Rao for your vote and comments. For 1) Earlier it was the security.ssl package but after a review I changed it to .auth since there are some public interfaces in that package. I am open to move it under .ssl package. For 2) Sure. Will document in Javadocs for the method. Thanks Maulin

Jenkins build is back to normal : kafka-2.5-jdk8 #83

2020-03-30 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-8937) Flaky Test SaslPlainSslEndToEndAuthorizationTest#testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl

2020-03-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8937. -- Resolution: Fixed > Flaky Test > SaslPlainSslEndToEndAuthorizationTest#testNoDescribeProduceOr

Build failed in Jenkins: kafka-trunk-jdk11 #1305

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9685: PT2, avoid unnecessary set creation in ACL matching (#8382) [github] MINOR: Update docs for KIP-530 and KIP-562 (#8388) -- [...truncat

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Jun Rao
Hi, Maulin, Thanks for the KIP. +1 from me. Just a couple of minor comments below. 1. Should the package name of the new interface SslEngineFactory be org.apache.kafka.common.security.ssl instead of org.apache.kafka.common.security.auth? 2. Could you document when shouldBeRebuilt() will be called

Jenkins build is back to normal : kafka-trunk-jdk8 #4384

2020-03-30 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-30 Thread Maulin Vasavada
^^^ bump ^^^ The vote is open for 2-3 days and gotten 1 Binding vote so far, can you please vote so that we can try to move forward with changes? On Thu, Mar 26, 2020 at 4:11 PM Zhou, Thomas wrote: > +1 (non-binding) > > Regards, > Thomas > > On 3/26/20, 12:36 PM, "Rajini Sivaram" wrote: > >

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-30 Thread Colin McCabe
Yeah, I will renew my +1 as well in light of the new discussion. Thanks. Colin On Fri, Mar 27, 2020, at 11:22, Kamal Chandraprakash wrote: > +1 (non-binding). Thanks for the KIP! > > On Fri, Mar 27, 2020 at 9:16 PM Gwen Shapira wrote: > > > Vote is still good. We can always add things later i

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-30 Thread Colin McCabe
Just as a note about whether we should support "-" as a synonym for STDIN... I agree it's kind of inconsistent. It may not be that big of a deal to drop support for STDIN. A lot of UNIX shells make it easy to create a temporary file in scripts-- for example, you could use a "here document" (

Re: [DISCUSS] KIP-584: Versioning scheme for features

2020-03-30 Thread Colin McCabe
On Thu, Mar 26, 2020, at 19:24, Kowshik Prakasam wrote: > Hi Colin, > > Thanks for the feedback! I've changed the KIP to address your > suggestions. > Please find below my explanation. Here is a link to KIP 584: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-584%3A+Versioning+scheme+for+

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2020-03-30 Thread Colin McCabe
Thanks, Boyang. That seems reasonable. best, Colin On Mon, Mar 30, 2020, at 13:32, Boyang Chen wrote: > Thanks Guozhang for the summary. If everyone agrees to the strategy here, > which include: > > 1. No affection to 2.5 release, maintaining the same crashing logic for new > Producer API talki

Build failed in Jenkins: kafka-2.1-jdk8 #262

2020-03-30 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9706: Handle null in keys or values when Flatten transformation is -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

[jira] [Created] (KAFKA-9788) Sensor name collision for group and transaction coordinator load metrics

2020-03-30 Thread Bob Barrett (Jira)
Bob Barrett created KAFKA-9788: -- Summary: Sensor name collision for group and transaction coordinator load metrics Key: KAFKA-9788 URL: https://issues.apache.org/jira/browse/KAFKA-9788 Project: Kafka

[jira] [Resolved] (KAFKA-9706) Flatten transformation fails when encountering tombstone event

2020-03-30 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9706. --- Resolution: Fixed > Flatten transformation fails when encountering tombstone

Jenkins build is back to normal : kafka-trunk-jdk11 #1304

2020-03-30 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #4383

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] MINOR: Update dependencies.gradle, Dockerfile, version.py, and bash.sh -- [...truncated 5.96 MB...] org.apache.kafka.streams.TopologyTestDriverTest

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2020-03-30 Thread Boyang Chen
Thanks Guozhang for the summary. If everyone agrees to the strategy here, which include: 1. No affection to 2.5 release, maintaining the same crashing logic for new Producer API talking to old clients 2. Add an internal flag to silently downgrade protocol for Kafka Streams case only I will go ahe

[jira] [Resolved] (KAFKA-9759) Add documentation change for KIP-562

2020-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9759. Fix Version/s: 2.5.0 Resolution: Fixed > Add documentation change for KIP-562 >

[jira] [Created] (KAFKA-9787) The single node broker is not coming up after unclean shutdown

2020-03-30 Thread etaven (Jira)
etaven created KAFKA-9787: - Summary: The single node broker is not coming up after unclean shutdown Key: KAFKA-9787 URL: https://issues.apache.org/jira/browse/KAFKA-9787 Project: Kafka Issue Type:

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2020-03-30 Thread Guozhang Wang
Hello Colin, Thanks for the context you provided with CreateAclsRequest to make the point for compatibility policy, and I think they make sense -- given KIP-447 is primarily motivated for Streams clients, we should still consider it's potential compatibility pitfall for non-Streams clients. About

Re: [kafka-clients] [VOTE] 2.5.0 RC2

2020-03-30 Thread Vahid Hashemian
Hi David, Thanks for running this release. Sorry for the delay in bringing this up. I just wanted to draw attention to https://issues.apache.org/jira/browse/KAFKA-9731 that blocked us from upgrading to 2.4. Based on the earlier discussion, the fix may not require a lot of work. Regards, --Vahid

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2020-03-30 Thread Boyang Chen
Thanks for the thoughts everyone. Colin has made a good point about the supporting for non-stream applications, where silent downgrade is harmful and could make false promises to users. Matthias also made a good point about utilizing the internal flag to safe-guard in case non-stream users would al

Re: Request Permission to Create KIP

2020-03-30 Thread Bill Bejeck
Hi Xiaodong, You're all set now. Thanks for your interest in Apache Kafka. Regards, Bill On Mon, Mar 30, 2020 at 12:40 PM Xiaodong Du wrote: > Hi, > > I’d like to submit a KIP and am requesting access to the wiki page. My wiki > ID is xiaodongdu2008. Please let me know if anything else is nee

Re: [VOTE] 2.5.0 RC2

2020-03-30 Thread Christopher Egerton
Thanks David! FYI for everyone else, the PR has now been merged and backported and shouldn't block the 2.5 release any further. On Mon, Mar 30, 2020 at 7:15 AM David Arthur wrote: > Thanks for report and the fix, Chris. I agree this should be considered a > blocker. It will be included in the ne

Request Permission to Create KIP

2020-03-30 Thread Xiaodong Du
Hi, I’d like to submit a KIP and am requesting access to the wiki page. My wiki ID is xiaodongdu2008. Please let me know if anything else is needed from my side - thanks! Xiaodong

Re: [DISCUSS] KIP-584: Versioning scheme for features

2020-03-30 Thread Kowshik Prakasam
Hi Colin, Once again, thanks a lot for the feedback! Regarding the first point about using a single version field, you are correct. Recently I understood the idea and realized that both the '__data_version__' and '__schema_version__' can be folded into a single field. This can be bumped anytime wh

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-30 Thread feyman2009
Hi, Boyang Thanks a lot, that make sense, we should not expose member.id in the MemberToRemove anymore, I have fixed it in the KIP. Feyman -- 发件人:Boyang Chen 发送时间:2020年3月29日(星期日) 01:45 收件人:dev ; feyman2009 主 题:Re: 回复:回复:回复:[Vo

Re: [VOTE] 2.5.0 RC2

2020-03-30 Thread David Arthur
Thanks for report and the fix, Chris. I agree this should be considered a blocker. It will be included in the next RC -David On Thu, Mar 26, 2020 at 6:01 PM Christopher Egerton wrote: > Hi all, > > I'd like to request that https://issues.apache.org/jira/browse/KAFKA-9771 > be > treated as a rel

[jira] [Resolved] (KAFKA-9713) Remove BufferExhausedException

2020-03-30 Thread Brian Byrne (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Byrne resolved KAFKA-9713. Resolution: Duplicate > Remove BufferExhausedException > -- > >

Re: [DISCUSS] KIP-579: new exception on min.insync.replicas > replication.factor

2020-03-30 Thread Paolo Moriello
Hi MAnna, Thanks for your feedback. I think you are right, INCONSISTENT_REPLICATION_FACTOR sounds more specific and closer to the point of this kip. Will update the KIP and the PR accordingly. Thanks, Paolo On Mon, 30 Mar 2020 at 13:06, M. Manna wrote: > Hey Paolo, > > Overall LGTM. I only hav

Re: [DISCUSS] KIP-579: new exception on min.insync.replicas > replication.factor

2020-03-30 Thread M. Manna
Hey Paolo, Overall LGTM. I only have one suggestion. You are planning to call it as "INCONSISTENT_REPLICA_CONFIGURATION". How about if we call it "INCONSISTENT_REPLICATION_FACTOR"? Replica configuration might also mean that one of the configuration is not consistent. But with "INCONSISTENT_REPLI

Re: [DISCUSS] KIP-579: new exception on min.insync.replicas > replication.factor

2020-03-30 Thread Paolo Moriello
Hi, Any other feedback on this before we start the vote? Paolo On Fri, 13 Mar 2020 at 17:28, Paolo Moriello wrote: > Hi Mickael, > > Thanks for your interest in this. The main motivation to NOT make topic > creation fail when this mismatch happens is because at the moment it is > possible to p

[jira] [Reopened] (KAFKA-9770) Caching State Store does not Close Underlying State Store When Exception is Thrown During Flushing

2020-03-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-9770: -- > Caching State Store does not Close Underlying State Store When Exception is > Thrown During Flus

[jira] [Created] (KAFKA-9786) fix flaky MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered

2020-03-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-9786: - Summary: fix flaky MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered Key: KAFKA-9786 URL: https://issues.apache.org/jira/browse/KAFKA-9786 Project: Kaf

[jira] [Resolved] (KAFKA-5889) MetricsTest.testMetricsLeak is flaky

2020-03-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-5889. --- Resolution: Won't Fix MetricsTest.testMetricsLeak was removed by https://github.com/apache/k

Build failed in Jenkins: kafka-trunk-jdk8 #4382

2020-03-30 Thread Apache Jenkins Server
See Changes: [github] MINOR: Exclude '**/*Suite.class' from test, unitTest and integrationTest -- [...truncated 5.97 MB...] org.apache.kafka.streams.MockTimeTest > shoul

[jira] [Created] (KAFKA-9785) use kafka-topics.sh can't --alter replication-factor???

2020-03-30 Thread startjava (Jira)
startjava created KAFKA-9785: Summary: use kafka-topics.sh can't --alter replication-factor??? Key: KAFKA-9785 URL: https://issues.apache.org/jira/browse/KAFKA-9785 Project: Kafka Issue Type: Tes