Re: [DISCUSS] KIP-651 - Support PEM format for SSL certificates and private key

2020-08-05 Thread Manikumar
Thanks for the KIP. LGTM. On Wed, Aug 5, 2020 at 3:43 AM Ron Dagostino wrote: > Yes, Rajinit, it looks good -- an excellently-written KIP. Thanks! > > Ron > > On Mon, Aug 3, 2020 at 9:17 AM Andrew Otto wrote: > > > Yes please! I had to build custom tooling to automate generation and > >

[GitHub] [kafka-site] showuon commented on pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-05 Thread GitBox
showuon commented on pull request #284: URL: https://github.com/apache/kafka-site/pull/284#issuecomment-669677637 @scott-confluent @guozhangwang , could you help review this PR? Thanks. This is an automated message from the

[GitHub] [kafka-site] showuon opened a new pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-05 Thread GitBox
showuon opened a new pull request #284: URL: https://github.com/apache/kafka-site/pull/284 Change the arrow direction based on the view state is expanded or not. We can identify it's in expanded mode or not by checking the return value of toggle method. Reference:

Re: [DISCUSS] KIP-631: The Quorum-based Kafka Controller

2020-08-05 Thread Unmesh Joshi
Hi, I have built a small prototype of how the controller backed by consensus implementation will look like. https://github.com/unmeshjoshi/distrib-broker/blob/master/src/main/scala/com/dist/simplekafka/kip500/Kip631Controller.scala This is a miniature Kafka like implementation I use to teach

Jenkins build is back to normal : kafka-2.6-jdk8 #106

2020-08-05 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #4765

2020-08-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Code cleanup in StreamsResetter (#9126) [github] MINOR: Streams integration tests should not call exit (#9067) -- [...truncated 6.36 MB...]

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-05 Thread Jason Gustafson
Hi Ryan, Thanks for the proposal. Just a few quick questions: 1. I wonder if we need to bother with `enable.dynamic.config`, especially if the default is going to be true anyway. I think users who don't want to use this capability can just not set dynamic configs. The only case I can see an

[jira] [Created] (KAFKA-10366) TimeWindowedDeserializer doesn't allow users to set a custom window size

2020-08-05 Thread Leah Thomas (Jira)
Leah Thomas created KAFKA-10366: --- Summary: TimeWindowedDeserializer doesn't allow users to set a custom window size Key: KAFKA-10366 URL: https://issues.apache.org/jira/browse/KAFKA-10366 Project:

Jenkins build is back to normal : kafka-trunk-jdk14 #342

2020-08-05 Thread Apache Jenkins Server
See

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057952 ## File path: 26/upgrade.html ## @@ -19,6 +19,48 @@

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057579 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

Build failed in Jenkins: kafka-trunk-jdk11 #1691

2020-08-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Code cleanup in StreamsResetter (#9126) [github] MINOR: Streams integration tests should not call exit (#9067) [github] KAFKA-9274: Remove `retries` for global task (#9047)

[GitHub] [kafka-site] guozhangwang merged pull request #282: bug fixes

2020-08-05 Thread GitBox
guozhangwang merged pull request #282: URL: https://github.com/apache/kafka-site/pull/282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-10365) Cannot delete topic in Windows

2020-08-05 Thread Nilesh Balu Jorwar (Jira)
Nilesh Balu Jorwar created KAFKA-10365: -- Summary: Cannot delete topic in Windows Key: KAFKA-10365 URL: https://issues.apache.org/jira/browse/KAFKA-10365 Project: Kafka Issue Type: Bug

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Maulin Vasavada
Thanks Randall. That clarifies things. Makes sense! On Wed, Aug 5, 2020 at 11:38 AM Randall Hauch wrote: > Hi, Maulin. > > We have traditionally not mentioned *every* KIP in the project's blog posts > -- unless a release just happens to involve a small number of KIPs. This > means that we do

Re: [VOTE] KIP-595: A Raft Protocol for the Metadata Quorum

2020-08-05 Thread Jun Rao
Hi, Jason, Thanks for the KIP. +1 Just to confirm. For those newly added request types, will we expose the existing latency metrics (total, local, remote, etc) with a new tag request=[request-type]? Jun On Tue, Aug 4, 2020 at 3:00 PM Boyang Chen wrote: > Thanks for the KIP Jason, +1

Re: [DISCUSS] KIP-630: Kafka Raft Snapshot

2020-08-05 Thread Jun Rao
Hi, Jose, Thanks for the KIP. A few comments blow. 10. I agree with Jason that it's useful to document the motivation a bit clearer. Regarding semantic/performance, one benefit of snapshotting is that it allows changes to be encoded incrementally instead of using the full post image. For

[GitHub] [kafka-site] mjsax opened a new pull request #283: MINOR: fix HTML

2020-08-05 Thread GitBox
mjsax opened a new pull request #283: URL: https://github.com/apache/kafka-site/pull/283 Follow up to https://github.com/apache/kafka/pull/9127 \cc @guozhangwang This is an automated message from the Apache Git

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465958151 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465956697 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

Re: [DISCUSS] KIP-630: Kafka Raft Snapshot

2020-08-05 Thread Jose Garcia Sancio
Once again, thanks for the feedback Jason, My changes to the KIP are here: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158864763=18=17 And see my comments below... On Mon, Aug 3, 2020 at 1:57 PM Jason Gustafson wrote: > > Hi Jose, > > Thanks for the proposal. I

[GitHub] [kafka-site] hachikuji merged pull request #279: Add missing "to" to contributing page

2020-08-05 Thread GitBox
hachikuji merged pull request #279: URL: https://github.com/apache/kafka-site/pull/279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Randall Hauch
The last blog post for 2.5.0 mentioned KIP-500, and I know we've made a lot of progress on that and will have even more in upcoming releases. I'd like to add the following paragraph to the opening section, just after the paragraph mentioning JDK 14 and Scala 2.13: "Finally, these accomplishments

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Randall Hauch
Hi, Maulin. We have traditionally not mentioned *every* KIP in the project's blog posts -- unless a release just happens to involve a small number of KIPs. This means that we do have to choose a subset of the KIPs -- AK 2.6.0 had 30 KIPs that were implemented, and a blog summarizing each would be

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
scott-confluent commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465924056 ## File path: 25/documentation.html ## @@ -31,7 +31,7 @@ - Review comment: I believe the older versions SHOULD

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
scott-confluent commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465921715 ## File path: 25/streams/developer-guide/write-streams.html ## @@ -90,22 +90,22 @@ See the section Data Types and Serialization

[GitHub] [kafka-site] guozhangwang commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
guozhangwang commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465912196 ## File path: 25/documentation.html ## @@ -31,7 +31,7 @@ - Review comment: Ditto for other 25/xyx.html pages: does

[GitHub] [kafka-site] guozhangwang commented on pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
guozhangwang commented on pull request #277: URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669351468 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (KAFKA-10364) Use Token Bucket for all quotas

2020-08-05 Thread David Jacot (Jira)
David Jacot created KAFKA-10364: --- Summary: Use Token Bucket for all quotas Key: KAFKA-10364 URL: https://issues.apache.org/jira/browse/KAFKA-10364 Project: Kafka Issue Type: Sub-task

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Maulin Vasavada
Hi Randall One question: Do we mention all KIPs/NewFeatures in the blog that are listed in the release notes document - https://home.apache.org/~rhauch/kafka-2.6.0-rc2/RELEASE_NOTES.html ? I see that [KAFKA-8890 ] - KIP-519: Make SSL

[GitHub] [kafka-site] rhauch commented on pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on pull request #277: URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669332049 @guozhangwang, @ijuma: I've updated the content to try to address your comments. Would you mind taking a look?

[GitHub] [kafka-site] scott-confluent commented on pull request #278: Remove console.log()

2020-08-05 Thread GitBox
scott-confluent commented on pull request #278: URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669326459 Nice. Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka-site] guozhangwang commented on pull request #278: Remove console.log()

2020-08-05 Thread GitBox
guozhangwang commented on pull request #278: URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669312037 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [VOTE] KIP-578: Add configuration to limit number of partitions

2020-08-05 Thread Harsha Ch
Thanks for the updates Gokul.  +1 (binding). Thanks, Harsha On Wed, Aug 05, 2020 at 8:18 AM, Gokul Ramanan Subramanian < gokul24...@gmail.com > wrote: > > > > Hi. > > > > I request the community to kindly resume the voting process for KIP-578. > If you have further comments, we can

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
guozhangwang commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310726 Anyways, this change LGTM. Please feel free to merge afterwards This is an automated message from the

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
guozhangwang commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310491 Yeah I think encouraging people to directly submit PRs is better. This is an automated message from the

[GitHub] [kafka-site] scott-confluent opened a new pull request #282: bug fixes

2020-08-05 Thread GitBox
scott-confluent opened a new pull request #282: URL: https://github.com/apache/kafka-site/pull/282 ### home page - spelling - re-introduce see full list tooltip ### docs - remove version banner This is an

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Randall Hauch
Thanks, Jason. We haven't done that for a few releases, but I think it's a great idea. I've updated the blog post draft and the Google doc to mention the 127 contributors by name that will also be mentioned in the email release announcement. I also linked to the project's downloads page in the

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Randall Hauch
Thanks, Jason. We haven't done that for a few releases, but I think it's a great idea. I've updated the blog post draft and the Google doc to mention the 127 contributors by name that will also be mentioned in the email release announcement. I also linked to the project's downloads page in the

Re: Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Jason Gustafson
Hey Randall, Thanks for putting this together. I think it would be great if the blog included the names of the release contributors. It's an easy way to give some recognition. I know we have done that in the past. Thanks, Jason On Wed, Aug 5, 2020 at 8:25 AM Randall Hauch wrote: > I've

Preliminary blog post about the Apache 2.6.0 release

2020-08-05 Thread Randall Hauch
I've prepared a preliminary blog post about the upcoming Apache Kafka 2.6.0 release. Please take a look and let me know via this thread if you want to add/modify details. Thanks to all who contributed to this blog post. Unfortunately, the preview is not currently publicly visible at

Re: [VOTE] KIP-578: Add configuration to limit number of partitions

2020-08-05 Thread Gokul Ramanan Subramanian
Hi. I request the community to kindly resume the voting process for KIP-578. If you have further comments, we can address those as well. Thanks and cheers. On Tue, Jul 21, 2020 at 2:07 PM Gokul Ramanan Subramanian < gokul24...@gmail.com> wrote: > Hi. > > Can we resume the voting process for

[GitHub] [kafka-site] ottomata commented on pull request #280: Update Wikimedia powered-by text

2020-08-05 Thread GitBox
ottomata commented on pull request #280: URL: https://github.com/apache/kafka-site/pull/280#issuecomment-669199664 Thank you! On Wed, Aug 5, 2020 at 9:35 AM Ismael Juma wrote: > Merged #280 into asf-site. > > — > You

[DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-08-05 Thread Dongjin Lee
Hi, Kafka dev, I hope to initiate the discussion of KIP-653, upgrading log4j to log4j2. https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+log4j2 All kinds of feedbacks are greatly appreciated! Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical

[GitHub] [kafka-site] ijuma commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
ijuma commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669197495 Maybe we should ask people to submit a PR to this repo directly instead of the mailing list. What do you think @guozhangwang?

[GitHub] [kafka-site] ijuma merged pull request #280: Update Wikimedia powered-by text

2020-08-05 Thread GitBox
ijuma merged pull request #280: URL: https://github.com/apache/kafka-site/pull/280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] ijuma opened a new pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
ijuma opened a new pull request #281: URL: https://github.com/apache/kafka-site/pull/281 The mailing list seems more suitable. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka-site] ottomata commented on pull request #280: Update Wikimedia powered-by text

2020-08-05 Thread GitBox
ottomata commented on pull request #280: URL: https://github.com/apache/kafka-site/pull/280#issuecomment-669187906 Let me know if there is another process I don't know about other than PR to get this updated. Thank you!

[GitHub] [kafka-site] ottomata opened a new pull request #280: Update Wikimedia powered-by text

2020-08-05 Thread GitBox
ottomata opened a new pull request #280: URL: https://github.com/apache/kafka-site/pull/280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-08-05 Thread Dongjin Lee
Hi All, I updated the KIP and the implementation, following the discussion here. You must be working hard preparing the release of 2.6.0, so please have a look after your work is done. Thanks,

Re: New Website Layout

2020-08-05 Thread Luke Chen
When entering streams doc, it'll always show: *You're viewing documentation for an older version of Kafka - check out our current documentation here.* On Wed, Aug 5, 2020 at 6:44 PM Ben Stopford wrote: > Thanks for the PR and feedback Michael. Appreciated. > > On Wed, 5 Aug 2020 at 10:49,

[GitHub] [kafka-site] showuon commented on pull request #278: Remove console.log()

2020-08-05 Thread GitBox
showuon commented on pull request #278: URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669134108 Nice catch! LGTM! This is an automated message from the Apache Git Service. To respond to the message, please

Re: New Website Layout

2020-08-05 Thread Ben Stopford
Thanks for the PR and feedback Michael. Appreciated. On Wed, 5 Aug 2020 at 10:49, Mickael Maison wrote: > Thank you, it looks great! > > I found a couple of small issues: > - It's not rendering correctly with http. > - It's printing "called" to the console. I opened a PR to remove the >

[jira] [Created] (KAFKA-10363) Broker try to connect to a new cluster when there are changes in zookeeper.connect properties

2020-08-05 Thread Alexey Kornev (Jira)
Alexey Kornev created KAFKA-10363: - Summary: Broker try to connect to a new cluster when there are changes in zookeeper.connect properties Key: KAFKA-10363 URL: https://issues.apache.org/jira/browse/KAFKA-10363

[GitHub] [kafka-site] tom1299 opened a new pull request #279: Add missing "to" to contributing page

2020-08-05 Thread GitBox
tom1299 opened a new pull request #279: URL: https://github.com/apache/kafka-site/pull/279 Just added the missing word "to" the contribution guide This is an automated message from the Apache Git Service. To respond to the

Re: New Website Layout

2020-08-05 Thread Mickael Maison
Thank you, it looks great! I found a couple of small issues: - It's not rendering correctly with http. - It's printing "called" to the console. I opened a PR to remove the console.log() call: https://github.com/apache/kafka-site/pull/278 On Wed, Aug 5, 2020 at 9:45 AM Ben Stopford wrote: > >

[GitHub] [kafka-site] mimaison opened a new pull request #278: Remove console.log()

2020-08-05 Thread GitBox
mimaison opened a new pull request #278: URL: https://github.com/apache/kafka-site/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Build failed in Jenkins: kafka-trunk-jdk11 #1690

2020-08-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: add additional shutdown log info (#9124) -- [...truncated 6.41 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Re: New Website Layout

2020-08-05 Thread Ben Stopford
The new website layout has gone live as you may have seen. There are a couple of rendering issues in the streams developer guide that we're getting addressed. If anyone spots anything else could they please reply to this thread. Thanks Ben On Fri, 26 Jun 2020 at 11:48, Ben Stopford wrote: >

Build failed in Jenkins: kafka-trunk-jdk14 #341

2020-08-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: add additional shutdown log info (#9124) -- [...truncated 3.21 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Build failed in Jenkins: kafka-trunk-jdk8 #4764

2020-08-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: add additional shutdown log info (#9124) -- [...truncated 3.18 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [DISCUSS] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-08-05 Thread Yuriy Badalyantc
Hi John! I understand your point. But, I'm still not sure that having a Unit serde is a good idea because it could be ambiguous for the user. In a KStream [Long, Unit] valid value could mean one the following: 1. Empty byte array 2. null 3. Any value (value ignored) As a user of a library, I