[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711025894 I missed that file. You are good to go. This is an automated message from the Apache Git Service. To

Re: [VOTE] KIP-516: Topic Identifiers

2020-10-17 Thread Tom Bentley
+1 non-binding. Thanks! On Sat, Oct 17, 2020 at 7:55 AM David Jacot wrote: > Hi Justine, > > Thanks for the KIP! This is a great and long awaited improvement. > > +1 (binding) > > Best, > David > > Le ven. 16 oct. 2020 à 17:36, Rajini Sivaram a > écrit : > > > Hi Justine, > > > > +1 (binding)

[GitHub] [kafka-site] chia7712 commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
chia7712 commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710767238 @guozhangwang thanks for reviews! > you'd also need to git add the image file as well. The image file is already included. Please correct me if I misunderstand

Re: [VOTE] KIP-516: Topic Identifiers

2020-10-17 Thread David Jacot
Hi Justine, Thanks for the KIP! This is a great and long awaited improvement. +1 (binding) Best, David Le ven. 16 oct. 2020 à 17:36, Rajini Sivaram a écrit : > Hi Justine, > > +1 (binding) > > Thanks for all the work you put into this KIP! > > btw, there is a typo in the DeleteTopics

[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710760998 This is an automated message from the Apache Git Service. To respond to the message, please log on to