Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-18 Thread Luke Chen
Hi Seung-chan, Thanks for the update. One more comment: 3. Could you explain if user doesn't provide the `timeout` value in `CloseOptions`. What will happen? I saw the default value for `timeout` variable in `CloseOptions` is `null`. What doest null `timeout` mean? Thank you. Luke On Sat, Feb

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

2022-02-18 Thread Seung-chan Ahn
Hi Luke, Thanks for reviewing this KIP! 1. You are right, I'm only adding one method with `CloseOptions`. Let me comment in the KIP! -> Done 2. I think it makes more sense to have `Duration` type option which is aligned to the existing public method. Let me update the KIP! -> Done Seung-chan

Re: [DISCUSS] KIP-794: Strictly Uniform Sticky Partitioner

2022-02-18 Thread Artem Livshits
Hello Luke, Jun, Thank you for your feedback. I've added the Rejected Alternative section that may clarify some of the questions w.r.t. returning -1. 1. I've elaborated on the -1 in the KIP. The problem is that a significant part of the logic needs to be in the producer (because it now uses

Re: Call for review: KIP-618

2022-02-18 Thread Chris Egerton
Thanks Luke! Appreciate it. On Thu, Feb 17, 2022 at 10:02 PM Luke Chen wrote: > Hi Chris, > > Thanks for all the PRs (wow, 10K lines of changes). > EOS on source connector is a great feature in Kafka connect! > > I will start to review this PR next week: > Producer fencing API for admin client:

Re: [DISCUSS] KIP-820: Extend KStream process with new Processor API

2022-02-18 Thread John Roesler
Hello all, While I sympathize with Matthias’s desire to wipe the slate clean and redesign the dsl with full knowledge of everything we’ve learned in the past few years, that would also be a pretty intense project on its own. It seems better to leave that project for someone who is motivated to

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #706

2022-02-18 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-13676) When processing in ALOS we might as well commit progress made other tasks on a task specific exception

2022-02-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13676: -- Summary: When processing in ALOS we might as well commit progress made other tasks on a task specific exception Key: KAFKA-13676 URL:

[jira] [Resolved] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13666. --- Resolution: Fixed > Tests should not ignore exceptions for supported OS >

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #705

2022-02-18 Thread Apache Jenkins Server
See Changes: -- [...truncated 441971 lines...] [2022-02-18T11:26:26.750Z] + mvn archetype:generate -DarchetypeCatalog=local -DarchetypeGroupId=org.apache.kafka

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #704

2022-02-18 Thread Apache Jenkins Server
See