Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-06-28 Thread Matthias J. Sax
Thanks for the KIP. I don't think I fully digested the proposal yet, but my first reaction is: this is quite complicated. Frankly, I am worried about complexity and usability. Especially the option `safe_latest` is a "weird" one IMHO, and `nearest` is even more complex. The problem at

Re: [DISCUSS] KIP-837 Allow MultiCasting a Result Record.

2022-06-28 Thread Matthias J. Sax
Thanks for the KIP. Overall a good addition. I am actually not sure if we need to add a new class? From my understanding, if there is exactly one abstract method, the interface is still functional? Thus, we could add a new method to `StreamsPartitioner` with a default implementation (that

Re: [DISCUSS] KIP-847: Add ProducerCount metrics

2022-06-28 Thread Jun Rao
Hi, Artem, Thanks for the KIP. Could you explain the partition level ProducerIdCount a bit more? Does that reflect the number of PIDs ever produced to a partition since the broker is started? Do we reduce the count after a PID expires? Thanks, Jun On Wed, Jun 22, 2022 at 1:08 AM David Jacot

Re: [DISCUSS] KIP-821: Connect Transforms support for nested structures

2022-06-28 Thread Chris Egerton
Hi Jorge, Apologies for the long delay, had my own KIP-related work to focus on. I think it's fine to include array accesses but it's not a blocker. I'm +1 either way. On that front though, I think the MaskField section might need to be updated as it still mentions arrays and deep-scan? Cheers,

Re: [VOTE] KIP-821: Connect Transforms support for nested structures

2022-06-28 Thread Jorge Esteban Quilcate Otoya
Hi everyone, I'd like to bump this vote thread. Currently it's missing 1 +1 binding vote to pass (2 +1 binding, 1 +1 non-binding). There has been additional discussions to consider array access and deep-scan (similar to JsonPath) but hasn't been included as part of this KIP. The only minor

Re: [DISCUSS] KIP-821: Connect Transforms support for nested structures

2022-06-28 Thread Jorge Esteban Quilcate Otoya
Hi there, I have update the KIP to the previous state voted, including the configuration change from `field.style` to `field.syntax.version`. I'll bump the vote thread as well to see if there's agreement on adding this feature to Connect. Cheers, Jorge. On Wed, 15 Jun 2022 at 23:02, Jorge

[GitHub] [kafka-site] bbejeck commented on pull request #395: Update powered-by.html

2022-06-28 Thread GitBox
bbejeck commented on PR #395: URL: https://github.com/apache/kafka-site/pull/395#issuecomment-1169015004 Hi @Venom-git - I was about to merge this PR but it renders like this for me ![Screen Shot 2022-06-28 at 1 22 15

[GitHub] [kafka-site] bbejeck commented on pull request #315: Adding La Redoute as powered by Kafka

2022-06-28 Thread GitBox
bbejeck commented on PR #315: URL: https://github.com/apache/kafka-site/pull/315#issuecomment-1169006981 Hi @acraske - sorry it's taken a while to get to this PR - can you rebase this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] bbejeck commented on pull request #373: Add Globo (https://www.globo.com/) to the list of the "Powered By ❤️"

2022-06-28 Thread GitBox
bbejeck commented on PR #373: URL: https://github.com/apache/kafka-site/pull/373#issuecomment-1169006063 merged to asf-site thanks for the addition to the powered-by page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka-site] bbejeck merged pull request #373: Add Globo (https://www.globo.com/) to the list of the "Powered By ❤️"

2022-06-28 Thread GitBox
bbejeck merged PR #373: URL: https://github.com/apache/kafka-site/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] bbejeck commented on pull request #372: Add kPow (https://www.kpow.io) to the powered-by page

2022-06-28 Thread GitBox
bbejeck commented on PR #372: URL: https://github.com/apache/kafka-site/pull/372#issuecomment-1169000109 @d-t-w merged this, thanks for the addition to the powered-by section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka-site] bbejeck merged pull request #372: Add kPow (https://www.kpow.io) to the powered-by page

2022-06-28 Thread GitBox
bbejeck merged PR #372: URL: https://github.com/apache/kafka-site/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] bbejeck merged pull request #317: MINOR: Added Jitbit to powered-by page

2022-06-28 Thread GitBox
bbejeck merged PR #317: URL: https://github.com/apache/kafka-site/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] bbejeck commented on pull request #413: Add Covage to powered-by

2022-06-28 Thread GitBox
bbejeck commented on PR #413: URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1168958992 HI @ZachLC can you rebase this PR and we can get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Omnia Ibrahim
Hi Tom, I added Configuration Properties sections that document the properties and a couple of examples. On Tue, Jun 28, 2022 at 10:57 AM Tom Bentley wrote: > Hi Omnia, > > Please could you add to the KIP the documentation that forward.admin.class > config will have, and include that the

Re: [Vote] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Omnia Ibrahim
Thanks, Tom, I have updated the KIP to reflect these minor points. On Tue, Jun 28, 2022 at 10:58 AM Tom Bentley wrote: > Hi again Omnia, > > I left a couple of really minor points in the discussion thread. Assuming > you're happy with those I am +1 (binding). > > Thanks for your patience on

Re: [Vote] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Tom Bentley
Hi again Omnia, I left a couple of really minor points in the discussion thread. Assuming you're happy with those I am +1 (binding). Thanks for your patience on this. Kind regards, Tom On Tue, 28 Jun 2022 at 10:14, Omnia Ibrahim wrote: > Hi, > I did a small change to the KIP interface to

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Tom Bentley
Hi Omnia, Please could you add to the KIP the documentation that forward.admin.class config will have, and include that the signature of the class named by forward.admin.class must have a constructor that takes a `Map`? Many thanks, Tom On Wed, 22 Jun 2022 at 11:30, wrote: > Hi Tom > My

Re: [Vote] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Omnia Ibrahim
Hi, I did a small change to the KIP interface to address some discussions on the KIP. If all is good now can I get more votes on this, please? Thanks Omnia On Tue, Jun 21, 2022 at 10:34 AM Omnia Ibrahim wrote: > Hi, > Can I get more votes on this, please? > > Thanks > > On Sun, Jun 12, 2022 at