Re: [DISCUSS] KIP-837 Allow MultiCasting a Result Record.

2022-07-01 Thread Sagar
Hi Matthias, Thanks for your review. The reason I chose to introduce a new abstract class is that, while it doesn't entail any changes in the StreamPartitioner interface, I also disabled the partition() method in that class. Reason to do that is that I didn't want a scenario where a user implement

[jira] [Created] (KAFKA-14039) Fix KRaft AlterConfigPolicy usage

2022-07-01 Thread David Arthur (Jira)
David Arthur created KAFKA-14039: Summary: Fix KRaft AlterConfigPolicy usage Key: KAFKA-14039 URL: https://issues.apache.org/jira/browse/KAFKA-14039 Project: Kafka Issue Type: Bug

Re: Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-07-01 Thread hudeqi
Thanks for your attention and reply. Having chatted with Guozhang Wang at KAFKA-12478 before, I came up with an idea similar to yours. It's just not implemented on the client side, but on the server side: Firstly, find out all the groups subscribed to this topic before extending partitions, and

Re: Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-07-01 Thread hudeqi
Thanks for your attention and reply. Regarding the problem raised by this kip, if you have other ideas or solutions, you are welcome to put forward them, thank you. Best, hudeqi "David Jacot" 写道: > Thanks for the KIP. > > I read it and I am also worried by the complexity of th

Re: Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-07-01 Thread hudeqi
Thanks for your attention and reply. If it is put together with "latest", the "safe_latest" does look a bit strange, which may make users not know which one to choose. In essence, "safe_latest" is to solve the situation that data may be lost after extending partition, so I think it is better to

[DISCUSS] KIP-852 Optimize calculation of size for log in remote tier

2022-07-01 Thread Divij Vaidya
https://cwiki.apache.org/confluence/display/KAFKA/KIP-852%3A+Optimize+calculation+of+size+for+log+in+remote+tier Hey folks Please take a look at this KIP which proposes an extension to KIP-405. This is my first KIP with Apache Kafka community so any feedback would be highly appreciated. Cheers!

[jira] [Created] (KAFKA-14038) Optimize calculation of size for log in remote tier

2022-07-01 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14038: Summary: Optimize calculation of size for log in remote tier Key: KAFKA-14038 URL: https://issues.apache.org/jira/browse/KAFKA-14038 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-14037) Stopping mm2 meets ExecutionException for MirrorCheckpointTask

2022-07-01 Thread Justinwins (Jira)
Justinwins created KAFKA-14037: -- Summary: Stopping mm2 meets ExecutionException for MirrorCheckpointTask Key: KAFKA-14037 URL: https://issues.apache.org/jira/browse/KAFKA-14037 Project: Kafka I

Re: [VOTE] KIP-851: : Add requireStable flag into ListConsumerGroupOffsetsOptions

2022-07-01 Thread David Jacot
Hi Guozhang, Thanks for the KIP! I agree with Luke. `requireStable` seems more consistent. Regarding the kafka-consumer-group command line tool, I wonder if there is real value in doing it. We don't necessarily have to add all the options to it but we could if it is proven to be useful. Anyway,

Re: [VOTE] KIP-851: : Add requireStable flag into ListConsumerGroupOffsetsOptions

2022-07-01 Thread Bruno Cadonna
Hi Guozhang, thank you for the KIP! I do not have strong feelings about the naming of the getter, but I tend to agree with Luke. Regarding, the adaptation of the kafka-consumer-group.sh script, I am fine if we leave that for a future KIP. +1 (binding) Best, Bruno On 01.07.22 06:05, Luke

Re: PR #12368 review request

2022-07-01 Thread Николай Ижиков
Looks like tests succeed https://github.com/apache/kafka/pull/12368/checks?check_run_id=7140182176 Please, review. > 30 июня 2022 г., в 19:38, Николай Ижиков написал(а): > > Hello. > > I found dead code. > Raised a P