[GitHub] [kafka-site] anlance closed pull request #492: Fixed typos in introduction documentation

2023-02-18 Thread via GitHub
anlance closed pull request #492: Fixed typos in introduction documentation URL: https://github.com/apache/kafka-site/pull/492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-02-18 Thread Yash Mayya
Hi Chris, > I was actually envisioning something like `void > open(Collection originalPartitions, > Collection transformedPartitions)` Ah okay, this does make a lot more sense. Sorry, I think I misunderstood you earlier. I do agree with you that this seems better than splitting it off into two ne

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Chia-Ping Tsai
On 2023/02/18 08:44:05 Tom Bentley wrote: > Hi Chia-Ping, > > To be honest the stateful version, setting an input stream once using the > `readFrom(InputStream)` method and then repeatedly asking for the next > record using a parameterless `readRecord()`, seems a bit more natural to me > than `

Re: [VOTE] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Chia-Ping Tsai
Dear all, There is a change after I start this vote. The package is moved from "org.apache.kafka.common" to "org.apache.kafka.clients.tool". The purpose of the change is to enable tool-related interfaces to access code from "producer", "consumer", and "admin". Please verify the change before v

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Chia-Ping Tsai
Dear all, I noticed a issue after starting the vote :( The package "org.apache.kafka.common" disallows to import "org.apache.kafka.clients.producer.ProducerRecord". Hence, "org.apache.kafka.common.RecordReader" can't reference "org.apache.kafka.clients.producer.ProducerRecord" directly. It see

[jira] [Created] (KAFKA-14732) Use an exponential backoff retry mechanism while reconfiguring connector tasks

2023-02-18 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14732: -- Summary: Use an exponential backoff retry mechanism while reconfiguring connector tasks Key: KAFKA-14732 URL: https://issues.apache.org/jira/browse/KAFKA-14732 Project: K

Re: [VOTE] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Federico Valeri
+ 1 (non binding) Thanks On Sat, Feb 18, 2023 at 9:36 AM Chia-Ping Tsai wrote: > > Hi, > > I'd like to start the vote on KIP-614: An new java interface to replace > 'kafka.common.MessageReader' > > KIP-614: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866569 > > thread

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Tom Bentley
Hi Chia-Ping, To be honest the stateful version, setting an input stream once using the `readFrom(InputStream)` method and then repeatedly asking for the next record using a parameterless `readRecord()`, seems a bit more natural to me than `readRecord(InputStream inputStream)` being called repeate

[VOTE] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Chia-Ping Tsai
Hi, I'd like to start the vote on KIP-614: An new java interface to replace 'kafka.common.MessageReader' KIP-614: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866569 thread: https://lists.apache.org/thread.html/r6db6708f64345bb8fe0d573e05014fb790e69d501f21f855ca65619a%4

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Chia-Ping Tsai
On 2023/02/17 06:47:18 Luke Chen wrote: > Hi Chia-Ping, > > Thanks for the KIP! > > Overall LGTM, just one minor comment: > Could we log warning messages to users when using deprecated MessageReader? Sure. I will address it when implementing the KIP.