[GitHub] [kafka-site] Anykry opened a new pull request, #503: Update powered-by.html

2023-04-09 Thread via GitHub
Anykry opened a new pull request, #503: URL: https://github.com/apache/kafka-site/pull/503 Added Edenlab case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [DISCUSS] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-09 Thread ShunKang Lin
Thanks for your comment. This KIP does not modify ByteBufferSerializer#serialize(), so do we need to clarify this aspect on motivation? Best, ShunKang Ismael Juma 于2023年4月10日 周一12:37写道: > Hi, > > One interesting aspect is that the current `ByteBufferSerializer` avoids > copies in the following

Re: [DISCUSS] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-09 Thread Ismael Juma
Hi, One interesting aspect is that the current `ByteBufferSerializer` avoids copies in the following case: if (data.hasArray()) { final byte[] arr = data.array(); if (data.arrayOffset() == 0 && arr.length == data.remaining()) { return arr; } } It would be good to clarify this aspect in the

Re: [DISCUSS] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-09 Thread ShunKang Lin
Sorry for the late reply due to recent work overload. 3. If the ByteBufferSerializer#serializeToByteBuffer(String, ByteBuffer) method does not maintain the same behavior as the ByteBufferSerializer#serialize(String, ByteBuffer) method, it will break the code logic for those users who originally

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-09 Thread Ismael Juma
Colin, See comment below. On Sun, Apr 9, 2023 at 4:53 PM Colin McCabe wrote: > > > > Until this is the case and unless we carry out a Zookeeper version > upgrade we leave users to run on an end-of-life version with unpatched CVEs > addressed in later versions. > > > > Some users have

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-09 Thread Colin McCabe
On Wed, Mar 15, 2023, at 04:58, Christo Lolov wrote: > Hello Colin, > > Thank you for taking the time to review the proposal! > > I have attached a compatibility matrix to aid the explanation below - if the > mailing system rejects it I will find another way to share it. Hi Christo, The

[GitHub] [kafka-site] Anykry opened a new pull request, #502: Create edenlab.svg

2023-04-09 Thread via GitHub
Anykry opened a new pull request, #502: URL: https://github.com/apache/kafka-site/pull/502 Added Edenlab logo for powered-by page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific