Re: Review Request 36034: Patch for KAFKA-2306

2015-07-07 Thread Dong Lin
. To reply, visit: https://reviews.apache.org/r/36034/#review90730 --- On July 7, 2015, 5:47 p.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615622#comment-14615622 ] Dong Lin commented on KAFKA-2298: - Joel, could you please review this patch when you have

[jira] [Comment Edited] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615627#comment-14615627 ] Dong Lin edited comment on KAFKA-2241 at 7/6/15 8:48 PM: - Hi

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615627#comment-14615627 ] Dong Lin commented on KAFKA-2241: - Hi [~junrao]], could you please review this patch when

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
5671a3fbeea8cb9a9ffeeb41aa1b132b92c0cae8 clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 0baf16e55046a2f49f6431e01d52c323c95eddf0 Diff: https://reviews.apache.org/r/36034/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
-exhausted with a different name. I prefer the first option since I feel in practice people just want to distinguish between the case that messages failed to get into the producer from the case the messages gets failed to send to the broker. Dong Lin wrote: Thanks for your comments. If I

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-06 Thread Dong Lin
-exhausted with a different name. I prefer the first option since I feel in practice people just want to distinguish between the case that messages failed to get into the producer from the case the messages gets failed to send to the broker. Dong Lin wrote: Thanks for your comments. If I

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Attachment: KAFKA-2306_2015-07-06_14:54:01.patch New producer should emit metrics for buffer exhaustion

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-06 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615736#comment-14615736 ] Dong Lin commented on KAFKA-2306: - Updated reviewboard https://reviews.apache.org/r/36034

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-02 Thread Dong Lin
-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90303 --- On June 30, 2015, 4:04 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-06-29 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Resolution: Fixed Status: Resolved (was: Patch Available) Merged into KAFKA-2084. Measured rate

Review Request 36034: Patch for KAFKA-2306

2015-06-29 Thread Dong Lin
/kafka/clients/producer/internals/Sender.java 0baf16e55046a2f49f6431e01d52c323c95eddf0 Diff: https://reviews.apache.org/r/36034/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-06-29 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Attachment: KAFKA-2306.patch New producer should emit metrics for buffer exhaustion

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-06-29 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606954#comment-14606954 ] Dong Lin commented on KAFKA-2306: - Created reviewboard https://reviews.apache.org/r/36034

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-06-29 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Status: Patch Available (was: Open) New producer should emit metrics for buffer exhaustion

[jira] [Assigned] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-06-29 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned KAFKA-2306: --- Assignee: Dong Lin New producer should emit metrics for buffer exhaustion

[jira] [Created] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-06-29 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2306: --- Summary: New producer should emit metrics for buffer exhaustion Key: KAFKA-2306 URL: https://issues.apache.org/jira/browse/KAFKA-2306 Project: Kafka Issue Type: Bug

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
method? Dong Lin wrote: I have thought about it as well. But probabaly no. Because in Selector.send() we put failed destinationId is put in failedSends rather than disconnected. The reason we use failedSends is because send() and poll() in Selector will be called asynchronously

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
method? Dong Lin wrote: I have thought about it as well. But probabaly no. Because in Selector.send() we put failed destinationId is put in failedSends rather than disconnected. The reason we use failedSends is because send() and poll() in Selector will be called asynchronously

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-24 Thread Dong Lin
4aee214b24fd990be003adc36d675f015bf22fe6 Diff: https://reviews.apache.org/r/35791/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600047#comment-14600047 ] Dong Lin commented on KAFKA-2298: - Updated reviewboard https://reviews.apache.org/r/35791

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Attachment: KAFKA-2298_2015-06-24_13:00:39.patch Client Selector can drop connections

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Labels: (was: quotas) Client Selector can drop connections on InvalidReceiveException without

[jira] [Created] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2298: --- Summary: Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient Key: KAFKA-2298 URL: https://issues.apache.org/jira/browse/KAFKA-2298

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Attachment: KAFKA-2298.patch Client Selector can drop connections on InvalidReceiveException without

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Status: Patch Available (was: Open) Client Selector can drop connections on InvalidReceiveException

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598024#comment-14598024 ] Dong Lin commented on KAFKA-2298: - Created reviewboard https://reviews.apache.org/r/35791

Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
Diff: https://reviews.apache.org/r/35791/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review89010 --- On June 23, 2015, 5:41 p.m., Dong Lin wrote

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
method? Dong Lin wrote: I have thought about it as well. But probabaly no. Because in Selector.send() we put failed destinationId is put in failedSends rather than disconnected. The reason we use failedSends is because send() and poll() in Selector will be called asynchronously

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Labels: quotas (was: ) Client Selector can drop connections on InvalidReceiveException without

[jira] [Commented] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598719#comment-14598719 ] Dong Lin commented on KAFKA-2298: - Updated reviewboard https://reviews.apache.org/r/35791

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

2015-06-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2298: Attachment: KAFKA-2298_2015-06-23_18:47:54.patch Client Selector can drop connections

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
/Selector.java 4aee214b24fd990be003adc36d675f015bf22fe6 Diff: https://reviews.apache.org/r/35791/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 35791: Patch for KAFKA-2298

2015-06-23 Thread Dong Lin
method? Dong Lin wrote: I have thought about it as well. But probabaly no. Because in Selector.send() we put failed destinationId is put in failedSends rather than disconnected. The reason we use failedSends is because send() and poll() in Selector will be called asynchronously

Re: Guozhang Wang elected to Kafka PMC

2015-06-16 Thread Dong Lin
Congrats Guozhang! Dong On Tue, Jun 16, 2015 at 9:57 AM, Timothy Chen tnac...@gmail.com wrote: Congrats Guozhang!! Tim On Tue, Jun 16, 2015 at 8:19 AM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: Congrats Guozhang! From: Ashish

[jira] [Created] (KAFKA-2278) JmxTool should support querying all objects when object-name is omitted

2015-06-16 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2278: --- Summary: JmxTool should support querying all objects when object-name is omitted Key: KAFKA-2278 URL: https://issues.apache.org/jira/browse/KAFKA-2278 Project: Kafka

[jira] [Updated] (KAFKA-2278) JmxTool should support querying all objects when object-name is omitted

2015-06-16 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2278: Status: Patch Available (was: Open) JmxTool should support querying all objects when object-name

[jira] [Updated] (KAFKA-2278) JmxTool should support querying all objects when object-name is omitted

2015-06-16 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2278: Attachment: KAFKA-2278.patch JmxTool should support querying all objects when object-name is omitted

[jira] [Commented] (KAFKA-2278) JmxTool should support querying all objects when object-name is omitted

2015-06-16 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588865#comment-14588865 ] Dong Lin commented on KAFKA-2278: - Created reviewboard https://reviews.apache.org/r/35540

Review Request 35540: Patch for KAFKA-2278

2015-06-16 Thread Dong Lin
/ Testing --- Thanks, Dong Lin

[jira] [Created] (KAFKA-2280) Measurement of bytesInRate and bytesOutRate in BrokerTopicMetrics should be consistent

2015-06-16 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2280: --- Summary: Measurement of bytesInRate and bytesOutRate in BrokerTopicMetrics should be consistent Key: KAFKA-2280 URL: https://issues.apache.org/jira/browse/KAFKA-2280 Project

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584381#comment-14584381 ] Dong Lin commented on KAFKA-2241: - [~junrao] No, this bug is fixed in java 1.8.0. Can you

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-06-11 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Labels: quotas (was: ) Measured rate should not be infinite

Re: Review Request 34965: Patch for KAFKA-2241

2015-06-03 Thread Dong Lin
31a2639477bf66f9a05d2b9b07794572d7ec393b core/src/main/scala/kafka/server/AbstractFetcherThread.scala 83fc47417dd7fe4edf030217fa7fd69d99b170b0 Diff: https://reviews.apache.org/r/34965/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571766#comment-14571766 ] Dong Lin commented on KAFKA-2241: - Updated reviewboard https://reviews.apache.org/r/34965

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Attachment: KAFKA-2241_2015-06-03_15:30:35.patch AbstractFetcherThread.shutdown() should not block

Re: Review Request 34965: Patch for KAFKA-2241

2015-06-03 Thread Dong Lin
--- On June 3, 2015, 10:30 p.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965

Re: Review Request 34742: Patch for KAFKA-2171

2015-06-03 Thread Dong Lin
/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-2171) System Test for Quotas

2015-06-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2171: Description: Initial setup and configuration: In all scenarios, we create the following entities and topic

[jira] [Updated] (KAFKA-2171) System Test for Quotas

2015-06-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2171: Attachment: KAFKA-2171.patch System Test for Quotas -- Key: KAFKA

[jira] [Commented] (KAFKA-2171) System Test for Quotas

2015-06-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571464#comment-14571464 ] Dong Lin commented on KAFKA-2171: - Updated reviewboard https://reviews.apache.org/r/34742

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569988#comment-14569988 ] Dong Lin commented on KAFKA-2241: - Oh, I thought the first issue creation has failed

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570010#comment-14570010 ] Dong Lin commented on KAFKA-2241: - Created reviewboard https://reviews.apache.org/r/34965

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Attachment: KAFKA-2241.patch AbstractFetcherThread.shutdown() should not block

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Status: Patch Available (was: Open) AbstractFetcherThread.shutdown() should not block

Review Request 34965: Patch for KAFKA-2241

2015-06-02 Thread Dong Lin
/kafka/server/AbstractFetcherThread.scala 83fc47417dd7fe4edf030217fa7fd69d99b170b0 Diff: https://reviews.apache.org/r/34965/diff/ Testing --- Thanks, Dong Lin

[jira] [Resolved] (KAFKA-2240) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-2240. - Resolution: Duplicate AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read

[jira] [Closed] (KAFKA-2240) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed KAFKA-2240. --- Duplicate of KAFKA-2241. AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer

[jira] [Created] (KAFKA-2240) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2240: --- Summary: AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer) Key: KAFKA-2240 URL: https://issues.apache.org/jira/browse/KAFKA-2240 Project

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Attachment: client.java server.java Run server before client. Then check if channel.read

[jira] [Created] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-06-02 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2241: --- Summary: AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer) Key: KAFKA-2241 URL: https://issues.apache.org/jira/browse/KAFKA-2241 Project

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-28 Thread Dong Lin
On May 28, 2015, 12:58 p.m., Manikumar Reddy O wrote: core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 145 https://reviews.apache.org/r/33049/diff/10/?file=972066#file972066line145 Are we using clientID as uniqueKey?. But as of now, clientID is not mandatory and it

[jira] [Updated] (KAFKA-2171) System Test for Quotas

2015-05-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2171: Status: Patch Available (was: Open) System Test for Quotas -- Key

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-27 Thread Dong Lin
://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-2171) System Test for Quotas

2015-05-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562070#comment-14562070 ] Dong Lin commented on KAFKA-2171: - Created reviewboard https://reviews.apache.org/r/34742

[jira] [Updated] (KAFKA-2171) System Test for Quotas

2015-05-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2171: Description: Initial setup and configuration: In all scenarios, we create the following entities and topic

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-27 Thread Dong Lin
HandlerProcessor in package handler cannot be accessed in package com.sun.xml.internal.ws.handler import com.sun.xml.internal.ws.handler.HandlerProcessor.RequestOrResponse - Dong Lin On May 26, 2015, 6:53 p.m., Aditya Auradkar wrote

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-27 Thread Dong Lin
://reviews.apache.org/r/34418/diff/. Thanks, Dong Lin

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191_2015-05-27_17:28:41.patch Measured rate should not be infinite

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562074#comment-14562074 ] Dong Lin commented on KAFKA-2191: - Updated reviewboard https://reviews.apache.org/r/34170

Re: Review Request 34418: Patch for KAFKA-2191

2015-05-20 Thread Dong Lin
On May 19, 2015, 5:41 p.m., Dong Lin wrote: clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line 64 https://reviews.apache.org/r/34418/diff/1/?file=963982#file963982line64 Hey Jay, My approach differs with your only in this line

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-19 Thread Dong Lin
for quota implementation. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review84341 --- On May 14, 2015, 7:34 a.m., Dong Lin

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-19 Thread Dong Lin
--- On May 14, 2015, 7:34 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170

Re: Review Request 34418: Patch for KAFKA-2191

2015-05-19 Thread Dong Lin
with both approaches. - Dong Lin On May 19, 2015, 5:12 p.m., Jay Kreps wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34418

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-17 Thread Dong Lin
do we need that? Isn't purging obsolete samples handled on measurement already? I think that is more elegant. You must see some issue there, maybe you can explain? Dong Lin wrote: Adi: Good catch! I will update the patch to fix the problem. Jay: Sure. Here is the problem I

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-17 Thread Dong Lin
On May 12, 2015, 7:38 p.m., Dong Lin wrote: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines 122-127 https://reviews.apache.org/r/33049/diff/9/?file=955824#file955824line122 The function quits on the first quota violaation, and calculate delayTime based

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-16 Thread Dong Lin
://reviews.apache.org/r/33049/#comment135148 Do you mean RequestKeys.nameForKey(RequestKeys.FetchKey)? - Dong Lin On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-15 Thread Dong Lin
do we need that? Isn't purging obsolete samples handled on measurement already? I think that is more elegant. You must see some issue there, maybe you can explain? Dong Lin wrote: Adi: Good catch! I will update the patch to fix the problem. Jay: Sure. Here is the problem I

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-14 Thread Dong Lin
shrinks to zero but why is giving back 0 the right answer? In the case you guys were testing 0 was safe, but imagine a case where the monitoring was checking that the value didn't fall below some threshold. Dong Lin wrote: The question is, when Rate.measure() is called right after

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-14 Thread Dong Lin
shrinks to zero but why is giving back 0 the right answer? In the case you guys were testing 0 was safe, but imagine a case where the monitoring was checking that the value didn't fall below some threshold. Dong Lin wrote: The question is, when Rate.measure() is called right after

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-14 Thread Dong Lin
? - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review83687 --- On May 13, 2015, 10:32 p.m., Dong Lin wrote

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-14 Thread Dong Lin
/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java b341b7daaa10204906d78b812fb05fd27bc69373 Diff: https://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-14 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543329#comment-14543329 ] Dong Lin commented on KAFKA-2191: - Updated reviewboard https://reviews.apache.org/r/34170

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-14 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191_2015-05-14_00:34:30.patch Measured rate should not be infinite

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java b341b7daaa10204906d78b812fb05fd27bc69373 Diff: https://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
. To reply, visit: https://reviews.apache.org/r/34170/#review83629 --- On May 13, 2015, 3:47 p.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191_2015-05-13_15:32:15.patch Measured rate should not be infinite

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542851#comment-14542851 ] Dong Lin commented on KAFKA-2191: - Updated reviewboard https://reviews.apache.org/r/34170

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542135#comment-14542135 ] Dong Lin commented on KAFKA-2191: - Created reviewboard https://reviews.apache.org/r/34170

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Status: Patch Available (was: Open) Measured rate should not be infinite

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191.patch Measured rate should not be infinite

Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
/stats/SampledStat.java b341b7daaa10204906d78b812fb05fd27bc69373 Diff: https://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

[jira] [Created] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2191: --- Summary: Measured rate should not be infinite Key: KAFKA-2191 URL: https://issues.apache.org/jira/browse/KAFKA-2191 Project: Kafka Issue Type: Bug

Re: Review Request 33378: Patch for KAFKA-2136

2015-05-12 Thread Dong Lin
://reviews.apache.org/r/33378/#comment134427 Will readFromLocalLog() read data into memory before the cilent's quota is checked? - Dong Lin On May 11, 2015, 9:51 p.m., Aditya Auradkar wrote: --- This is an automatically generated e-mail

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-12 Thread Dong Lin
violaation, and calculate delayTime based on this violation. Should we enumerate all metric in this.metrics() and set delayTime of the QuotaViolationException to be the largest delayTime of all violatoins? - Dong Lin On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
/test/scala/unit/kafka/server/OffsetCommitTest.scala 528525b719ec916e16f8b3ae3715bec4b5dcc47d Diff: https://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539906#comment-14539906 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/33557

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-05-12_07:32:07.patch Track offset commit requests separately from produce

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83234 --- On May 12, 2015, 2:32 p.m., Dong Lin wrote

<    4   5   6   7   8   9   10   11   12   >