[jira] [Created] (KAFKA-13286) Revisit Streams State Store and Serde Implementation

2021-09-09 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13286: - Summary: Revisit Streams State Store and Serde Implementation Key: KAFKA-13286 URL: https://issues.apache.org/jira/browse/KAFKA-13286 Project: Kafka Issue

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

2021-09-07 Thread Guozhang Wang
Thanks Ryan, Read the KIP and it makes sense. +1 as well. On Tue, Sep 7, 2021 at 1:42 PM Colin McCabe wrote: > +1 (binding) > > thanks, Ryan > > best, > Colin > > On Tue, Sep 7, 2021, at 09:47, Colin McCabe wrote: > > Hi Ryan, > > > > Thanks for working on this. I think it is almost ready to

Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-09-07 Thread Guozhang Wang
Thanks Sagar, +1 from me. Guozhang On Sat, Sep 4, 2021 at 10:29 AM Sagar wrote: > Hi All, > > I would like to start a vote on the following KIP: > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390 > > Thanks! > Sagar. > -- -- Guozhang

Re: [VOTE] KIP-773 Differentiate consistently metric latency measured in millis and nanos

2021-09-03 Thread Guozhang Wang
Thanks Josep, Took a look at the KIP, LGTM. On Fri, Sep 3, 2021 at 11:25 AM Josep Prat wrote: > Hi there, > > Since it's a rather small KIP, I'd like to start a vote for the KIP-773 > Differentiate consistently metric latency measured in millis and nanos. > The KIP page The KIP can be found

[jira] [Created] (KAFKA-13268) Add more integration tests for Table Table FK joins with repartitioning

2021-09-02 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13268: - Summary: Add more integration tests for Table Table FK joins with repartitioning Key: KAFKA-13268 URL: https://issues.apache.org/jira/browse/KAFKA-13268 Project

Re: [DISCUSS] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-09-01 Thread Guozhang Wang
evant public-facing changes, including > > metadata like the config's "Importance". Personally > > I would recommend Medium, or even High if we're really worried about the > > default being wrong for a lot of users > > > > Thanks for the KIP, besides

[jira] [Resolved] (KAFKA-13257) KafkaStreams Support For Latest RocksDB Version

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13257. --- Resolution: Not A Problem > KafkaStreams Support For Latest RocksDB Vers

[jira] [Resolved] (KAFKA-13175) The topic is marked for deletion, create topic with the same name throw exception topic already exists.

2021-09-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13175. --- Fix Version/s: 3.1.0 Resolution: Fixed > The topic is marked for deletion, cre

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

2021-08-31 Thread Guozhang Wang
Thanks for letting us know, Rohan. On Tue, Aug 31, 2021 at 1:08 AM Rohan Desai wrote: > FYI I've updated the metric names in the KIP to the form ".*-time-ns-total" > and clarified that the times being measured are in nanoseconds. > > On Wed, Jul 21, 2021 at 5:09 PM Rohan Desai > wrote: > > >

[jira] [Created] (KAFKA-13243) Differentiate metric latency measured in millis and nanos

2021-08-27 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13243: - Summary: Differentiate metric latency measured in millis and nanos Key: KAFKA-13243 URL: https://issues.apache.org/jira/browse/KAFKA-13243 Project: Kafka

[jira] [Created] (KAFKA-13239) Use RocksDB.ingestExternalFile for restoration

2021-08-27 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13239: - Summary: Use RocksDB.ingestExternalFile for restoration Key: KAFKA-13239 URL: https://issues.apache.org/jira/browse/KAFKA-13239 Project: Kafka Issue Type

Re: [DISCUSS] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-26 Thread Guozhang Wang
s aggregated at a task level? > 4) I am ok with the name change, but would like to know others' thoughts. > > Thanks! > Sagar. > > On Sun, Aug 22, 2021 at 11:54 PM Guozhang Wang wrote: > > > Thanks Sagar for writing this PR. > > > > I think twice about the opt

Re: [DISCUSS] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-22 Thread Guozhang Wang
Thanks Sagar for writing this PR. I think twice about the options that have been proposed in https://issues.apache.org/jira/browse/KAFKA-13152, and feel that at the moment it's simpler to just do the even distribution of the configured total bytes. My rationale is that right now we have a static

Re: Making topic validation public

2021-08-17 Thread Guozhang Wang
Hi Boyang, I feel okay to add a doc section in Kafka about which topic names are valid; and maybe add such validation into Utils as well. Guozhang On Sun, Aug 15, 2021 at 12:57 PM Boyang Chen wrote: > Hey there, > > Kafka has an internal topic validation logic > < >

Re: [VOTE] KIP-766: fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-17 Thread Guozhang Wang
Thanks Luke! +1 as well. On Tue, Aug 17, 2021 at 11:42 AM John Roesler wrote: > Thanks, Luke! > > I'm sorry I missed your discussion thread. The KIP looks > good to me! > > I'm +1 (binding) > > Thanks, > -John > > On Tue, 2021-08-17 at 16:40 +0800, Luke Chen wrote: > > Hi all, > > I'd like to

[jira] [Resolved] (KAFKA-13170) Flaky Test InternalTopicManagerTest.shouldRetryDeleteTopicWhenTopicUnknown

2021-08-10 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13170. --- Fix Version/s: 3.1.0 Resolution: Fixed > Flaky T

[jira] [Created] (KAFKA-13172) Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported

2021-08-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13172: - Summary: Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported Key: KAFKA-13172 URL: https://issues.apache.org/jira/browse/KAFKA-13172

Re: Request Permissions to Contribute

2021-08-05 Thread Guozhang Wang
Hello Jordan, I've added you to the permission list, you should be able to create wiki pages now. Guozhang On Wed, Aug 4, 2021 at 2:27 PM Jordan Bull wrote: > Hi, > > I'd like to request permissions to contribute to Kafka to propose a KIP. > > Wiki ID: jbull > Jira ID: jbull > > Thanks you, >

[jira] [Resolved] (KAFKA-8683) Flakey test InternalTopicManagerTest @shouldNotCreateTopicIfExistsWithDifferentPartitions

2021-07-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8683. -- Resolution: Cannot Reproduce Have not seen this flakiness recently and also cannot reproduce

[jira] [Created] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-07-30 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13152: - Summary: Replace "buffered.records.per.partition" with "input.buffer.max.bytes" Key: KAFKA-13152 URL: https://issues.apache.org/jira/browse/KAFKA-13152

[jira] [Resolved] (KAFKA-9858) CVE-2016-3189 Use-after-free vulnerability in bzip2recover in bzip2 1.0.6 allows remote attackers to cause a denial of service (crash) via a crafted bzip2 file, related

2021-07-29 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9858. -- Fix Version/s: 3.0.0 Resolution: Fixed > CVE-2016-3189 Use-after-free vulnerabil

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

2021-07-27 Thread Guozhang Wang
Hello Rohan, Thanks for the KIP. As Bruno mentioned in the other thread could you update the "New Metrics" that 1) we have sub-titles for streams, producer, consumer metrics, just for clarification, and 2) update the "producer-id" etc to "client-id" to be consistent with the existing metrics.

Re: [VOTE] KIP-763: Range queries with open endpoints

2021-07-27 Thread Guozhang Wang
Thank you, Patrick! The KIP looks good to me, and I also agree with the pragmatic manner. +1 (binding) Guozhang On Thu, Jul 22, 2021 at 11:09 AM John Roesler wrote: > Thank you, Patrick, > > +1 (binding) from me as well! > > Thanks, > -John > > On Thu, 2021-07-22 at 10:40 +0200, Bruno

Re: Contributor permission for assigning Jira ticket

2021-07-26 Thread Guozhang Wang
Hello Reggie, It seems Sophie has granted you the contribution permission :) Guozhang On Mon, Jul 26, 2021 at 6:19 PM Reggie Hsu wrote: > I would like to work on KAFKA-13120 > , and I would like to > ask for contributor permission. > My Jira

[jira] [Resolved] (KAFKA-13008) Stream will stop processing data for a long time while waiting for the partition lag

2021-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13008. --- Assignee: Guozhang Wang Resolution: Fixed > Stream will stop processing d

Re: [DISCUSS] KIP-761: Add total blocked time metric to streams

2021-07-20 Thread Guozhang Wang
Thanks Rohan. I remember now that we moved the round-trip PID's txn completion logic into init-transaction and commit/abort-transaction. So I think we'd count time as in StreamsProducer#initTransaction as well (admittedly it is in most cases a one-time thing). Other than that, I do not have any

Re: [DISCUSS] KIP-761: Add total blocked time metric to streams

2021-07-12 Thread Guozhang Wang
Hey Rohan, Thanks for putting up the KIP. Maybe you can also briefly talk about the context in the email message as well (they are very well explained inside the KIP doc though). I have a few meta and detailed thoughts after reading it. 1) I agree that the current ratio metrics is just

Re: [ANNOUNCE] New Kafka PMC Member: Konstantine Karantasis

2021-06-21 Thread Guozhang Wang
Congratulations Konstantine! On Mon, Jun 21, 2021 at 9:37 AM Tom Bentley wrote: > Congratulations Konstantine! > > On Mon, Jun 21, 2021 at 5:33 PM David Jacot > wrote: > > > Congrats, Konstantine. Well deserved! > > > > Best, > > David > > > > On Mon, Jun 21, 2021 at 6:14 PM Ramesh Krishnan >

Re: KAFKA-12889 pull request review request

2021-06-19 Thread Guozhang Wang
Hi Qiang, Thanks for filing this report! It is a good find, and I've reviewed your PR. On Thu, Jun 17, 2021 at 7:11 AM qiang liu wrote: > hi kafka devlopers. > I have created a jira KAFKA-12889 > and a pull requst > 10818 >

[jira] [Created] (KAFKA-12957) Refactor Streams Logical Plan Generation

2021-06-16 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12957: - Summary: Refactor Streams Logical Plan Generation Key: KAFKA-12957 URL: https://issues.apache.org/jira/browse/KAFKA-12957 Project: Kafka Issue Type

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-14 Thread Guozhang Wang
If we believe this tool does not work anymore and there's other ways to achieve the intended function, then we should remove it in the next release; otherwise, I think this KIP still is worthy. In any ways, we should not left a cmd tool not maintained but not removed either. Guozhang On Thu, Jun

Re: Request for contributor permission

2021-06-14 Thread Guozhang Wang
Hello Nicolas, I've added you to the contributors list. You should be able to assign tickets to yourself now. Guozhang On Mon, Jun 14, 2021 at 7:24 AM Nicolas Guignard < nicolas.guignar...@gmail.com> wrote: > Hi, > > I am sending this email to ask to have the contributor's permission in >

[jira] [Resolved] (KAFKA-10585) Kafka Streams should clean up the state store directory from cleanup

2021-06-11 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10585. --- Fix Version/s: 3.0.0 Resolution: Fixed > Kafka Streams should clean up the st

Re: Request permission for KIP creation

2021-06-10 Thread Guozhang Wang
Hello Yi, I've added you to the wiki space. Cheers, Guozhang On Thu, Jun 10, 2021 at 12:58 PM Yi Ding wrote: > Hi Team, > > Could you help grant me permission to create KIP on > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals > ? > > My info is: > Wiki ID: Yi

[jira] [Created] (KAFKA-12920) Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost`

2021-06-08 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12920: - Summary: Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost` Key: KAFKA-12920 URL: https://issues.apache.org/jira/browse

[jira] [Resolved] (KAFKA-12918) Watch-Free Animated 'America: The Motion Picture' Trailer 2021 Full Hd Download

2021-06-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12918. --- > Watch-Free Animated 'America: The Motion Picture' Trailer 2021 Full Hd > Do

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

2021-06-07 Thread Guozhang Wang
; change then. This way, as well, this KIP is completely > >> consistent on making those Metadata classes interfaces with internal > >> implementations. > >> I'll update the KIP document right away. > >> > >> Thanks for replying on Saturday

[jira] [Resolved] (KAFKA-10614) Group coordinator onElection/onResignation should guard against leader epoch

2021-06-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10614. --- Fix Version/s: 3.0.0 Resolution: Fixed > Group coordinator onElection/onResignat

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

2021-06-05 Thread Guozhang Wang
lottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491715557497 > > w: aiven.io > > e: josep.p...@aiven.io > > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > > > Hello Josep, > > > > Thanks for the pr

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

2021-06-04 Thread Guozhang Wang
Hello Josep, Thanks for the proposal! The write-up looks good to me in general. I'm just wondering if you feel comfortable to align this with another JIRA/KIP further down the road: https://issues.apache.org/jira/browse/KAFKA-12370 Which tries to clean up the metadata hierarchy and the callers

Re: [VOTE] KIP-726: Make the "cooperative-sticky, range" as the default assignor

2021-06-03 Thread Guozhang Wang
Thanks Luke, I'm +1 on this proposal. Guozhang On Wed, Jun 2, 2021 at 8:16 PM Luke Chen wrote: > Hi all, > I'd like to call for a vote on KIP-726: Make the "cooperative-sticky, > range" as the default assignor. > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=177048248 > >

[jira] [Created] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

2021-06-03 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12887: - Summary: Do not trigger user-customized ExceptionalHandler for RTE Key: KAFKA-12887 URL: https://issues.apache.org/jira/browse/KAFKA-12887 Project: Kafka

Re: [VOTING] KIP-693: Client-side Circuit Breaker for Partition Write Errors

2021-06-02 Thread Guozhang Wang
Thanks George, I'm generally +1 on the proposed change here, would like to review the detailed PR to see if there's any devils in the details. Guozhang On Tue, Jun 1, 2021 at 7:19 PM Guoqiang Shu wrote: > Dear All, > We would like to get a vote on this proposal. The implementation is linked

Re: Permission to create KIPs

2021-05-26 Thread Guozhang Wang
Hello Josep, I saw your id "josep.prat" is already added on the wiki, you should be able to create KIPs now. On Wed, May 26, 2021 at 10:09 AM Josep Prat wrote: > Hi there, > > I would like to have permissions to create KIPs on the wiki. > My username should be josep.prat. > > Thanks, > > ——— >

Re: EXTERNAL: Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

2021-05-26 Thread Guozhang Wang
Hi Meiling, Could you double check if the email sent is from non-sanboxed " m...@rockwellautomation.com" instead of "m...@rockwellautomation.com.invalid"? I believe the dev-unsubscr...@kafka.apache.org does work. On Wed, May 26, 2021 at 3:32 PM Meiling He wrote: > Can anyone instruct me how to

Re: [VOTE] KIP-741: Change default serde to be null

2021-05-24 Thread Guozhang Wang
+1, thanks! On Mon, May 24, 2021 at 1:51 PM Leah Thomas wrote: > Hi, > > I'd like to kick-off voting for KIP-741: Change default serde to be null. > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-741%3A+Change+default+serde+to+be+null > > > The > discussion is linked on the KIP for

Re: [VOTE] KIP-743: Remove config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-21 Thread Guozhang Wang
+1, thanks! On Fri, May 21, 2021 at 12:45 AM Bruno Cadonna wrote: > Hi, > > I'd like to start a vote on KIP-743 that proposes to remove config value > 0.10.0-2.4 from Streams config built.in.metrics.version. > > https://cwiki.apache.org/confluence/x/uIfOCg > > Best, > Bruno > -- -- Guozhang

Re: [DISCUSS] KIP-743: Deprecate config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-20 Thread Guozhang Wang
I'm also a bit leaning towards dropping the config value in 3.0 directly. For the config itself, I'd rather keep it a bit longer in case we may update the metrics again (there are a couple near term projects on the roadmap including named topology, restoration threads etc). Guozhang On Thu,

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Guozhang Wang
` function with the new return type without introducing a new one with different name, but I knew since this is not favored by most people :). On Wed, May 19, 2021 at 11:01 PM Guozhang Wang wrote: > Thanks Sophie, I like the current proposal better compared to adding a new > TaskInfo cla

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Guozhang Wang
t; > >> sop...@confluent.io> > >> > wrote: > >> > > >> > > Thanks all. I updated the KIP slightly since there is some ambiguity > >> > > around whether the existing TaskId class is > >> > > currently part of the public API or not. To se

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Guozhang Wang
; necessarily all at once, but gradually after this KIP) > > Thoughts? > > On Wed, May 19, 2021 at 10:31 AM Guozhang Wang wrote: > > > Leah, thanks for the KIP. > > > > It looks good to me overall, just following up on @br...@confluent.io > > 's question about e

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-19 Thread Guozhang Wang
Leah, thanks for the KIP. It looks good to me overall, just following up on @br...@confluent.io 's question about exception: what about using the `TopologyException` class? I know that currently it is only thrown during the topology parsing phase, not at the streams construction, but I feel we

[jira] [Created] (KAFKA-12812) Consider refactoring state store registration path

2021-05-18 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12812: - Summary: Consider refactoring state store registration path Key: KAFKA-12812 URL: https://issues.apache.org/jira/browse/KAFKA-12812 Project: Kafka Issue

Re: [DISCUSS] KIP-740: Replace the public TaskId class with an interface

2021-05-16 Thread Guozhang Wang
Sophie, Thanks for the nice summary. Originally I'm leaning towards option 2) since changing this name to others could be a pretty large conceptual change to users, and I think the concerns you raised is good as well that we cannot reuse the `taskId()` function names any more.. After pondering

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-13 Thread Guozhang Wang
+1 On a hindsight, maybe TaskId should not really be in `org.apache.kafka.streams.processor` but rather just in `o.a.k.streams`, but maybe not worth pulling it up now :) Guozhang On Thu, May 13, 2021 at 1:58 PM Walker Carlson wrote: > +1 from me! (non-binding) > > Walker > > On Thu, May 13,

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Guozhang Wang
LGTM! Thanks David. On Thu, May 6, 2021 at 10:03 AM Ron Dagostino wrote: > Thanks again for the KIP, David. +1 (non-binding) from me. > > Ron > > On Tue, May 4, 2021 at 11:21 AM David Arthur wrote: > > > Hello everyone, I'd like to start the vote on KIP-730 which adds a new > RPC > > for

[jira] [Resolved] (KAFKA-12683) Remove deprecated "UsePreviousTimeOnInvalidTimeStamp"

2021-05-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12683. --- Fix Version/s: 3.0.0 Assignee: Guozhang Wang Resolution: Fixed > Rem

Re: [VOTE] KIP-735: Increase default consumer session timeout

2021-04-28 Thread Guozhang Wang
+1. Thanks Jason! On Wed, Apr 28, 2021 at 12:50 PM Gwen Shapira wrote: > I love this improvement. > > +1 (binding) > > On Wed, Apr 28, 2021 at 10:46 AM Jason Gustafson > > wrote: > > > Hi All, > > > > I'd like to start a vote on KIP-735: > > > > >

[jira] [Created] (KAFKA-12693) Consecutive rebalances with zombie instances may cause corrupted changelogs

2021-04-19 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12693: - Summary: Consecutive rebalances with zombie instances may cause corrupted changelogs Key: KAFKA-12693 URL: https://issues.apache.org/jira/browse/KAFKA-12693

Re: [ANNOUNCE] Apache Kafka 2.8.0

2021-04-19 Thread Guozhang Wang
Blee-Goldman, > Attila Sasvari, Benoit Maggi, bertber, bill, Bill Bejeck, > Bob Barrett, Boyang Chen, Brajesh Kumar, Bruno Cadonna, > Cheng Tan, Chia-Ping Tsai, Chris Egerton, CHUN-HAO TANG, > Colin Patrick McCabe, Colin P. Mccabe, Cyrus Vafadari, David > Arthur, David Jacot, David Mao,

[jira] [Created] (KAFKA-12683) Remove deprecated "UsePreviousTimeOnInvalidTimeStamp"

2021-04-18 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12683: - Summary: Remove deprecated "UsePreviousTimeOnInvalidTimeStamp" Key: KAFKA-12683 URL: https://issues.apache.org/jira/browse/KAFKA-12683 Proj

[jira] [Resolved] (KAFKA-12633) Remove deprecated "TopologyTestDriver#pipeInput / readOutput"

2021-04-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12633. --- Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated "TopologyTe

Re: [ANNOUNCE] New Kafka PMC Member: Randall Hauch

2021-04-17 Thread Guozhang Wang
Congratulations Randall ! Well deserved. Guozhang On Fri, Apr 16, 2021 at 4:45 PM Matthias J. Sax wrote: > Hi, > > It's my pleasure to announce that Randall Hauch in now a member of the > Kafka PMC. > > Randall has been a Kafka committer since Feb 2019. He has remained > active in the

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-04-16 Thread Guozhang Wang
you can think > of a better way to phrase "New applications on 3.0 will enable cooperative > rebalancing by default" then > please let me know. > > > Thanks for the response -- hope this makes sense so far, but I'm happy to > elaborate any aspects of the > proposal which

Re: [VOTE] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-15 Thread Guozhang Wang
+1 as well (binding). Thanks Sophie! On Thu, Apr 15, 2021 at 7:29 AM Bruno Cadonna wrote: > Sophie, > > Thank you for the KIP! > > +1 (binding) > > Best, > Bruno > > On 15.04.21 01:59, Sophie Blee-Goldman wrote: > > Hey all, > > > > I'd like to kick off the vote on KIP-732, to deprecate

Re: [VOTE} KIP-733: change Kafka Streams default replication factor config

2021-04-15 Thread Guozhang Wang
+1 as well. Thanks! On Wed, Apr 14, 2021 at 4:30 PM Bill Bejeck wrote: > Thanks for the KIP Matthias. > > +1 (binding) > > -Bill > > On Wed, Apr 14, 2021 at 7:06 PM Sophie Blee-Goldman > wrote: > > > Thanks Matthias. I'm +1 (binding) > > > > -Sophie > > > > On Wed, Apr 14, 2021 at 3:36 PM

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-04-14 Thread Guozhang Wang
t; > > @Luke - Do you think we can also include Connect in this KIP? > >> Right > >> > now > >> > > > we > >> > > > > don't set any custom partition assignment strategies for the > >> consumer > >> > > > &g

[jira] [Created] (KAFKA-12669) Add deleteRange to WindowStore / KeyValueStore interfaces

2021-04-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12669: - Summary: Add deleteRange to WindowStore / KeyValueStore interfaces Key: KAFKA-12669 URL: https://issues.apache.org/jira/browse/KAFKA-12669 Project: Kafka

Re: [DISCUSS] KIP-730: Producer ID generation in KRaft mode

2021-04-14 Thread Guozhang Wang
Hi David, Just putting my paranoid hat here :) Could we name the req/resp name as "AllocateProducerIds" instead of "AllocateProducerId"? Otherwise, LGTM! Guozhang On Thu, Apr 8, 2021 at 2:23 PM Ron Dagostino wrote: > Hi David. I'm wondering if it might be a good idea to have the broker >

Re: [VOTE] KIP-718: Make KTable Join on Foreign key unopinionated

2021-04-14 Thread Guozhang Wang
Thanks Marco, +1 from me too. Guozhang On Wed, Apr 14, 2021 at 8:15 AM John Roesler wrote: > I’m +1 (binding) > > Thanks, Marco! > -John > > On Wed, Apr 14, 2021, at 07:59, Marco Aurélio Lotz wrote: > > Hi all, > > > > I would like to start a vote on KIP-718, which proposes to make KTable >

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Guozhang Wang
Thanks Sophie for writing the KIP! I'm +1 on the proposal. On Wed, Apr 14, 2021 at 8:56 AM Ismael Juma wrote: > Thanks Sophie. This makes sense to me. One question: do we want to be a bit > clearer about the removal plans? That is, can we say that the deprecated > configs will be removed in 4.0

[jira] [Resolved] (KAFKA-12643) Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function)

2021-04-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12643. --- Resolution: Duplicate Thanks for confirming! > Kafka Streams 2.7 with Kafka Broker 2.

Re: [DISCUSS] KIP-693: Client-side Circuit Breaker for Partition Write Errors

2021-04-12 Thread Guozhang Wang
> > On Wed, Mar 24, 2021 at 4:05 AM Guoqiang Shu > wrote: > > > > > In our current proposal it can be configured via > > producer.circuit.breaker.mute.retry.interval (defaulted to 10 mins), but > > perhaps 'interval' is a confusing name. > > > > On 2021/03/23 00:

Re: [ANNOUNCE] New Kafka PMC Member: Bill Bejeck

2021-04-12 Thread Guozhang Wang
Congratulations Bill ! Guozhang On Wed, Apr 7, 2021 at 6:16 PM Matthias J. Sax wrote: > Hi, > > It's my pleasure to announce that Bill Bejeck in now a member of the > Kafka PMC. > > Bill has been a Kafka committer since Feb 2019. He has remained > active in the community since becoming a

Re: [VOTE] 2.6.2 RC1

2021-04-08 Thread Guozhang Wang
Looked over the javadocs and web docs again. Download the jars and check the license files are all updated now (thanks to John again!). +1 On Thu, Apr 8, 2021 at 1:48 PM Sophie Blee-Goldman wrote: > Hello Kafka users, developers and client-developers, > > This is the second candidate for

[jira] [Created] (KAFKA-12633) Remove deprecated "TopologyTestDriver#pipeInput / readOutput"

2021-04-08 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12633: - Summary: Remove deprecated "TopologyTestDriver#pipeInput / readOutput" Key: KAFKA-12633 URL: https://issues.apache.org/jira/browse/KAFKA-12633 Proj

[jira] [Resolved] (KAFKA-12630) Remove deprecated KafkaClientSupplier#getAdminClient

2021-04-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12630. --- Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated KafkaClientSuppl

[jira] [Resolved] (KAFKA-12568) Remove deprecated "KStream#groupBy/join", "Joined#named" overloads

2021-04-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12568. --- Fix Version/s: 3.0.0 Assignee: Guozhang Wang Resolution: Fixed > Rem

[ANNOUNCE] New Committer: Bruno Cadonna

2021-04-07 Thread Guozhang Wang
Hello all, I'm happy to announce that Bruno Cadonna has accepted his invitation to become an Apache Kafka committer. Bruno has been contributing to Kafka since Jan. 2019 and has made 99 commits and more than 80 PR reviews so far: https://github.com/apache/kafka/commits?author=cadonna He worked

[jira] [Created] (KAFKA-12630) Remove deprecated KafkaClientSupplier#getAdminClient

2021-04-07 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12630: - Summary: Remove deprecated KafkaClientSupplier#getAdminClient Key: KAFKA-12630 URL: https://issues.apache.org/jira/browse/KAFKA-12630 Project: Kafka Issue

[jira] [Resolved] (KAFKA-7785) Remove PartitionGrouper interface and it's config and move DefaultPartitionGrouper to internal package

2021-04-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7785. -- Resolution: Fixed > Remove PartitionGrouper interface and it's config and m

Re: [VOTE] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

2021-04-06 Thread Guozhang Wang
+1. Thanks! On Tue, Apr 6, 2021 at 7:01 AM Leah Thomas wrote: > Hi Sagar, +1 non-binding. Thanks again for doing this. > > Leah > > On Mon, Apr 5, 2021 at 9:40 PM John Roesler wrote: > > > Thanks, Sagar! > > > > I’m +1 (binding) > > > > -John > > > > On Mon, Apr 5, 2021, at 21:35, Sophie

Re: [VOTE] KIP-633: Drop 24 hour default of grace period in Streams

2021-04-06 Thread Guozhang Wang
+1. Thanks! On Tue, Apr 6, 2021 at 7:00 AM Leah Thomas wrote: > Thanks for picking this up, Sophie. +1 from me, non-binding. > > Leah > > On Mon, Apr 5, 2021 at 9:42 PM John Roesler wrote: > > > Thanks, Sophie, > > > > I’m +1 (binding) > > > > -John > > > > On Mon, Apr 5, 2021, at 21:34,

Re: [DISCUSS] KIP-718: Make KTable Join on Foreign key unopinionated

2021-04-05 Thread Guozhang Wang
> - On the current API, we change it to piggy back on the materialization > > method provided to the join store. > > - We extend the API to allow a user to fine tune different > materialization > > methods for subscription and join store. > > > > What do you thi

[jira] [Resolved] (KAFKA-9765) Could not add partitions to transaction due to errors

2021-04-02 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9765. -- Resolution: Duplicate > Could not add partitions to transaction due to err

Re: [DISCUSS] KIP-633: Drop 24 hour default of grace period in Streams

2021-03-31 Thread Guozhang Wang
Hello Sophie, I agree that the old 24-hour grace period should be updated, and I also think now it is a better idea to make the grace period "mandatory" from the API names since it is a very important concept and hence worth emphasizing to users up front. Guozhang On Wed, Mar 31, 2021 at 1:58

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-03-30 Thread Guozhang Wang
Hi Sophie, My question is more related to KAFKA-12477, but since your latest replies are on this thread I figured we can follow-up on the same venue. Just so I understand your latest comments above about the approach: * I think, we would need to persist this decision so that the group would

[jira] [Resolved] (KAFKA-12428) Add a last-heartbeat-seconds-ago metric to Kafka Consumer

2021-03-29 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12428. --- Resolution: Duplicate > Add a last-heartbeat-seconds-ago metric to Kafka Consu

[jira] [Resolved] (KAFKA-7106) Remove segment/segmentInterval from Window definition

2021-03-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7106. -- Resolution: Fixed > Remove segment/segmentInterval from Window definit

[jira] [Resolved] (KAFKA-12562) Remove deprecated-overloaded "KafkaStreams#metadataForKey" and "KafkaStreams#store"

2021-03-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12562. --- Resolution: Fixed > Remove deprecated-overloaded "KafkaStreams#metada

[jira] [Resolved] (KAFKA-12524) Remove deprecated WindowBytesStoreSupplier#segments

2021-03-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12524. --- Resolution: Fixed > Remove deprecated WindowBytesStoreSupplier#segme

[jira] [Created] (KAFKA-12568) Remove deprecated "KStream#groupBy/join", "Joined#named" overloads

2021-03-27 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12568: - Summary: Remove deprecated "KStream#groupBy/join", "Joined#named" overloads Key: KAFKA-12568 URL: https://issues.apache.org/jira/browse/KAFKA-12568

[jira] [Created] (KAFKA-12562) Remove deprecated-overloaded "KafkaStreams#metadataForKey" and "KafkaStreams#store"

2021-03-25 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12562: - Summary: Remove deprecated-overloaded "KafkaStreams#metadataForKey" and "KafkaStreams#store" Key: KAFKA-12562 URL: https://issues.apache.org/jir

[jira] [Resolved] (KAFKA-12527) Remove deprecated "PartitionGrouper" interface

2021-03-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12527. --- Resolution: Duplicate > Remove deprecated "PartitionGrouper&qu

[jira] [Resolved] (KAFKA-12526) Remove deprecated long ms overloads

2021-03-25 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12526. --- Resolution: Duplicate > Remove deprecated long ms overlo

[jira] [Created] (KAFKA-12549) Allow state stores to opt-in transactional support

2021-03-24 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12549: - Summary: Allow state stores to opt-in transactional support Key: KAFKA-12549 URL: https://issues.apache.org/jira/browse/KAFKA-12549 Project: Kafka Issue

[jira] [Created] (KAFKA-12527) Remove deprecated "PartitionAssignor" interface

2021-03-23 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12527: - Summary: Remove deprecated "PartitionAssignor" interface Key: KAFKA-12527 URL: https://issues.apache.org/jira/browse/KAFKA-12527 Project: Kafka

[jira] [Created] (KAFKA-12526) Remove deprecated long ms overloads

2021-03-23 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12526: - Summary: Remove deprecated long ms overloads Key: KAFKA-12526 URL: https://issues.apache.org/jira/browse/KAFKA-12526 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-12524) Remove deprecated WindowBytesStoreSupplier#segments

2021-03-22 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12524: - Summary: Remove deprecated WindowBytesStoreSupplier#segments Key: KAFKA-12524 URL: https://issues.apache.org/jira/browse/KAFKA-12524 Project: Kafka Issue

Re: [DISCUSS] KIP-693: Client-side Circuit Breaker for Partition Write Errors

2021-03-22 Thread Guozhang Wang
Thanks for the updated KIP! Some more comments inlined. On Sun, Mar 7, 2021 at 6:43 PM Guoqiang Shu wrote: > > > Guozhang, many thanks for taking a look! Sorry for the late reply, we have > iterated the prototype on our production setup with your question in mind > and updated the KIP

<    1   2   3   4   5   6   7   8   9   10   >