[jira] [Created] (KAFKA-9145) AbstractCoordinator should respect retry backoff between rebalances

2019-11-05 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9145: -- Summary: AbstractCoordinator should respect retry backoff between rebalances Key: KAFKA-9145 URL: https://issues.apache.org/jira/browse/KAFKA-9145 Project: Kafka

[jira] [Created] (KAFKA-9144) Early expiration of producer state can cause coordinator epoch to regress

2019-11-05 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9144: -- Summary: Early expiration of producer state can cause coordinator epoch to regress Key: KAFKA-9144 URL: https://issues.apache.org/jira/browse/KAFKA-9144 Project

[jira] [Resolved] (KAFKA-9102) Increase default zk session timeout and max lag

2019-10-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9102. Resolution: Fixed > Increase default zk session timeout and max

[jira] [Resolved] (KAFKA-9105) Truncate producer state when incrementing log start offset

2019-10-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9105. Resolution: Fixed > Truncate producer state when incrementing log start off

[jira] [Resolved] (KAFKA-8992) Don't expose Errors in `RemoveMemberFromGroupResult`

2019-10-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8992. Resolution: Fixed > Don't expose Errors in `RemoveMemberFromGro

[jira] [Resolved] (KAFKA-9038) Allow creating partitions while partition reassignment is in progress

2019-10-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9038. Fix Version/s: 2.4.0 Resolution: Fixed > Allow creating partitions while partit

[jira] [Resolved] (KAFKA-9089) Reassignment should be resilient to unexpected errors

2019-10-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9089. Resolution: Fixed > Reassignment should be resilient to unexpected err

[jira] [Created] (KAFKA-9102) Increase default zk session timeout and max lag

2019-10-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9102: -- Summary: Increase default zk session timeout and max lag Key: KAFKA-9102 URL: https://issues.apache.org/jira/browse/KAFKA-9102 Project: Kafka Issue Type

Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-24 Thread Jason Gustafson
gt; Thanks, > > Harsha > > > > On Tue, Oct 22, 2019 at 3:20 PM Colin McCabe wrote: > > > > > +1 (binding). > > > > > > Thanks, Jason. > > > > > > best, > > > Colin > > > > > > > > > On Mon, Oct 21

[jira] [Created] (KAFKA-9099) Reassignments should be retried after unexpected errors

2019-10-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9099: -- Summary: Reassignments should be retried after unexpected errors Key: KAFKA-9099 URL: https://issues.apache.org/jira/browse/KAFKA-9099 Project: Kafka

[jira] [Created] (KAFKA-9089) Reassignment should be resilient to unexpected errors

2019-10-23 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9089: -- Summary: Reassignment should be resilient to unexpected errors Key: KAFKA-9089 URL: https://issues.apache.org/jira/browse/KAFKA-9089 Project: Kafka

[jira] [Resolved] (KAFKA-9056) Selector outbound byte metric does not count partial sends

2019-10-23 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9056. Fix Version/s: 2.5.0 Resolution: Fixed > Selector outbound byte metric does

Re: [VOTE] KIP-538: Add a metric tracking the number of open connections with a given SSL cipher type

2019-10-22 Thread Jason Gustafson
+1 Thanks Colin. On Tue, Oct 22, 2019 at 12:42 AM Tom Bentley wrote: > +1 (non-binding). Thanks! > > On Tue, Oct 22, 2019 at 1:03 AM Gwen Shapira wrote: > > > +1 > > > > Thanks for leading this :) > > > > On Mon, Oct 21, 2019 at 3:43 PM Colin McCabe wrote: > > > > > > Hi all, > > > > > > I'd l

Re: [VOTE] 2.3.1 RC2

2019-10-22 Thread Jason Gustafson
+1 I ran the basic quickstart on the 2.12 artifact and verified signatures/checksums. I also looked over the release notes. I see that KAFKA-8950 is included, so maybe they just need to be refreshed. Thanks for running the release! -Jason On Fri, Oct 18, 2019 at 5:23 AM David Arthur wrote: >

[jira] [Created] (KAFKA-9081) Loosen reassignment completion to handle existing URPs

2019-10-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9081: -- Summary: Loosen reassignment completion to handle existing URPs Key: KAFKA-9081 URL: https://issues.apache.org/jira/browse/KAFKA-9081 Project: Kafka

[VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-21 Thread Jason Gustafson
I'd like to start a vote for KIP-537: https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout . +1 from me Thanks, Jason

Re: [DISCUSS] KIP-538: Add a metric tracking the number of open connections with a given SSL cipher type

2019-10-21 Thread Jason Gustafson
+1 Looks reasonable to me. Tracking this per-processor is probably not that useful, but I agree it simplifies the implementation. -Jason On Wed, Oct 16, 2019 at 11:58 AM Colin McCabe wrote: > Hi all, > > I wrote a short KIP about adding a metric to track the number of open > connections with a

[jira] [Resolved] (KAFKA-8962) KafkaAdminClient#describeTopics always goes through the controller

2019-10-17 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8962. Fix Version/s: 2.4.0 Resolution: Fixed > KafkaAdminClient#describeTopics alw

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-17 Thread Jason Gustafson
batch (and practically the deltas will be all negative)? > > > > > > If that's case, could we do some back of the envelope calculation on > > what's > > > the possible smallest case of deltas? Note that since we use varInt for > >

[jira] [Resolved] (KAFKA-9004) Fetch from follower unintentionally allowed for old consumers

2019-10-17 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9004. Resolution: Fixed > Fetch from follower unintentionally allowed for old consum

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-16 Thread Jason Gustafson
+1. Thanks Richard. On Wed, Oct 16, 2019 at 10:04 AM Richard Yu wrote: > Hi all, > > Want to try to get this KIP wrapped up. So it would be great if we can get > some votes. > > Cheers, > Richard > > On Tue, Oct 15, 2019 at 12:58 PM Jun Rao wrote: > > > Hi, Richard, > > > > Thanks for the updat

[jira] [Created] (KAFKA-9056) Selector outbound byte metric does not count partial sends

2019-10-16 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9056: -- Summary: Selector outbound byte metric does not count partial sends Key: KAFKA-9056 URL: https://issues.apache.org/jira/browse/KAFKA-9056 Project: Kafka

[jira] [Created] (KAFKA-9047) AdminClient group operations may not respect backoff

2019-10-15 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9047: -- Summary: AdminClient group operations may not respect backoff Key: KAFKA-9047 URL: https://issues.apache.org/jira/browse/KAFKA-9047 Project: Kafka Issue

[DISCUSS] KIP-537: Increase default zookeeper session timeout

2019-10-15 Thread Jason Gustafson
Hi All, I have a short KIP to raise the default zk session timeout: https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout. Please take a look. Thanks, Jason

[jira] [Resolved] (KAFKA-9033) Change default client-id in consumer / producer to be more meaningful

2019-10-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9033. Fix Version/s: 2.4.0 Resolution: Fixed > Change default client-id in consu

[jira] [Resolved] (KAFKA-8813) Race condition when creating topics and changing their configuration

2019-10-15 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8813. Fix Version/s: 2.4.0 2.3.2 Resolution: Fixed > Race condit

[jira] [Created] (KAFKA-9040) Implement --all option when describing configs

2019-10-14 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9040: -- Summary: Implement --all option when describing configs Key: KAFKA-9040 URL: https://issues.apache.org/jira/browse/KAFKA-9040 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-8725) Improve LogCleaner error handling when failing to grab the filthiest log

2019-10-11 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8725. Fix Version/s: 2.4.0 Resolution: Fixed > Improve LogCleaner error handling w

Re: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2019-10-09 Thread Jason Gustafson
; exception hierarchy. > >>> >> > >>> >> > >>> >> -Matthias > >>> >> > >>> >> On 8/8/18 2:57 AM, Stanislav Kozlovski wrote: > >>> >> >> If you are inheriting from SerializationException, your derived > >>&g

Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-10-09 Thread Jason Gustafson
gt; > > +1 (binding) > > > > > > Regards, > > > > > > Rajini > > > > > > On Wed, Sep 25, 2019 at 4:41 PM Colin McCabe > wrote: > > > > > > > Looks good. +1 (binding) > > > > > > > &g

[DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-10-09 Thread Jason Gustafson
Hi All, I wrote a short KIP to address a longstanding issue with timeout behavior in the AdminClient: https://cwiki.apache.org/confluence/display/KAFKA/KIP-533%3A+Add+default+api+timeout+to+AdminClient . Take a look and let me know what you think. Thanks, Jason

[jira] [Created] (KAFKA-9004) Fetch from follower unintentionally enabled for old consumers

2019-10-08 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9004: -- Summary: Fetch from follower unintentionally enabled for old consumers Key: KAFKA-9004 URL: https://issues.apache.org/jira/browse/KAFKA-9004 Project: Kafka

[jira] [Resolved] (KAFKA-7190) Under low traffic conditions purging repartition topics cause WARN statements about UNKNOWN_PRODUCER_ID

2019-10-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7190. Fix Version/s: 2.4.0 Assignee: Bob Barrett (was: Guozhang Wang) Resolution

[jira] [Resolved] (KAFKA-8983) AdminClient deleteRecords should not fail all partitions unnecessarily

2019-10-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8983. Fix Version/s: 2.4.0 Resolution: Fixed > AdminClient deleteRecords should not f

[jira] [Created] (KAFKA-8992) Don't expose Errors in Admin result objects

2019-10-07 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8992: -- Summary: Don't expose Errors in Admin result objects Key: KAFKA-8992 URL: https://issues.apache.org/jira/browse/KAFKA-8992 Project: Kafka Issue

[jira] [Resolved] (KAFKA-8985) Use flexibleVersions with LeaderAndIsr, UMR, etc., and improve RequestResponseTest coverage

2019-10-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8985. Fix Version/s: 2.4.0 Assignee: Jason Gustafson (was: Colin McCabe

[jira] [Resolved] (KAFKA-8885) The Kafka Protocol should Support Optional Tagged Fields

2019-10-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8885. Fix Version/s: 2.4.0 Resolution: Fixed > The Kafka Protocol should Support Optio

[jira] [Created] (KAFKA-8983) AdminClient deleteRecords should not fail all partitions unnecessarily

2019-10-04 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8983: -- Summary: AdminClient deleteRecords should not fail all partitions unnecessarily Key: KAFKA-8983 URL: https://issues.apache.org/jira/browse/KAFKA-8983 Project

[jira] [Created] (KAFKA-8976) AdminClient deleteRecords should not fetch metadata unnecessarily

2019-10-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8976: -- Summary: AdminClient deleteRecords should not fetch metadata unnecessarily Key: KAFKA-8976 URL: https://issues.apache.org/jira/browse/KAFKA-8976 Project: Kafka

Re: [VOTE] 2.3.1 RC0

2019-09-24 Thread Jason Gustafson
Hi David, Thanks for running the release. I think we should consider getting this bug fixed: https://issues.apache.org/jira/browse/KAFKA-8896. The impact of this bug is that consumer groups cannot commit offsets or rebalance. The patch should be ready shortly. Thanks, Jason On Fri, Sep 13, 201

Re: [DISCUSS] KIP-515: Reorganize checkpoint system in log cleaner to be per partition

2019-09-24 Thread Jason Gustafson
o I created this KIP only > with resolving the problem regarding tombstones. > Whats your thoughts? If the problem regarding transaction markers is a > little too complex, then we can we just leave it out of the KIP and fix the > tombstones issue. > > Cheers, > Richard >

[VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-24 Thread Jason Gustafson
Hi All, I'm starting a vote for KIP-524, which is a small change to the config tool: https://cwiki.apache.org/confluence/display/KAFKA/KIP-524%3A+Allow+users+to+choose+config+source+when+describing+configs . +1 from me. Thanks, Jason

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-23 Thread Jason Gustafson
Thanks David for the clarification. That sounds good. On Mon, Sep 23, 2019 at 12:35 AM David Jacot wrote: > Hi all, > > The vote has passed with +3 binding votes (Colin McCabe, Gwen Shapira, > Jason Gustafson) and +3 non binding votes (Mickael Maison, Konstantine > Karantasis

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

2019-09-20 Thread Jason Gustafson
+1 from me. This is a clever solution. Kind of a pity we couldn't work flexible version support into the response, but I understand why it is difficult. One minor nitpick: the INVALID_REQUEST error already exists. Are you intending to reuse it? Thanks, Jason On Fri, Sep 20, 2019 at 3:50 PM Konst

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-20 Thread Jason Gustafson
+1 Thanks! On Thu, Sep 19, 2019 at 11:22 PM Tom Bentley wrote: > +1 (non-binding). > > On Fri, Sep 20, 2019 at 7:00 AM Maulin Vasavada > > wrote: > > > +1 (non-binding). Thanks for the KIP. > > > > On Thu, Sep 19, 2019 at 10:38 PM Manikumar > > wrote: > > > > > +1 (binding), Thanks for the KIP

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-20 Thread Jason Gustafson
rios. > > > > > > > > > > I have added this to the KIP: > > > > > * - poll-idle-ratio*: The fraction of time the consumer spent > waiting > > > for > > > > > the user to process records from poll. > > > > > > >

Re: [DISCUSS] KIP-515: Reorganize checkpoint system in log cleaner to be per partition

2019-09-19 Thread Jason Gustafson
Hi Richard, Just reposting my comment from the JIRA: The underlying problem here also impacts the cleaning of transaction markers. We use the same delete horizon in order to tell when it is safe to remove the marker. If all the data from a transaction has been cleaned and the delete horizon has p

[jira] [Resolved] (KAFKA-8841) Optimize Partition.maybeIncrementLeaderHW

2019-09-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8841. Resolution: Fixed > Optimize Partition.maybeIncrementLeade

Re: [DISCUSS] KIP-524: Allow users to choose config source when describing configs

2019-09-16 Thread Jason Gustafson
rote: > > > Ah, great idea. > > > > On Fri, Sep 13, 2019 at 8:47 AM Jason Gustafson > > wrote: > > > > > > Hi All, > > > > > > I have a minor KIP to improve the config tool: > > > > > > https://cwiki.apache.org/

[jira] [Created] (KAFKA-8908) Use ApiVersion API for inter-broker communication

2019-09-14 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8908: -- Summary: Use ApiVersion API for inter-broker communication Key: KAFKA-8908 URL: https://issues.apache.org/jira/browse/KAFKA-8908 Project: Kafka Issue

[jira] [Resolved] (KAFKA-8474) Improve configuration layout on website

2019-09-13 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8474. Resolution: Fixed > Improve configuration layout on webs

Re: [VOTE] KIP-500: Replace ZooKeeper with a Self-Managed Metadata Quorum

2019-09-13 Thread Jason Gustafson
Late here, but I am a big +1. Great to see this finally happening. -Jason On Fri, Sep 13, 2019 at 11:43 AM Colin McCabe wrote: > Hi all, > > With 3 binding +1 votes from Gwen Shapira, Ismael Juma, and Bill Bejeck > and 5 non-binding +1 votes from Tom Bentley, Ron Dagostino, David Jacot, > Dhruv

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-13 Thread Jason Gustafson
Hi Kevin, This looks reasonable to me. I'd also +1 Radai's suggestion if you're willing. Something like an idle ratio for the consumer would be helpful. Thanks, Jason On Fri, Sep 13, 2019 at 10:08 AM radai wrote: > while youre at it another metric that we have found to be useful is % > time sp

[DISCUSS] KIP-524: Allow users to choose config source when describing configs

2019-09-13 Thread Jason Gustafson
Hi All, I have a minor KIP to improve the config tool: https://cwiki.apache.org/confluence/display/KAFKA/KIP-524%3A+Allow+users+to+choose+config+source+when+describing+configs. Let me know what you think. -Jason

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-09-12 Thread Jason Gustafson
. I'll also modify the kip to make > > > these clear. > > > > > > On Fri, Sep 6, 2019 at 4:01 PM Jason Gustafson > wrote: > > > > > >> Hi Arjun, > > >> > > >> The updated KIP looks good. Just a couple questions: &g

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

2019-09-12 Thread Jason Gustafson
gt; > > On Tue, Sep 10, 2019 at 10:18 AM Matthias J. Sax < > > > matth...@confluent.io> > > > > > > wrote: > > > > > > > > > > > >> Thanks for the KIP Guozhang. > > > > > >> > > > > > >>> Another reason i

[jira] [Resolved] (KAFKA-8875) CreateTopic API should check topic existence before replication factor

2019-09-11 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8875. Fix Version/s: 2.4.0 Resolution: Fixed > CreateTopic API should check to

[jira] [Resolved] (KAFKA-8747) Flaky Test ControllerEventManagerTest#testEventQueueTime

2019-09-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8747. Resolution: Fixed > Flaky Test ControllerEventManagerTest#testEventQueueT

[jira] [Created] (KAFKA-8896) NoSuchElementException after coordinator move

2019-09-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8896: -- Summary: NoSuchElementException after coordinator move Key: KAFKA-8896 URL: https://issues.apache.org/jira/browse/KAFKA-8896 Project: Kafka Issue Type

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

2019-09-10 Thread Jason Gustafson
breaking compatibility just for aesthetics. -Jason On Tue, Sep 10, 2019 at 9:41 AM Guozhang Wang wrote: > Thanks Jason! > > On Tue, Sep 10, 2019 at 9:07 AM Jason Gustafson > wrote: > > > Hi Guozhang, > > > > I think the motivation for the new API makes sense. I've wa

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

2019-09-10 Thread Jason Gustafson
Hi Guozhang, I think the motivation for the new API makes sense. I've wanted something like this in the past. That said, do you think there is a substantial benefit from deprecating the old API? I can still see it being convenient in some cases and it's no real cost to maintain. Also, just a mino

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2019-09-09 Thread Jason Gustafson
;). Anyway, I'm satisfied if we just document the recommended approach and explain the risk if users don't follow it. -Jason On Mon, Sep 9, 2019 at 12:52 PM Boyang Chen wrote: > Thanks Jason for the vote! > > On Mon, Sep 9, 2019 at 12:07 PM Jason Gustafson > wrote: >

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2019-09-09 Thread Jason Gustafson
+1 Thanks for the KIP. Just a couple comments below: 1. Kafka APIs traditionally leave off `get` from API names. How about `groupMetadata` instead of `getMetadata`? 2. I am guessing memberId and groupInstanceId should be nullable in the TxnOffsetCommit schema? 3. Just to clarify on the upgrade pro

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-09-06 Thread Jason Gustafson
ew endpoint. > > If this works with you all, I can update the KIP. Please let me know what > you think. > > Thanks everyone. > > Best, > > On Thu, Aug 29, 2019 at 10:14 AM Colin McCabe wrote: > > > On Mon, Aug 26, 2019, at 14:03, Jason Gustafson wrote: > &

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-06 Thread Jason Gustafson
+1 Thanks Colin. This is really going to help with compatibility. -Jason On Wed, Sep 4, 2019 at 1:34 PM Colin McCabe wrote: > On Wed, Sep 4, 2019, at 13:01, Jason Gustafson wrote: > > Hi Colin, > > > > Just a couple questions. > > > > 1. I think we discusse

[jira] [Resolved] (KAFKA-8590) Replace TxnOffsetCommitRequest request/response with automated protocol

2019-09-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8590. Resolution: Fixed > Replace TxnOffsetCommitRequest request/response with automa

[jira] [Resolved] (KAFKA-8822) Remove CompletedFetch type from Fetcher

2019-09-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8822. Resolution: Fixed > Remove CompletedFetch type from Fetc

[jira] [Resolved] (KAFKA-8724) log cleaner thread dies when attempting to clean a __consumer_offsets partition after upgrade from 2.0->2.3

2019-09-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8724. Resolution: Fixed > log cleaner thread dies when attempting to clean a __consumer_offs

[jira] [Created] (KAFKA-8875) CreateTopic API should check topic existence before replication factor

2019-09-04 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8875: -- Summary: CreateTopic API should check topic existence before replication factor Key: KAFKA-8875 URL: https://issues.apache.org/jira/browse/KAFKA-8875 Project

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Jason Gustafson
Hi Colin, Just a couple questions. 1. I think we discussed that we would do a lazy version bump of all protocols in order to get flexible version support. Can you add that to the KIP? 2. The doc mentions a bump to the request and response header formats to version 1. Currently there is no formal

[jira] [Created] (KAFKA-8845) Detect and abort stalled transactions

2019-08-28 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8845: -- Summary: Detect and abort stalled transactions Key: KAFKA-8845 URL: https://issues.apache.org/jira/browse/KAFKA-8845 Project: Kafka Issue Type

[jira] [Created] (KAFKA-8844) Add max lso lag metric

2019-08-28 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8844: -- Summary: Add max lso lag metric Key: KAFKA-8844 URL: https://issues.apache.org/jira/browse/KAFKA-8844 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-8841) Optimize Partition.maybeIncrementLeaderHW

2019-08-27 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8841: -- Summary: Optimize Partition.maybeIncrementLeaderHW Key: KAFKA-8841 URL: https://issues.apache.org/jira/browse/KAFKA-8841 Project: Kafka Issue Type

Re: [DISCUSS] KIP-360: Improve handling of unknown producer

2019-08-27 Thread Jason Gustafson
rted; some others (INVALID_PRODUCER_EPOCH) would cause the producer to > enter the FATAL_ERROR state, plus it would cause all future txns to be > aborted. > > Is that right? > > > Guozhang > > > On Wed, Aug 21, 2019 at 3:52 PM Matthias J. Sax > wrote: > > >

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-08-26 Thread Jason Gustafson
to it. It will > give brokers multiple ways of changing log levels. and there is still a > consistent way of achieving cross component goals of the KIP. > > Best, > > > On Fri, Aug 23, 2019 at 4:12 PM Jason Gustafson > wrote: > > > Let me elaborate a little bit. W

[jira] [Created] (KAFKA-8836) Add inter-broker protocol to alter ISR

2019-08-26 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8836: -- Summary: Add inter-broker protocol to alter ISR Key: KAFKA-8836 URL: https://issues.apache.org/jira/browse/KAFKA-8836 Project: Kafka Issue Type

[jira] [Created] (KAFKA-8835) Update documentation for URP changes in KIP-352

2019-08-26 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8835: -- Summary: Update documentation for URP changes in KIP-352 Key: KAFKA-8835 URL: https://issues.apache.org/jira/browse/KAFKA-8835 Project: Kafka Issue Type

[jira] [Created] (KAFKA-8834) Distinguish URPs caused by reassignment plus other metrics

2019-08-26 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8834: -- Summary: Distinguish URPs caused by reassignment plus other metrics Key: KAFKA-8834 URL: https://issues.apache.org/jira/browse/KAFKA-8834 Project: Kafka

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-08-26 Thread Jason Gustafson
Closing this vote. The final result is +9 with 4 binding votes. @Satish Sorry, I missed your question above. Good point about updating documentation. I will create a separate jira to make sure this gets done. -Jason On Fri, Aug 23, 2019 at 11:23 AM Jason Gustafson wrote: > Thanks Stan, g

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-08-23 Thread Jason Gustafson
lly turn off in Kafka. Now that we have a proper API with support in the AdminClient, we can deprecate and eventually remove the JMX endpoint. Thanks, Jason On Fri, Aug 23, 2019 at 10:49 AM Jason Gustafson wrote: > Hi Arjun, > > Thanks for the KIP. Do we really need a JMX-based API? Is

[jira] [Resolved] (KAFKA-8753) Add JMX for number of topics marked for deletion

2019-08-23 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8753. Fix Version/s: 2.4.0 Resolution: Fixed > Add JMX for number of topics marked

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-08-23 Thread Jason Gustafson
, and calculate the URPs based > on that. +1 for this. (I assume Jason will update the KIP...) > > best, > Colin > > > > > > Taking that into account, +1 from me! (non-binding) > > > > On Fri, Aug 23, 2019 at 7:00 PM Colin McCabe wrote: > > > &g

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-08-23 Thread Jason Gustafson
Hi Arjun, Thanks for the KIP. Do we really need a JMX-based API? Is there literally anyone in the world that wants to use JMX if they don't have to? I thought one of the major motivations of KIP-412 was how much of a pain JMX is. Thanks, Jason On Mon, Aug 19, 2019 at 5:28 PM Arjun Satish wrote:

[jira] [Resolved] (KAFKA-8325) Remove from the incomplete set failed. This should be impossible

2019-08-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8325. Fix Version/s: 2.3.1 Resolution: Fixed > Remove from the incomplete set fai

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-08-21 Thread Jason Gustafson
e exposed to users) for > future > >> developers, how about rename it to "required_epoch" and if it is set to > >> "-1" it means "not required, hence not checks"? > >> > >> Guozhang > >> > >> On T

Re: [DISCUSS] KIP-360: Improve handling of unknown producer

2019-08-21 Thread Jason Gustafson
-1. > 2. Epoch and producerId are provided >a) the provided producerId/epoch matches the current producerId/epoch: > i) if the epoch is not exhausted, bump the epoch > ii) if the epoch is exhausted, create a new PID with epoch=0 >b) the provided producerId/epoch m

[jira] [Created] (KAFKA-8825) Add option to reset consumer offset by relative time

2019-08-21 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-8825: -- Summary: Add option to reset consumer offset by relative time Key: KAFKA-8825 URL: https://issues.apache.org/jira/browse/KAFKA-8825 Project: Kafka Issue

Re: [VOTE] KIP-497: Add inter-broker API to alter ISR

2019-08-20 Thread Jason Gustafson
ng AlterIsrRequest from a broker to the controller (at least for a > given partition) in order to set CurrentZkVersion properly? > > Jun > > On Tue, Aug 20, 2019 at 10:07 AM Jason Gustafson > wrote: > > > I'm going to close this vote. The final result is +5 with 3 bind

Re: [VOTE] KIP-499 - Unify connection name flag for command line tool

2019-08-20 Thread Jason Gustafson
+1 Thanks for the KIP! -Jason On Thu, Aug 15, 2019 at 4:01 AM Jakub Scholz wrote: > +1 (non-binding) > > Jakub > > On Sat, Aug 10, 2019 at 8:34 PM Stanislav Kozlovski < > stanis...@confluent.io> > wrote: > > > Awesome KIP, +1 (non-binding) > > > > Thanks, > > Stanislav > > > > On Fri, Aug 9, 20

[VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-08-20 Thread Jason Gustafson
Hi All, I'd like to start a vote on KIP-352, which is a follow-up to KIP-455 to fix a long-known shortcoming of URP reporting and to improve reassignment monitoring: https://cwiki.apache.org/confluence/display/KAFKA/KIP-352%3A+Distinguish+URPs+caused+by+reassignment . Note that I have added one n

Re: [VOTE] KIP-497: Add inter-broker API to alter ISR

2019-08-20 Thread Jason Gustafson
, I'm actually fine to name it > more > > > generally and leave a note that at the moment its value is defined as > the > > > zk version. > > > > > > > > > Guozhang > > > > > > > > > On Mon, Aug 12, 2019 at 2:22 PM Ja

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-15 Thread Jason Gustafson
t this? > > +1 (binding) > > best, > Colin > > > On Mon, Aug 12, 2019, at 10:57, Guozhang Wang wrote: > > +1 (binding). > > > > Thanks Jason! > > > > On Wed, Aug 7, 2019 at 11:18 AM Jason Gustafson > wrote: > > > > > Hi All, >

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-14 Thread Jason Gustafson
to call > OnPartitionsAssigned() > > or > > > OnPartitionsRevoked() with each rebalance. Our requirement is to be > > > up-to-date with group metadata such as generation information, so > > callback > > > like onGroupJoined() would make more sense as

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-13 Thread Jason Gustafson
ual work) Yeah, that makes sense. Maybe we can include the version bump for all RPCs in this KIP, but we can implement it lazily as the protocols are converted. -Jason On Mon, Aug 12, 2019 at 7:16 PM Colin McCabe wrote: > On Mon, Aug 12, 2019, at 11:22, Jason Gustafson wrote: > &

Re: [VOTE] KIP-497: Add inter-broker API to alter ISR

2019-08-12 Thread Jason Gustafson
new protocol we could perhaps rename > CurrentZkVersion to something like "IsrEpoch" or "IsrVersion". I think > that'd reflect its purpose better. > > Best, > Viktor > > On Wed, Aug 7, 2019 at 8:37 PM Jason Gustafson wrote: > > > Hi All, > > > &

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-12 Thread Jason Gustafson
e > `onGroupMetadataUpdated(ConsumerGroupMetadata metadata)` > > To simplify the code logic, we believe option 3 & 4 are better solutions, > and of which I slightly prefer option 4 as it is the most clean solution > with less intrusion to both consumer and producer APIs. &g

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-12 Thread Jason Gustafson
Hi Colin, Thanks for the KIP! This is a significant improvement. One of my personal interests in this proposal is solving the compatibility problems we have with the internal schemas used to define consumer offsets and transaction metadata. Currently we have to guard schema bumps with the inter-br

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-08 Thread Jason Gustafson
@Dongjin Thanks, you raise some good points. I think the intent here is to try and fix one of the more egregious inconsistencies without increasing the scope too much. We tried the big KIP approach with KIP-14 before and I don't think we made much progress. I think it's reasonable to do this on a c

Re: KIP-352: Distinguish URPs caused by reassignment

2019-08-08 Thread Jason Gustafson
could cause confusion. Just adding a new metric sounds good to me! > > The throttle follow-up is mentioned as part of future work in KIP-455 and I > agree that it is way out of scope for this one. > > > On Thu, Aug 8, 2019 at 8:03 PM Jason Gustafson wrote: > > > Hi St

Re: KIP-352: Distinguish URPs caused by reassignment

2019-08-08 Thread Jason Gustafson
c to > distringuish between reassigning/non-reassigning traffic, or do you prefer > to keep this KIP nice and small? > > On Thu, Aug 8, 2019 at 12:08 AM Jason Gustafson > wrote: > > > Hi All, > > > > Since KIP-455 is passed, I would like to revive this proposal. I ha

<    3   4   5   6   7   8   9   10   11   12   >