Re: [VOTE] KIP-280: Enhanced log compaction

2018-06-15 Thread Luis Cabral
Hi, bq. Can the value be determined now ? My thinking is that what if there is a third compaction strategy proposed in the future ? We should guard against user unknowingly choosing the 'future' strategy. The idea is that the header name to use is flexible, which protects current clients that

[jira] [Created] (KAFKA-7061) Enhanced log compaction

2018-06-15 Thread Luis Cabral (JIRA)
Luis Cabral created KAFKA-7061: -- Summary: Enhanced log compaction Key: KAFKA-7061 URL: https://issues.apache.org/jira/browse/KAFKA-7061 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-24 Thread Luis Cabral
Hi Jun / Ismael, Any chance to get your opinion on this? Thanks in advance! Regards, Luís > On 22 May 2018, at 17:30, Guozhang Wang wrote: > > Hello Luís, > > While reviewing your PR I realized my previous calculation on the memory > usage was incorrect: in fact, in the

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-24 Thread Luis Cabral
Hi Guozhang, I mean here: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/OffsetMap.scala It seems that this class was designed with a great focus on preventing memory starvation, and this class is also very central to the changes required for this KIP. So far this