[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

2015-07-27 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Status: Patch Available (was: Open) > Add a request timeout to NetworkCli

Review Request 36858: Patch for KAFKA-2120

2015-07-27 Thread Mayuresh Gharat
nals/SenderTest.java 8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

2015-07-27 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643399#comment-14643399 ] Mayuresh Gharat commented on KAFKA-2120: Created reviewboard h

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-27 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643065#comment-14643065 ] Mayuresh Gharat commented on KAFKA-2260: I think, when 2 producers are tryin

Re: New Producer and "acks" configuration

2015-07-27 Thread Mayuresh Gharat
So basically this means that with acks = 0, their is no guarantee that the message has been received by Kafka broker. I am just wondering, why would anyone be using acks = 0, since anyone using kafka and doing producer.send() would want that, their message got to kafka brokers. Also as Jay said, wi

Re: Query about LogConfigs

2015-07-24 Thread Mayuresh Gharat
>millisInMinute * props.getIntInRange("log.retention.minutes", (1, > Int.MaxValue)) > } > else { >millisInHour * props.getIntInRange("log.retention.hours", 24*7, (1, > Int.MaxValue)) > } > } > > On Fri, Jul 24, 2015 at 9:18

Re: Query about LogConfigs

2015-07-24 Thread Mayuresh Gharat
; >> At least the "ms" one is fairly new, and I think we left the others to > >> avoid break configuration during upgrade. > >> > >> On Fri, Jul 24, 2015 at 6:34 PM, Mayuresh Gharat > >> wrote: > >> > I was thinking why we have 3 different c

Re: Query about LogConfigs

2015-07-24 Thread Mayuresh Gharat
gt; At least the "ms" one is fairly new, and I think we left the others to > avoid break configuration during upgrade. > > On Fri, Jul 24, 2015 at 6:34 PM, Mayuresh Gharat > wrote: > > I was thinking why we have 3 different configs for the same property (log > >

Query about LogConfigs

2015-07-24 Thread Mayuresh Gharat
I was thinking why we have 3 different configs for the same property (log retention) : "log.retention.ms" "log.retention.minutes" "log.retention.hours" Why don't we only use the Milliseconds? There are other properties as well like log Jitter, LogRollTime which raise the same question in my mind

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-24 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641009#comment-14641009 ] Mayuresh Gharat commented on KAFKA-2351: Hi [~junrao], Thanks for the comment

Re: Kafka High level consumer rebalancing

2015-07-24 Thread Mayuresh Gharat
me consumer die? > > Thanks > -Pranay > > On Tue, Jul 21, 2015 at 11:25 AM, Mayuresh Gharat < > gharatmayures...@gmail.com> wrote: > > > Not sure if you can do that with High level consumer. > > > > Thanks, > > > > Mayuresh > > > &g

Re: Review Request 36652: Patch for KAFKA-2351

2015-07-24 Thread Mayuresh Gharat
e jira ticket. Was just curious if we can do the same there as well. We are catching all the Throwables and allowing the thread to continue processing. Is there something I am missing here. - Mayuresh Gharat On July 24, 2015, 4:36 a.m., Mayuresh Gharat

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639910#comment-14639910 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard h

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-07-23_21:36:52.patch > Brokers are having a problem shutting d

Re: Review Request 36652: Patch for KAFKA-2351

2015-07-23 Thread Mayuresh Gharat
91319fa010b140cca632e5fa8050509bd2295fc9 Diff: https://reviews.apache.org/r/36652/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639097#comment-14639097 ] Mayuresh Gharat commented on KAFKA-2351: Hi [~ijuma], thanks a lot for poin

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-22 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638076#comment-14638076 ] Mayuresh Gharat commented on KAFKA-2351: [~junrao], [~guozhang] can you ta

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-07-21_14:58:13.patch > Brokers are having a problem shutting d

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635885#comment-14635885 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard h

Re: Review Request 36652: Patch for KAFKA-2351

2015-07-21 Thread Mayuresh Gharat
: https://reviews.apache.org/r/36652/diff/ Testing --- Thanks, Mayuresh Gharat

Re: Submitting a patch (Jira errors)

2015-07-21 Thread Mayuresh Gharat
Resolved this. Thanks, Mayuresh On Tue, Jul 21, 2015 at 12:59 PM, Mayuresh Gharat < gharatmayures...@gmail.com> wrote: > Yes. > > Thanks, > > Mayuresh > > On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > >&

Re: Review Request 36652: Patch for KAFKA-2351

2015-07-21 Thread Mayuresh Gharat
on was thrown when we pass it to error() - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92470 --- On July 21,

Re: Review Request 36652: Patch for KAFKA-2351

2015-07-21 Thread Mayuresh Gharat
On July 21, 2015, 8:18 p.m., Mayuresh Gharat wrote: > > T Yes. Got it, I thought that we should be catching all exceptions and exit. But doing the above will catch the exception and exit when its shutting down and thats the only thing that this ticket considers. - Ma

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635734#comment-14635734 ] Mayuresh Gharat commented on KAFKA-2351: Created reviewboard h

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351.patch > Brokers are having a problem shutting down correc

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-21 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Status: Patch Available (was: Open) > Brokers are having a problem shutting down correc

Review Request 36652: Patch for KAFKA-2351

2015-07-21 Thread Mayuresh Gharat
--- Thanks, Mayuresh Gharat

Re: Submitting a patch (Jira errors)

2015-07-21 Thread Mayuresh Gharat
Yes. Thanks, Mayuresh On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Did you setup your jira.ini? > > On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat < > gharatmayures...@gmail.com> wrote: > > > Hi, > > &g

Submitting a patch (Jira errors)

2015-07-21 Thread Mayuresh Gharat
Hi, I had to clean up existing kafka repo on my linux box and start with a fresh one. I followed the instructions here : https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review I am trying to upload a patch and I am getting these errors : Configuring reviewboard url to ht

Re: Kafka High level consumer rebalancing

2015-07-21 Thread Mayuresh Gharat
Not sure if you can do that with High level consumer. Thanks, Mayuresh On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal wrote: > Any ideas? > > On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal > wrote: > > > Hi all, > > > > Is there any way I can force Zookeeper/Kafka to rebalance new consumer

[jira] [Created] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-07-20 Thread Mayuresh Gharat (JIRA)
Mayuresh Gharat created KAFKA-2351: -- Summary: Brokers are having a problem shutting down correctly Key: KAFKA-2351 URL: https://issues.apache.org/jira/browse/KAFKA-2351 Project: Kafka Issue

Re: Permission to edit KIP pages

2015-07-20 Thread Mayuresh Gharat
Thanks Jun. Thanks, Mayuresh On Mon, Jul 20, 2015 at 10:03 AM, Jun Rao wrote: > Added. > > Thanks, > > Jun > > On Mon, Jul 20, 2015 at 9:48 AM, Mayuresh Gharat < > gharatmayures...@gmail.com > > wrote: > > > My username is : mgharat > > >

Re: Permission to edit KIP pages

2015-07-20 Thread Mayuresh Gharat
My username is : mgharat On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat wrote: > Hi, > > I wanted to edit a KIP page and would like to get permission for that. > Currently I don't have edit authorization. It does not show me an option to > edit. > > Can one

Permission to edit KIP pages

2015-07-20 Thread Mayuresh Gharat
Hi, I wanted to edit a KIP page and would like to get permission for that. Currently I don't have edit authorization. It does not show me an option to edit. Can one of the committers grant me permission? Thanks. -- -Regards, Mayuresh R. Gharat (862) 250-7125

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-07-17 Thread Mayuresh Gharat
If we have 2 producers producing to a partition, they can be out of order, then how does one producer know what offset to expect as it does not interact with other producer? Can you give an example flow that explains how it works with single producer and with multiple producers? Thanks, Mayures

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-16 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629988#comment-14629988 ] Mayuresh Gharat commented on KAFKA-1835: I had a concern here, what happen

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627263#comment-14627263 ] Mayuresh Gharat commented on KAFKA-1835: Either way user will have to bloc

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2015-07-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624933#comment-14624933 ] Mayuresh Gharat commented on KAFKA-1788: Hi [~parth.brahmbhatt], this is

Re: Review Request 36345: Patch for KAFKA-2322

2015-07-10 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36345/#review91324 --- Ship it! Ship It! - Mayuresh Gharat On July 9, 2015, 9:05 a.m

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

2015-06-22 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596265#comment-14596265 ] Mayuresh Gharat commented on KAFKA-2120: Hi [~jasong35], we have began wor

[jira] [Comment Edited] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593812#comment-14593812 ] Mayuresh Gharat edited comment on KAFKA-2012 at 6/19/15 7:3

[jira] [Commented] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593812#comment-14593812 ] Mayuresh Gharat commented on KAFKA-2012: Discussed this with [~jjkoshy].

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-10 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580837#comment-14580837 ] Mayuresh Gharat commented on KAFKA-2253: Thanks [~guozhang] for this patc

[jira] [Commented] (KAFKA-2160) DelayedOperationPurgatory should remove the pair in watchersForKey with empty watchers list

2015-06-05 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575390#comment-14575390 ] Mayuresh Gharat commented on KAFKA-2160: We hit a deadlock while running bro

[jira] [Created] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-05 Thread Mayuresh Gharat (JIRA)
Mayuresh Gharat created KAFKA-2253: -- Summary: Deadlock in delayed operation purgatory Key: KAFKA-2253 URL: https://issues.apache.org/jira/browse/KAFKA-2253 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Mayuresh Gharat
+1 (non-binding). Thanks Jiangjie. Thanks, Mayuresh On Tue, Jun 2, 2015 at 4:49 PM, Ewen Cheslack-Postava wrote: > +1 non-binding. Thanks for all the work on this Jiangjie! > > Aditya -- see discussion of partitionsFor() API, which needs to also use > one of those timeouts, and is a fetch rat

Re: KIP Wiki

2015-06-01 Thread Mayuresh Gharat
+1. Thanks, Mayuresh On Mon, Jun 1, 2015 at 6:51 PM, Joe Stein wrote: > We should probably have some release/vXYZ section so that over time we can > keep track of what KIP where approved for what release, etc/ > > Anything not in a release folder (we could do now release/v0.8.3.0 for > everyth

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-21 Thread Mayuresh Gharat
config in the producer to control whether > TopicCreateRequest should be issued or not on UnknownTopicException. If > this is disabled and the topic doesn't exist, send will fail and the user > is expected to create the topic manually. > > Thanks, > > Jun > > > On

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-21 Thread Mayuresh Gharat
Hi, I had a question about TopicMetadata Request. Currently the way it works is : 1) Suppose a topic T1 does not exist. 2) Client wants to produce data to T1 using producer P1. 3) Since T1 does not exist, P1 issues a TopicMetadata request to kafka. This in turn creates the default number of partit

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-19 Thread Mayuresh Gharat
quest.timeout* is the bound on the time after send() complete until > you > > >get an acknowledgement. This covers the connection timeout, and the time > > >in > > >the accumulator. So to implement this, the time we set in the request > sent > > >via N

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-19 Thread Mayuresh Gharat
include both the time in > >the accumulator an the time taken for the first request, etc. In other > >words this is the upper bound on the time to the Future being satisfied. > > > >*replication.timeout* will default to something reasonable but maybe you > >can override

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-19 Thread Mayuresh Gharat
M, Jiangjie Qin > >> > >> wrote: > >> > >>> I modified the WIKI page to incorporate the feedbacks from mailing list > >>> and KIP hangout. > >>> > >>> - Added the deprecation plan for TIMEOUT_CONFIG > >>> - Added t

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-19 Thread Mayuresh Gharat
d not see many new connections > > get created. > > 2. If a broker is down, hopefully metadata refresh will find the new > > broker and we will not try to reconnect to the broker anymore. > > > > Comments are welcome! > > > > Thanks. > > > > Jiang

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-15 Thread Mayuresh Gharat
t; 2. If a broker is down, hopefully metadata refresh will find the new > broker and we will not try to reconnect to the broker anymore. > > Comments are welcome! > > Thanks. > > Jiangjie (Becket) Qin > > On 5/12/15, 2:59 PM, "Mayuresh Gharat" wrote: > > >

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-12 Thread Mayuresh Gharat
+1 Becket. That would give enough time for clients to move. We should make this change very clear. Thanks, Mayuresh On Tue, May 12, 2015 at 1:45 PM, Jiangjie Qin wrote: > Hey Ewen, > > Very good summary about the compatibility. What you proposed makes sense. > So basically we can do the follow

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-05-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540270#comment-14540270 ] Mayuresh Gharat commented on KAFKA-1554: This sounds interesting. We may tr

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-05-05 Thread Mayuresh Gharat
Just a quick question, can we handle REQUEST TIMEOUT as disconnections and do a fresh MetaDataRequest and retry instead of failing the request? Thanks, Mayuresh On Mon, May 4, 2015 at 10:32 AM, Jiangjie Qin wrote: > I incorporated Ewen and Guozhang’s comments in the KIP page. Want to speed >

[jira] [Commented] (KAFKA-2024) Cleaner can generate unindexable log segments

2015-04-20 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503401#comment-14503401 ] Mayuresh Gharat commented on KAFKA-2024: Shouldn't the offsetIndex.sca

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-17 Thread Mayuresh Gharat
Agreed we also need to change in the code of Sender.java to indicate that it resembles REPLICATION_TIMEOUT and not the request Timeout. Thanks, Mayuresh On Thu, Apr 16, 2015 at 1:08 PM, Jiangjie Qin wrote: > Hi Guozhang, > > By implicit timeout for close() and flush(), I meant that currently w

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-14 Thread Mayuresh Gharat
I suppose adding this timeout will help. In cases were the broker is not completely down but stops responding to the produce request, tools like Mirror Makers will hang since they are waiting for responses. Adding this timeout enables it to fail the current request and retry with fresh metadata. T

[jira] [Assigned] (KAFKA-2120) Add a request timeout to NetworkClient

2015-04-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-2120: -- Assignee: Mayuresh Gharat > Add a request timeout to NetworkCli

Re: [jira] [Issue Comment Deleted] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2015-03-30 Thread Mayuresh Gharat
You can take a look at this : https://issues.apache.org/jira/browse/KAFKA-1848 Thanks, Mayuresh On Sun, Mar 29, 2015 at 4:45 PM, Jiangjie Qin (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > J

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-25 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/#review77787 --- Ship it! - Mayuresh Gharat On March 25, 2015, 6:29 p.m., Grant

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-25 Thread Mayuresh Gharat
> On March 25, 2015, 4:48 p.m., Mayuresh Gharat wrote: > > examples/src/main/java/kafka/examples/Producer.java, line 56 > > <https://reviews.apache.org/r/31369/diff/6/?file=884185#file884185line56> > > > > messageNo++ can be outside the if-else block and us

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-25 Thread Mayuresh Gharat
tps://reviews.apache.org/r/31369/#comment125947> messageNo++ can be outside the if-else block and used once. - Mayuresh Gharat On March 4, 2015, 1:51 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail.

[jira] [Commented] (KAFKA-2038) Unable to restart brokers after it went down with no space left on disk

2015-03-25 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380190#comment-14380190 ] Mayuresh Gharat commented on KAFKA-2038: I suppose this will involve ma

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Mayuresh Gharat
> On March 24, 2015, 5 p.m., Mayuresh Gharat wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 134 > > <https://reviews.apache.org/r/32440/diff/1/?file=904417#file904417line134> > > > > Since its a Produ

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Mayuresh Gharat
/KafkaProducer.java <https://reviews.apache.org/r/32440/#comment125718> Since its a Producer level config, is this change needed. We can keep it as an instance variable. Also since the compression type does not change, the "private final" makes it more clear. What do you think? - Mayu

Review Request 32422: Patch for KAFKA-1554

2015-03-23 Thread Mayuresh Gharat
--- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377009#comment-14377009 ] Mayuresh Gharat commented on KAFKA-1554: Created reviewboard h

[jira] [Updated] (KAFKA-1554) Corrupt index found on clean startup

2015-03-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1554: --- Status: Patch Available (was: Open) > Corrupt index found on clean star

[jira] [Updated] (KAFKA-1554) Corrupt index found on clean startup

2015-03-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1554: --- Attachment: KAFKA-1554.patch > Corrupt index found on clean star

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-03-19 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370426#comment-14370426 ] Mayuresh Gharat commented on KAFKA-1778: I did not get : c) Broker x

Re: Review Request 32199: Patch for KAFKA-1858

2015-03-19 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32199/#review77060 --- LGTM - Mayuresh Gharat On March 18, 2015, 11:12 a.m., Adrian

Re: Broker is not aware of new partitions assigned

2015-03-17 Thread Mayuresh Gharat
the watcher is still alive. The log in the controller indicates that > it observed the changes. > > > On Tue, Mar 17, 2015 at 2:05 PM, Mayuresh Gharat < > gharatmayures...@gmail.com > > wrote: > > > I think the way reassignment works is asynchronous. Changes are mad

[jira] [Issue Comment Deleted] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-03-17 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1860: --- Comment: was deleted (was: We need to reproduce and test the fix on our kafka server mp

Re: Broker is not aware of new partitions assigned

2015-03-17 Thread Mayuresh Gharat
I think the way reassignment works is asynchronous. Changes are made to zookeeper but those changes get reflected only when controller watcher fires for the respective zookeeper path. Is your watcher still alive? Thanks, Mayuresh On Tue, Mar 17, 2015 at 1:29 PM, Allen Wang wrote: > Looking a b

[jira] [Commented] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-03-17 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366088#comment-14366088 ] Mayuresh Gharat commented on KAFKA-1860: We need to reproduce and test the fi

[jira] [Updated] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-03-17 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1860: --- Status: Patch Available (was: Open) > File system errors are not detected unless Kafka tr

[jira] [Commented] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-03-17 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366069#comment-14366069 ] Mayuresh Gharat commented on KAFKA-1860: Created reviewboard h

Review Request 32172: Patch for KAFKA-1860

2015-03-17 Thread Mayuresh Gharat
/ Testing --- Thanks, Mayuresh Gharat

[jira] [Updated] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-03-17 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1860: --- Attachment: KAFKA-1860.patch > File system errors are not detected unless Kafka tries

[jira] [Assigned] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1554: -- Assignee: Mayuresh Gharat > Corrupt index found on clean star

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361309#comment-14361309 ] Mayuresh Gharat commented on KAFKA-1554: I can take a shot at this

[jira] [Comment Edited] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361306#comment-14361306 ] Mayuresh Gharat edited comment on KAFKA-1554 at 3/13/15 11:2

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2015-03-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361306#comment-14361306 ] Mayuresh Gharat commented on KAFKA-1554: So in this case we should be dele

[jira] [Created] (KAFKA-2014) Chaos Monkey / Failure Inducer for Kafka

2015-03-11 Thread Mayuresh Gharat (JIRA)
Mayuresh Gharat created KAFKA-2014: -- Summary: Chaos Monkey / Failure Inducer for Kafka Key: KAFKA-2014 URL: https://issues.apache.org/jira/browse/KAFKA-2014 Project: Kafka Issue Type: Task

[jira] [Commented] (KAFKA-1998) Partitions Missing From MetadataResponse

2015-03-04 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347645#comment-14347645 ] Mayuresh Gharat commented on KAFKA-1998: I suppose what we need to do is

Re: Review Request 31306: Patch for KAFKA-1755

2015-03-03 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74992 --- Ship it! Ship It! - Mayuresh Gharat On Feb. 26, 2015, 6:54 p.m

Re: Review Request 31306: Patch for KAFKA-1755

2015-03-03 Thread Mayuresh Gharat
tps://reviews.apache.org/r/31306/#comment121866> This will mean that if there are unkeyed messages we will neglect them and not throw an exception right? So we are aloowing unkeyed messages to go through comapction. - Mayuresh Gharat On Feb. 26, 2015, 6:54 p.m., Joel Koshy

[jira] [Assigned] (KAFKA-1998) Partitions Missing From MetadataResponse

2015-03-02 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1998: -- Assignee: Mayuresh Gharat > Partitions Missing From MetadataRespo

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-23 Thread Mayuresh Gharat
<https://reviews.apache.org/r/31306/#comment120016> We may also need to check this right: sourceCodec != NoCompressionCodec - Mayuresh Gharat On Feb. 23, 2015, 2:43 p.m., Joel Koshy wrote: > > --- > This is an automatica

[jira] [Commented] (KAFKA-1796) Sanity check partition command line tools

2015-02-23 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333536#comment-14333536 ] Mayuresh Gharat commented on KAFKA-1796: [~nehanarkhede] Sure. Actually I

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-17 Thread Mayuresh Gharat
reviews that I got. core/src/main/scala/kafka/tools/ContinuousValidationTest.java <https://reviews.apache.org/r/30809/#comment118893> Are you assuming that first argument will be some key? core/src/main/scala/kafka/tools/ContinuousValidationTest.java <https://reviews.apache.org/r

[jira] [Comment Edited] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319346#comment-14319346 ] Mayuresh Gharat edited comment on KAFKA-1796 at 2/13/15 1:0

[jira] [Commented] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319346#comment-14319346 ] Mayuresh Gharat commented on KAFKA-1796: [~nehanarkhede], I went over KAFKA-

[jira] [Assigned] (KAFKA-1796) Sanity check partition command line tools

2015-02-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1796: -- Assignee: Mayuresh Gharat > Sanity check partition command line to

[jira] [Assigned] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-01-28 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1860: -- Assignee: Mayuresh Gharat (was: Guozhang Wang) > File system errors are not detec

[jira] [Commented] (KAFKA-853) Allow OffsetFetchRequest to initialize offsets

2015-01-20 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285162#comment-14285162 ] Mayuresh Gharat commented on KAFKA-853: --- Hi Balaji Seshadri, I am tryin

Re: Review Request 25944: Patch for KAFKA-1013

2015-01-13 Thread Mayuresh Gharat
41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat

<    1   2   3   4   5   6   7   >