Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-22 Thread Tong Li
to be totally different things. Then it will be really needed. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Jeff Holoman jholo...@cloudera.com To: dev@kafka.apache.org Cc: Tom Graves tgraves...@yahoo.com Date: 04/22/2015 02:40 PM Subject

Re: KIP hangout on Apr 21

2015-04-21 Thread Tong Li
Jun, Not sure why in these invitations, I am not seeing the google hangout link. I am using IBM notes which is quite different from gmail and calendar. Is there anyway that you send the hangout link in the invitation body? Thanks. Tong Li OpenStack Kafka Community Development Building 501

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-15 Thread Tong Li
Parth, If one wants to use his or her own access control including authentication system, with this design what will be needed to be done? Can one completely turn this off so that the system behaves exactly same as it is today? Thanks. Tong Sent from my iPhone On Apr 15, 2015, at 1:51

Re: Will it be possible to apply quotas based on a security principal?

2015-04-15 Thread Tong Li
If it is all possible I think we can introduce request pipeline architecture for producer, broker and consumer (does not have to be done all at once), that way, security, quota, encryption, serialization, compression all can be done as plugable components. One can freely stack them up or tear

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-07 Thread Tong Li
see some response inline below. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com Jay Kreps jay.kr...@gmail.com wrote on 04/07/2015 10:41:19 AM: From: Jay Kreps jay.kr...@gmail.com To: dev@kafka.apache.org dev@kafka.apache.org Date: 04/07/2015 10:44 AM

Re: KIP discussion Apr 7 at 11am PST

2015-04-07 Thread Tong Li
Jun Rao, Can you include the hangout link in the invitation? I could not find it anywhere. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Jun Rao j...@confluent.io To: dev@kafka.apache.org dev@kafka.apache.org Date: 04/03/2015

Re: [jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-06 Thread Tong Li
Run Rao, Thanks for reviewing it again. What commands do you run to show unused imports? When I run grandle --daemon test, it did not show these (there were some warnings, but not unused imports). I thought that would have shown these things. Tong Li OpenStack Kafka Community Development

Re: Review Request 32740: Patch for KAFKA-1926

2015-04-05 Thread Tong Li
1d87506649f0d1f73a2ea5465339dc586900b626 core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala fedefb5287eaf8e0d1ee585a8dd31687bdcf9d88 Diff: https://reviews.apache.org/r/32740/diff/ Testing --- Thanks, Tong Li

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-05 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926_2015-04-05_23:45:13.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-05 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14480907#comment-14480907 ] Tong Li commented on KAFKA-1926: [~junrao] Jun, thanks again. Noticed you have done a lot

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-05 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14480906#comment-14480906 ] Tong Li commented on KAFKA-1926: Updated reviewboard https://reviews.apache.org/r/32740

Review request at https://reviews.apache.org/r/32740/

2015-04-03 Thread Tong Li
Jun and Jay, Have addressed all the comments and put up another patch set. Can you please take a look again? Really appreciate it. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

Re: Review request at https://reviews.apache.org/r/32740/

2015-04-03 Thread Tong Li
Thanks so much. New patch set come up after rebase. Sent from my iPhone On Apr 3, 2015, at 7:50 PM, Jun Rao j...@confluent.io wrote: Reviewed. Thanks, Jun On Fri, Apr 3, 2015 at 10:38 AM, Tong Li liton...@us.ibm.com wrote: Jun and Jay, Have addressed all the comments and put

Re: Kafka meetup at ApacheCon in Apr

2015-04-02 Thread Tong Li
? Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Jun Rao j...@confluent.io To: dev@kafka.apache.org dev@kafka.apache.org, us...@kafka.apache.org us...@kafka.apache.org, kafka-clie...@googlegroups.com kafka

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391999#comment-14391999 ] Tong Li commented on KAFKA-1926: [~junrao]Thanks so much for the quick review. All the new

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391990#comment-14391990 ] Tong Li commented on KAFKA-1926: Updated reviewboard https://reviews.apache.org/r/32740

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926_2015-04-01_22:16:46.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

Re: Review Request 32740: Patch for KAFKA-1926

2015-04-01 Thread Tong Li
67d9c4bab270c852dc05d47aaa4dd96b0f6039d4 Diff: https://reviews.apache.org/r/32740/diff/ Testing --- Thanks, Tong Li

Review Request 32740: Patch for KAFKA-1926

2015-04-01 Thread Tong Li
/32740/diff/ Testing --- Thanks, Tong Li

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391295#comment-14391295 ] Tong Li commented on KAFKA-1926: [~junrao], all comments have been addressed in the latest

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

Re: KIP discussion Mar 24 at 11am PST

2015-03-31 Thread Tong Li
Jun, I would like to participate but have not received the invite. Can you please send to me? Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Jun Rao j...@confluent.io To: dev@kafka.apache.org dev@kafka.apache.org Date: 03/27/2015

Re: Dropping support for Scala 2.9.x

2015-03-27 Thread Tong Li
+1. But can we also look at this from the deployment base point view and find out how many production deployments are still using 2.9? If there is not any, dropping it is really an easy decision. Thanks Sent from my iPhone On Mar 27, 2015, at 8:21 AM, Ismael Juma mli...@juma.me.uk wrote: Hi

java.net.BindException: Address already in use

2015-03-16 Thread Tong Li
Hi guys, when I ran test, I got a lot of these exceptions. I wonder if you had similar problems running the tests and how resolved the issue. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-03-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363164#comment-14363164 ] Tong Li commented on KAFKA-1926: @Jun Rao, awesome comments. I will be following

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

2015-03-12 Thread Tong Li
plugable and provide a default implementation which allows us try different solutions and also allow people to completely ignore it if they do not want to deal with any of these. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Guozhang Wang

Review Request 31844: Patch for KAFKA-1926

2015-03-08 Thread Tong Li
: https://reviews.apache.org/r/31844/diff/ Testing --- Thanks, Tong Li

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-03-08 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352488#comment-14352488 ] Tong Li commented on KAFKA-1926: Created reviewboard https://reviews.apache.org/r/31844

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-03-08 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

problems submitting patch set for review and a bit of solution

2015-03-08 Thread Tong Li
. cheers. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

Error when submit a patch set which contains a file rename.

2015-03-04 Thread Tong Li
wonder if it is because I do not have enough of permission? the file to be renamed is clearly there. Any help will be appreciated. Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-03-04 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348038#comment-14348038 ] Tong Li commented on KAFKA-1926: Jay, I finally put together a new patch set just

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

2015-03-04 Thread Tong Li
Todd, I think plugable design is good with solid default. The only issue I feel is when you use one and switch to another, will we end up with some unread messages hanging around and no one thinks or knows it is their responsibility to take care of them? Thanks. Tong Sent from my iPhone

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/ Tong, could you address Jun's last comments before committing? - Guozhang Wang On February 27th, 2015, 11:16 p.m. UTC, Tong Li wrote: Review request for kafka. By Tong Li. Updated Feb. 27, 2015, 11:16 p.m

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
://reviews.apache.org/r/31566/#review74973 --- On Feb. 27, 2015, 11:16 p.m., Tong Li wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-03 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988_2015-03-03_19:00:21.patch org.apache.kafka.common.utils.Utils.abs method returns

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-03 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346038#comment-14346038 ] Tong Li commented on KAFKA-1988: Updated reviewboard https://reviews.apache.org/r/31566

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
://reviews.apache.org/r/31566/diff/ Testing --- Thanks, Tong Li

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
Guozhang, Yes, I have rebased and updated the patch set to resolve the couple comments for code comments. Also removed the trailing spaces (which always annoying. :-) ), Please see the new patch set here. Sorry for the delay. https://reviews.apache.org/r/31566/ Thanks. Tong Li OpenStack

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-03 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988_2015-03-03_19:03:31.patch org.apache.kafka.common.utils.Utils.abs method returns

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-03 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346045#comment-14346045 ] Tong Li commented on KAFKA-1988: Updated reviewboard https://reviews.apache.org/r/31566

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
://reviews.apache.org/r/31566/diff/ Testing --- Thanks, Tong Li

Fwd: patch set 1988

2015-03-02 Thread Tong Li
/jira/browse/KAFKA-1988 The patch set https://reviews.apache.org/r/31566/diff/ Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-02 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343109#comment-14343109 ] Tong Li commented on KAFKA-1988: [~guozhang] Yes, the o.a.k.c.c.u.Utils.abs used in few

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988.patch org.apache.kafka.common.utils.Utils.abs method returns wrong value

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339921#comment-14339921 ] Tong Li commented on KAFKA-1988: Created reviewboard https://reviews.apache.org/r/31533

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339924#comment-14339924 ] Tong Li commented on KAFKA-1988: Jun Rao, Thanks for taking time reviewing

Re: [jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li
of abs method will point to the clients Utils.abs instead of two locations? Thanks. Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com Jun Rao (JIRA) j...@apache.org wrote on 02/27/2015 12:43:04 AM: From: Jun Rao (JIRA) j...@apache.org To: dev@kafka.apache.org

Review Request 31533: Patch for KAFKA-1988

2015-02-27 Thread Tong Li
://reviews.apache.org/r/31533/diff/ Testing --- Thanks, Tong Li

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340959#comment-14340959 ] Tong Li commented on KAFKA-1988: Run Rao, I got the point now. Thanks so much for your

Review Request 31566: Patch for KAFKA-1988

2015-02-27 Thread Tong Li
, Tong Li

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988.patch org.apache.kafka.common.utils.Utils.abs method returns wrong value

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-27 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341004#comment-14341004 ] Tong Li commented on KAFKA-1988: Created reviewboard https://reviews.apache.org/r/31566

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Status: Patch Available (was: Open) org.apache.kafka.common.utils.Utils.abs method returns wrong value

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988.patch org.apache.kafka.common.utils.Utils.abs method returns wrong value

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339478#comment-14339478 ] Tong Li commented on KAFKA-1988: Created reviewboard https://reviews.apache.org/r/31517

Review Request 31517: Patch for KAFKA-1988

2015-02-26 Thread Tong Li
/common/utils/UtilsTest.java 4c2ea34815b63174732d58b699e1a0a9e6ec3b6f Diff: https://reviews.apache.org/r/31517/diff/ Testing --- Thanks, Tong Li

[jira] [Created] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
Tong Li created KAFKA-1988: -- Summary: org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers. Key: KAFKA-1988 URL: https://issues.apache.org/jira/browse/KAFKA-1988 Project

Re: Tips for working with Kafka and data streams

2015-02-25 Thread Tong Li
, articles similar to the one linked in your original email can actually be submitted to developerworks, and you can get some money out of it if you like. If you do not know how to do that, I can certainly provide some pointers if you are interested. Thanks. Tong Li OpenStack Kafka Community

Re: Unit tests in java7 vs java8

2015-02-25 Thread Tong Li
think that error must be something related to my env. Here is my environment: Oracle JDK 7, gradle 2.2.1, scala 2.10.4. Lot of open file handles and big enough max lock memory, not complaining, just some observations in case you wonder what other developers may face. Thanks. Tong Li

Re: [jira] [Resolved] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-18 Thread Tong Li
KAFKA-1959. --- Resolution: Fixed Assignee: Tong Li Thanks for the patch - committed to trunk. Class CommitThread overwrite group of Thread class causing compile errors

two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Dear kafka developers, New to this community and put up two really small patch sets with open issues, can any one please review and comment and get them merged if all possible? Thanks https://reviews.apache.org/r/31097/ https://reviews.apache.org/r/31097/ Tong Li OpenStack Kafka

two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Dear kafka developers, New to this community and put up two really small patch sets with open issues, can any one please review and comment and get them merged if all possible? Thanks https://reviews.apache.org/r/31088/ https://reviews.apache.org/r/31097/ Tong Li OpenStack Community

Re: two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Gwen, Really appreciate it. Thanks so much. Anyone else please review them? Here are the links again. https://reviews.apache.org/r/31088/ https://reviews.apache.org/r/31097/ Tong Li OpenStack Community Development Building 501/B205 liton...@us.ibm.com From: Gwen Shapira gshap

Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 Diff: https://reviews.apache.org/r/31088/diff/ Testing --- Thanks, Tong Li

[jira] [Commented] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322966#comment-14322966 ] Tong Li commented on KAFKA-1959: Created reviewboard https://reviews.apache.org/r/31088

[jira] [Created] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
Tong Li created KAFKA-1959: -- Summary: Class CommitThread overwrite group of Thread class causing compile errors Key: KAFKA-1959 URL: https://issues.apache.org/jira/browse/KAFKA-1959 Project: Kafka

[jira] [Commented] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322933#comment-14322933 ] Tong Li commented on KAFKA-1959: Though I saw the error by using scala 2.10.4, I think

[jira] [Updated] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1959: --- Attachment: KAFKA-1959.patch Class CommitThread overwrite group of Thread class causing compile errors

Review Request 31097: Patch for KAFKA-1960

2015-02-16 Thread Tong Li
: https://reviews.apache.org/r/31097/diff/ Testing --- Thanks, Tong Li

[jira] [Commented] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323347#comment-14323347 ] Tong Li commented on KAFKA-1960: Created reviewboard https://reviews.apache.org/r/31097

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
from it can't use it) so there's no conflict here. Tong Li wrote: Thanks Gwen, completely agreed. What puzzled me is that the compile error. I do not know how to explain that. I have uploaded the screen shot of the error against the jira issue, I wonder if you can give a bit of opinion

[jira] [Updated] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-16 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1960: --- Attachment: KAFKA-1960.patch .gitignore does not exclude test generated files and folders

Review Request 31007: Patch for KAFKA-1926

2015-02-13 Thread Tong Li
/scala/unit/kafka/utils/TestUtils.scala 21d0ed2cb7c9459261d3cdc7c21dece5e2079698 Diff: https://reviews.apache.org/r/31007/diff/ Testing --- Thanks, Tong Li

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-13 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-13 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320416#comment-14320416 ] Tong Li commented on KAFKA-1926: [~jkreps] Removal of Time.scala cause a lot of code

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-13 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320404#comment-14320404 ] Tong Li commented on KAFKA-1926: Created reviewboard https://reviews.apache.org/r/31007

gradle testAll stuck

2015-02-12 Thread Tong Li
on my modest dev system. Wonder how you all run gradle and is there any specific settings needed? I am running it on Ubuntu 14.04. Any help or pointer is really appreciated. Thanks Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com

Re: gradle testAll stuck

2015-02-12 Thread Tong Li
Manikumar, yes, exactly the same issue. Commented on https://issues.apache.org/jira/browse/KAFKA-1948. Before this problem happens, the testAll normally still takes about half hour? Thanks Tong Li OpenStack Kafka Community Development Building 501/B205 liton...@us.ibm.com From: Manikumar

[jira] [Commented] (KAFKA-1948) kafka.api.consumerTests are hanging

2015-02-12 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318311#comment-14318311 ] Tong Li commented on KAFKA-1948: Pulled down the latest trunk and run into this problem

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-11 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316830#comment-14316830 ] Tong Li commented on KAFKA-1926: [~jkreps] Jay, really appreciate your quick review

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-11 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316380#comment-14316380 ] Tong Li commented on KAFKA-1926: [~harsha_ch]Yeah, will do that. Thanks. Replace

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Reviewer: Neha Narkhede Labels: newbie patch (was: newbie) Affects Version/s

Review Request 30844: Patch for KAFKA-1926

2015-02-10 Thread Tong Li
/src/test/scala/unit/kafka/utils/MockTime.scala ee65748afefd5e2d699e68fbd402b0ed9a659589 core/src/test/scala/unit/kafka/utils/TestUtils.scala c9e8ba257b77f46c5c9b62b451470348b6e58889 Diff: https://reviews.apache.org/r/30844/diff/ Testing --- Thanks, Tong Li

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314948#comment-14314948 ] Tong Li commented on KAFKA-1926: Created reviewboard https://reviews.apache.org/r/30845

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314962#comment-14314962 ] Tong Li commented on KAFKA-1926: [~harsha_ch], yes, new bee mistake. used the tool

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926-p1.patch This is the first attempt to fix the issue. Would like to get some reviews

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-10 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: (was: KAFKA-1926-p1.patch) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14313014#comment-14313014 ] Tong Li commented on KAFKA-1926: Jay. awesome comment, really appreciated. I will start

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312229#comment-14312229 ] Tong Li commented on KAFKA-1926: Jay, if you can provide a bit more direction, I would

[jira] [Commented] (KAFKA-1927) Replace requests in kafka.api with requests in org.apache.kafka.common.requests

2015-02-09 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312280#comment-14312280 ] Tong Li commented on KAFKA-1927: Gwen Shapira, indeed. I was doing OpenStack development

[jira] [Commented] (KAFKA-1756) never allow the replica fetch size to be less than the max message size

2015-02-02 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301373#comment-14301373 ] Tong Li commented on KAFKA-1756: I wonder if we really do need two parameters. Can't we

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2015-01-30 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299202#comment-14299202 ] Tong Li commented on KAFKA-1810: rather than add specific security measures, can we add