[GitHub] kafka pull request #4321: KAFKA-6342 : Move workaround for JSON parsing of n...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/4321 KAFKA-6342 : Move workaround for JSON parsing of non-escaped strings This PR moves the JSON parsing workaround of [this PR](https://github.com/apache/kafka/pull/4303) to new method and uses

[GitHub] kafka pull request #4259: KAFKA-5631 : Use Jackson for serialising to JSON

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/4259 KAFKA-5631 : Use Jackson for serialising to JSON This PR replaces the existing `Json.encode` to use Jackson serialization. Since the change is spread more than one module, it relies

[GitHub] kafka pull request #3946: KAFKA-5802 : ScramServerCallbackHandler#handle sho...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3946 KAFKA-5802 : ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get() Pretty trivial and tested with `gradle clean client:test` You can merge

[GitHub] kafka pull request #3727: KAFKA-5754 : Refactor Streams to use LogContext

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3727 KAFKA-5754 : Refactor Streams to use LogContext This PR utilizes `org.apache.kafka.common.utils.LogContext` for logging in `KafkaStreams`. @hachikuji, @ijuma please review this and let me know

[GitHub] kafka pull request #3489: KAFKA-5556 : KafkaConsumer.commitSync throws Illeg...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3489 KAFKA-5556 : KafkaConsumer.commitSync throws IllegalStateException: A… This PR makes `commitOffsetsSync` method check whether future is completed after client's poll or not. Tests

[GitHub] kafka pull request #2973: KAFKA-5171 : TC should not accept empty string tra...

Github user umesh9794 closed the pull request at: https://github.com/apache/kafka/pull/2973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3099: KAFKA-4660 : Improve test coverage KafkaStreams

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3099 KAFKA-4660 : Improve test coverage KafkaStreams @dguy , @mjsax Please review the PR and let me know your comments. You can merge this pull request into a Git repository by running: $ git

[GitHub] kafka pull request #3086: KAFKA-5171 : TC should not accept empty string tra...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/3086 KAFKA-5171 : TC should not accept empty string transactional id This a rebase version of [PR#2973](https://github.com/apache/kafka/pull/2973). @guozhangwang , please review this updated

[GitHub] kafka pull request #2973: Kafka 5171:TC should not accept empty string trans...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/2973 Kafka 5171:TC should not accept empty string transactional id This is an initial PR. Changed the unit tests accordingly as per the expectation from TC. You can merge this pull request into a Git

[GitHub] kafka pull request #2932: KAFKA-5137 : Controlled shutdown timeout message i...

GitHub user umesh9794 opened a pull request: https://github.com/apache/kafka/pull/2932 KAFKA-5137 : Controlled shutdown timeout message improvement This PR improves the warning message by adding correct config details. You can merge this pull request into a Git repository