Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-03-09 Thread Bruno Cadonna
Hi Ismael, I understand your reasoning. I thought, since it is a broken feature, I better let this thread know about it. Best, Bruno On Mon, Mar 9, 2020 at 10:00 PM Ismael Juma wrote: > > Hi Bruno, > > 2.4.0 has been out for months. If this was not noticed since then, I don't > think it

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-03-09 Thread Ismael Juma
Hi Bruno, 2.4.0 has been out for months. If this was not noticed since then, I don't think it qualifies as a blocker for 2.5.0. Ismael On Mon, Mar 9, 2020 at 8:44 PM Bruno Cadonna wrote: > Hi David, > > A bug report was filed that can be considered a blocker. Basically, > with this bug all

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-03-09 Thread Bruno Cadonna
Hi David, A bug report was filed that can be considered a blocker. Basically, with this bug all RocksDB metrics reported by Streams are constant zero. The bug is there since 2.4., so it is not a regression, but a broken feature. Here is the ticket:

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-26 Thread Randall Hauch
Thanks, David. The PR has been merged to trunk and 2.5, and I'm backporting to earlier branches. I'll resolve https://issues.apache.org/jira/browse/KAFKA-9601 when I finish backporting. On Wed, Feb 26, 2020 at 1:28 PM David Arthur wrote: > Thanks, Randall. Leaking sensitive config to the logs

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-26 Thread David Arthur
Thanks, Randall. Leaking sensitive config to the logs seems fairly severe. I think should include this. Let's proceed with cherry-picking to 2.5. -David On Wed, Feb 26, 2020 at 2:25 PM Randall Hauch wrote: > Hi, David. > > If we're still not quite ready for an RC, I'd like to squeeze in >

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-26 Thread Randall Hauch
Hi, David. If we're still not quite ready for an RC, I'd like to squeeze in https://issues.apache.org/jira/browse/KAFKA-9601, which removes the raw connector config properties in a DEBUG level log message. PR is ready (test failures are unrelated), the risk is very low, and I think it'd be great

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-26 Thread David Arthur
Viktor, the change LGTM. I've approved and merged the cherry-pick version into 2.5. Thanks! David On Tue, Feb 25, 2020 at 4:43 AM Viktor Somogyi-Vass wrote: > Hi David, > > There are two short JIRAs related to KIP-352 that documents the newly added > metrics. Is it possible to merge them in? >

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-25 Thread Viktor Somogyi-Vass
Hi David, There are two short JIRAs related to KIP-352 that documents the newly added metrics. Is it possible to merge them in? https://github.com/apache/kafka/pull/7434 (trunk) https://github.com/apache/kafka/pull/8127 (2.5 cherry-pick) Thanks, Viktor On Mon, Feb 24, 2020 at 7:22 PM David

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-24 Thread David Arthur
Thanks, Tu. I've moved KIP-467 out of the release plan. -David On Thu, Feb 20, 2020 at 6:00 PM Tu Tran wrote: > Hi David, > > Thanks for being the release main driver. Since the implementation for the > last part of KIP-467 wasn't finalized prior to Feb 12th, could you remove > KIP-467 from

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-20 Thread Tu Tran
Hi David, Thanks for being the release main driver. Since the implementation for the last part of KIP-467 wasn't finalized prior to Feb 12th, could you remove KIP-467 from the list? Thanks, Tu On Thu, Feb 20, 2020 at 7:18 AM David Arthur wrote: > Randall / Konstantine, > > Sorry for the late

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-20 Thread David Arthur
Randall / Konstantine, Sorry for the late reply. Thanks for the fix and for the update! I see this change on the 2.5 branch (@b403c66). Consider this a retroactive approval for this bugfix :) -David On Fri, Feb 14, 2020 at 2:21 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > Hi

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-14 Thread Konstantine Karantasis
Hi David, I want to confirm what Randall mentions above. The code fixes for KAFKA-9556 were in place before code freeze on Wed, but we spent a bit more time hardening the conditions of the integration tests and fixing some jenkins branch builders to run the test on repeat. Best, Konstantine On

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-14 Thread Randall Hauch
Hi, David. I just filed https://issues.apache.org/jira/browse/KAFKA-9556 that identifies two pretty minor issues with the new KIP-558 that adds new Connect REST API endpoints to get the list of topics used by a connector. The impact is high: the feature cannot be fully disabled, and Connect does

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-02-10 Thread David Arthur
Just a friendly reminder that this Wednesday, February 12th, is the code freeze for the 2.5.0 release. After this time we will only accept blocker bugs onto the release branch. Thanks! David On Fri, Jan 31, 2020 at 5:13 PM David Arthur wrote: > Thanks! I've updated the list. > > On Thu, Jan

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-31 Thread David Arthur
Thanks! I've updated the list. On Thu, Jan 30, 2020 at 5:48 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > Hi David, > > thanks for driving the release. > > Please also remove KIP-158 from the list of KIPs that you plan to include > in 2.5 > KIP-158 has been accepted, but the

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-30 Thread Konstantine Karantasis
Hi David, thanks for driving the release. Please also remove KIP-158 from the list of KIPs that you plan to include in 2.5 KIP-158 has been accepted, but the implementation is not yet final. It will be included in the release that follows 2.5. Regards, Konstantine On 1/30/20, Matthias J. Sax

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-30 Thread Matthias J. Sax
Hi David, the following KIP from the list did not make it: - KIP-216 (no PR yet) - KIP-399 (no PR yet) - KIP-401 (PR not merged yet) KIP-444 should be included as we did make progress, but it is still not fully implement and we need to finish in in 2.6 release. KIP-447 is partially

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-29 Thread David Arthur
Hey everyone, just a quick update on the 2.5 release. I have updated the list of planned KIPs on the release wiki page https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=143428858. If I have missed anything, or there are KIPs included in this list which should *not* be included in

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-13 Thread Colin McCabe
+1. Thanks for volunteering, David. best, Colin On Fri, Dec 20, 2019, at 10:59, David Arthur wrote: > Greetings! > > I'd like to volunteer to be release manager for the next time-based feature > release which will be 2.5. If there are no objections, I'll send out the > release plan in the next

Re: [DISCUSS] Apache Kafka 2.5.0 release

2020-01-11 Thread David Arthur
Here's the release plan https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=143428858 KIP freeze is Jan 22nd with a target release date of Feb 26th. I'll work on curating a list of KIPs next. Thanks! David On Fri, Dec 20, 2019 at 2:04 PM Ismael Juma wrote: > +1 > > Thanks for

Re: [DISCUSS] Apache Kafka 2.5.0 release

2019-12-20 Thread Ismael Juma
+1 Thanks for volunteering David! Ismael On Fri, Dec 20, 2019, 7:00 PM David Arthur wrote: > Greetings! > > I'd like to volunteer to be release manager for the next time-based feature > release which will be 2.5. If there are no objections, I'll send out the > release plan in the next few

[DISCUSS] Apache Kafka 2.5.0 release

2019-12-20 Thread David Arthur
Greetings! I'd like to volunteer to be release manager for the next time-based feature release which will be 2.5. If there are no objections, I'll send out the release plan in the next few days. Thanks, David Arthur