Re: [DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-20 Thread Luke Chen
Hi Kuan-Po, Thanks for the explanation and KIP update. I have no more questions. Luke On Wed, May 21, 2025 at 11:15 AM Kuan-Po Tseng wrote: > Hi Luke > > Thanks for your feedback! > > L1, L2: The logic for > `RemoteLogManagerConfig#remoteLogManagerFollowerThreadPoolSize` is shown > below. > `

Re: [DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-20 Thread Kuan-Po Tseng
Hi Luke Thanks for your feedback! L1, L2: The logic for `RemoteLogManagerConfig#remoteLogManagerFollowerThreadPoolSize` is shown below. ``` public int remoteLogManagerFollowerThreadPoolSize() { if (config.originals().containsKey(REMOTE_LOG_MANAGER_FOLLOWER_THREAD_POOL_SIZE_PROP)) { re

Re: [DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-19 Thread Luke Chen
Hi Kuan-Po, Thanks for the KIP! Questions: 1. If `remote.log.manager.thread.pool.size` is set and `remote.log.manager.follower.thread.pool.size` is not set, we will still honor the setting in `remote.log.manager.thread.pool.size`, right? We should add in KIP to make it clear. 2. Suppose `remote.

Re: [DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-19 Thread Kuan-Po Tseng
Hello everyone, Just giving this thread a little nudge. If there’s no more feedback, I’ll kick off the vote tomorrow. Also, thanks to Kamal for reviewing this KIP! Best Regards, Kuan-Po On Mon, May 19, 2025 at 11:16 PM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Hi Kuan-Po,

Re: [DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-19 Thread Kamal Chandraprakash
Hi Kuan-Po, The proposal to add the new remote.log.manager.follower.thread.pool.size config, LGTM. Thanks for making this change! -- Kamal On Mon, May 12, 2025 at 10:19 PM KuanPo Tseng wrote: > Hello everyone, > > I’d like to discuss a KIP regarding introducing a new configuration, > remote.lo

[DISCUSS] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-12 Thread KuanPo Tseng
Hello everyone, I’d like to discuss a KIP regarding introducing a new configuration, remote.log.manager.follower.thread.pool.size Thank you! KIP link: https://cwiki.apache.org/confluence/x/xAlWFQ Best, Kuan-Po Tseng