Re: [DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-13 Thread Colin McCabe
Hi all, Any other thoughts about this KIP? If not, I'll start a vote on the KIP some time next week. cheers, Colin On Fri, Oct 6, 2017, at 13:03, Tom Bentley wrote: > Thanks Colin, it makes sense now, it was the HWM party I was missing. > > Cheers, > > Tom > > On 6 Oct 2017 6:44 pm, "Colin

Re: [DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-06 Thread Tom Bentley
Thanks Colin, it makes sense now, it was the HWM party I was missing. Cheers, Tom On 6 Oct 2017 6:44 pm, "Colin McCabe" wrote: On Thu, Oct 5, 2017, at 12:06, Tom Bentley wrote: > Hi Colin, > > Is it really true that "the period when the offset is unavailable should > be > brief"? I'm thinking

Re: [DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-06 Thread Apurva Mehta
Thanks for the KIP Colin. That looks like a reasonable proposal. On Thu, Oct 5, 2017 at 11:23 AM, Colin McCabe wrote: > Hi all, > > I created a KIP for discussion about fixing a corner case in > ListOffsetsResponse. Check it out at: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 207

Re: [DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-06 Thread Colin McCabe
On Thu, Oct 5, 2017, at 12:06, Tom Bentley wrote: > Hi Colin, > > Is it really true that "the period when the offset is unavailable should > be > brief"? I'm thinking about a producer with acks=1, so the old leader > returns the ProduceResponse immediately and then is replaced before it > can > se

Re: [DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-05 Thread Tom Bentley
Hi Colin, Is it really true that "the period when the offset is unavailable should be brief"? I'm thinking about a producer with acks=1, so the old leader returns the ProduceResponse immediately and then is replaced before it can sent a FetchResponse to any followers. The new leader is then waitin

[DISCUSS] KIP-207: Offsets returned by ListOffsetsResponse should be monotonically increasing even during a partition leader change

2017-10-05 Thread Colin McCabe
Hi all, I created a KIP for discussion about fixing a corner case in ListOffsetsResponse. Check it out at: https://cwiki.apache.org/confluence/display/KAFKA/KIP-207%3A+Offsets+returned+by+ListOffsetsResponse+should+be+monotonically+increasing+even+during+a+partition+leader+change cheers, Colin