Re: [DISCUSS] KIP-237: More Controller Health Metrics

Thanks for the explanation Ismael. Yeah I think it makes sense that we shouldn't have to rely on class names for metrics. It seems that the current metric framework in Kafka will use the the class name in the metric name -- this logic is hard-coded in KafkaMetricsGroup class. This is probably the

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Sorry, I thought I had replied to this. Relying on class names for metrics is an anti-pattern in my opinion. It couples metrics too tightly with the implementation and makes it harder to refactor. That was the reason for the suggestion. Ismael On Wed, Dec 13, 2017 at 1:51 AM, Dong Lin

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Hey Ismael, Thanks for your comments. Yeah the set of metrics in the KIP includes the two metrics discussed in the future work in KIP-143. This KIP was also named after KIP-143. I think it may be better to use to use ControllerEventManager instead of ControllerStats. The metrics 1 and 2 are

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Thanks for the KIP, Dong. The general idea is good. In fact, two of the three metrics had been listed under future work for KIP-143: "KAFKA-5028 introduced a queue for Controller events. It would be useful to have a gauge for the queue size and a histogram for how long an event waits in the queue

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Hey Jun, Thanks for the suggestion. That is good point. I have updated the KIP as suggested. Thanks, Dong On Fri, Dec 8, 2017 at 5:04 PM, Jun Rao wrote: > Hi, Dong, > > Thanks for the KIP. It looks reasonable. > > Just one minor comment. In the following metric, it seems

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Hi, Dong, Thanks for the KIP. It looks reasonable. Just one minor comment. In the following metric, it seems that RequestRate is better than EventRate. kafka.controller:type=ControllerChannelManager,name=EventRateAndQueueTimeMs, brokerId=someId Jun On Wed, Dec 6, 2017 at 6:21 PM, Dong Lin

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Thanks for the comment. I have updated the KIP to explain the value of these metrics. On Wed, Dec 6, 2017 at 6:38 PM, Ted Yu wrote: > Thanks for the KIP. > > Can you add description for EventRateAndQueueTimeMs ? > > Cheers > > On Wed, Dec 6, 2017 at 6:21 PM, Dong Lin

Re: [DISCUSS] KIP-237: More Controller Health Metrics

Thanks for the KIP. Can you add description for EventRateAndQueueTimeMs ? Cheers On Wed, Dec 6, 2017 at 6:21 PM, Dong Lin wrote: > Hi all, > > I have created KIP-237: More Controller Health Metrics > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

[DISCUSS] KIP-237: More Controller Health Metrics

Hi all, I have created KIP-237: More Controller Health Metrics https://cwiki.apache.org/confluence/display/KAFKA/KIP-237%3A+More+Controller+Health+Metrics . The KIP proposes to add a few more metrics to help monitor Kafka Controller health. Feedback and suggestions are welcome! Thanks, Dong