Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-24 Thread Manikumar
Hi Satish, Thanks for the review. 1. Currently we are just printing toSring() of Acl class. I prefer to have similar output with or without "--principal" option. 2. Yes, we can accept multiple principals. Updated the KIP. @all If there are no more comments, I will start vote on this KIP early

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-24 Thread Satish Duggana
Hi Mani, Just a minor comment on the output of the command as given in KIP-357, you may want to remove "User:User1 has " as it is redundant for each ACL. It may be good to accept multiple principals option to avoid running this script multiple times with each principal to achieve the same. >>

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-23 Thread Harsha
+1 (binding) Thanks, Harsha On Wed, Aug 22, 2018, at 9:15 AM, Manikumar wrote: > Hi Viktor, > We already have a method in Authorizer interface to get acls for a given > principal. > We will use this method to fetch acls and filter the results for requested > Resources. > Authorizer { >def

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-22 Thread Manikumar
Hi Viktor, We already have a method in Authorizer interface to get acls for a given principal. We will use this method to fetch acls and filter the results for requested Resources. Authorizer { def getAcls(principal: KafkaPrincipal): Map[Resource, Set[Acl]] } Currently AdminClient API doesn't

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-22 Thread Viktor Somogyi-Vass
Hi Manikumar, Implementation-wise is it just a filter over the returned ACL listing or do you plan to add new methods to the Authorizer as well? Thanks, Viktor On Fri, Aug 17, 2018 at 9:18 PM Priyank Shah wrote: > +1(non-binding) > > Thanks. > Priyank > > On 8/16/18, 6:01 AM, "Manikumar"

Re: [DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-17 Thread Priyank Shah
+1(non-binding) Thanks. Priyank On 8/16/18, 6:01 AM, "Manikumar" wrote: Hi all, I have created a minor KIP to add support to list ACLs per principal using AclCommand (kafka-acls.sh)

[DISCUSS] KIP-357: Add support to list ACLs per principal

2018-08-16 Thread Manikumar
Hi all, I have created a minor KIP to add support to list ACLs per principal using AclCommand (kafka-acls.sh) https://cwiki.apache.org/confluence/display/KAFKA/KIP-357%3A++Add+support+to+list+ACLs+per+principal Please take a look. Thanks,