Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-11-11 Thread Colin McCabe
Hi Mickael, Thanks for the revisions. It looks good overall. best, Colin On Mon, Nov 11, 2019, at 03:45, Mickael Maison wrote: > Hi all, > > If there's no more feedback, I'll open a vote in the next few days. > > Thanks > > On Wed, Nov 6, 2019 at 11:35 AM Mickael Maison > wrote: > > > > H

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-11-11 Thread Mickael Maison
Hi all, If there's no more feedback, I'll open a vote in the next few days. Thanks On Wed, Nov 6, 2019 at 11:35 AM Mickael Maison wrote: > > Hi, > > Thanks Colin for the feedback. Edo and I have updated the KIP > accordingly. Can you take another look? > > > On Tue, Oct 22, 2019 at 12:20 AM Col

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-11-06 Thread Mickael Maison
Hi, Thanks Colin for the feedback. Edo and I have updated the KIP accordingly. Can you take another look? On Tue, Oct 22, 2019 at 12:20 AM Colin McCabe wrote: > > Hi Mickael, > > We don't have any official way for brokers to join the cluster other than > showing up and registering themselves i

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-10-21 Thread Colin McCabe
Hi Mickael, We don't have any official way for brokers to join the cluster other than showing up and registering themselves in ZK. Similarly, we don't have any way of removing brokers from the cluster other than simply removing them and removing their znodes from ZooKeeper. If we wanted to ch

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-10-21 Thread Mickael Maison
Thanks Stanislav and Colin for the feedback. I've updated the KIP to make it simpler. It's not updating the CreateTopics/CreatePartitions RPCs anymore. I've kept the broker setting so admins can keep the current behaviour but simplified it to be either enabled or disabled. I've also kept the obse

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-03-25 Thread Mickael Maison
Thanks Colin for the feedback. The idea was to allow both users and administrator to decide if they wanted to opt-in and if so under what conditions. Maybe we could do something simpler and just allow the creation if at least min-in-sync replicas are available? That should not require changes to

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-02-26 Thread Colin McCabe
Hi Mickael, I don't think adding CREATED_UNDER_REPLICATED as an error code makes sense. It is not an error condition, as described here. > Updates to the Decommissioning brokers section in the documentation > will mention that if a broker id is never to be reused then its corresponding > node

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-01-30 Thread Stanislav Kozlovski
Hey there Mickael, thanks for the KIP. I think the proposal makes sense. My initial concern was that we may not want to allow this at all if the cluster is in an unhealthy state. After thinking about it, I don't see it hurting at all - we would already have topics that are under-replicated so crea

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-01-30 Thread Mickael Maison
Another bump. Feedback and suggestions are always appreciated! On Tue, Jan 8, 2019 at 5:14 PM Mickael Maison wrote: > > Hi, > > We've not received any feedback yet on this KIP. We still believe this > would be a nice improvement. > > Thanks > > On Tue, Dec 18, 2018 at 4:27 PM Mickael Maison > w

Re: [DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2019-01-08 Thread Mickael Maison
Hi, We've not received any feedback yet on this KIP. We still believe this would be a nice improvement. Thanks On Tue, Dec 18, 2018 at 4:27 PM Mickael Maison wrote: > > Hi, > > We have submitted a KIP to handle topics and partitions creation when > a cluster is not fully available: > > https://

[DISCUSS] KIP-409: Allow creating under-replicated topics and partitions

2018-12-18 Thread Mickael Maison
Hi, We have submitted a KIP to handle topics and partitions creation when a cluster is not fully available: https://cwiki.apache.org/confluence/display/KAFKA/KIP-409%3A+Allow+creating+under-replicated+topics+and+partitions As always, we welcome feedback and suggestions. Thanks Mickael and Edoar