Re: [DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-03-28 Thread Viktor Somogyi-Vass
Hey Folks, Since there were no discussions on this in the past two weeks I'll create a VOTE thread soon. Thanks, Viktor On Thu, Mar 14, 2019 at 7:05 PM Viktor Somogyi-Vass wrote: > Hey Stanislav, > > Sorry for the delay on this. In the meantime I realized that the dead > fetchers won't be

Re: [DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-03-14 Thread Viktor Somogyi-Vass
Hey Stanislav, Sorry for the delay on this. In the meantime I realized that the dead fetchers won't be removed from the fetcher map, so it's very easy to figure out how many dead and alive there are. I can collect them on broker level which I think gives a good enough information if there is a

Re: [DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-03-04 Thread Stanislav Kozlovski
Hey Viktor, > however displaying the thread count (be it alive or dead) would still add extra information regarding the failure, that a thread died during cleanup. I agree, I think it's worth adding. > Doing this on the replica fetchers though would be a bit harder as the number of replica

Re: [DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-02-25 Thread Viktor Somogyi-Vass
Hi Stanislav, Thanks for the feedback and sharing that discussion thread. I read your KIP and the discussion on it too and it seems like that'd cover the same motivation I had with the log-cleaner-thread-count metric. This supposed to tell the count of the alive threads which might differ from

Re: [DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-02-22 Thread Stanislav Kozlovski
Hey Viktor, First off, thanks for the KIP! I think that it is almost always a good idea to have more metrics. Observability never hurts. In regards to the LogCleaner: * Do we need to know log-cleaner-thread-count? That should always be equal to "log.cleaner.threads" if I'm not mistaken. *

[DISCUSS] KIP-434: Add Replica Fetcher and Log Cleaner Count Metrics

2019-02-22 Thread Viktor Somogyi-Vass
Hi All, I'd like to start a discussion about exposing count gauge metrics for the replica fetcher and log cleaner thread counts. It isn't a long KIP and the motivation is very simple: monitoring the thread counts in these cases would help with the investigation of various issues and might help in