Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Boyang Chen
Thanks Bill! Get Outlook for iOS<https://aka.ms/o0ukef> From: Bill Bejeck Sent: Tuesday, April 30, 2019 6:44:17 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams Thanks for the KIP Boyang. I have no addi

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Bill Bejeck
54 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams > > +1 (binding) > > Guozhang > > On 2019/04/26 07:42:12, "Matthias J. Sax" wrote: > > Thanks for the KIP! > > > > I agree that the change

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Boyang Chen
Thank you Guozhang! From: Guozhang Wang Sent: Wednesday, May 1, 2019 3:54 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams +1 (binding) Guozhang On 2019/04/26 07:42:12, "Matthias J. Sax" wrote: > Thank

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Guozhang Wang
+1 (binding) Guozhang On 2019/04/26 07:42:12, "Matthias J. Sax" wrote: > Thanks for the KIP! > > I agree that the change makes sense, and not only for the static group > membership case. > > For example, if a user `closes()` a `KafkaStreams` client and creates a > new one (for example to

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Boyang Chen
Thank you Sophie! Added the case Matthias described in the Compatibility session. From: Sophie Blee-Goldman Sent: Wednesday, May 1, 2019 1:30 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams Hey Boyang, I think

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Sophie Blee-Goldman
> expected > > outcome if they choose to set same client.ids for different Streams > client. > > > > > > Otherwise, I've no further comments. > > > > Guozhang > > > > On Mon, Apr 29, 2019 at 3:42 PM Boyang Chen wrote: > > > &

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Boyang Chen
P. Boyang From: Bruno Cadonna Sent: Tuesday, April 30, 2019 4:15 PM To: dev@kafka.apache.org Subject: Re: Fw: [DISCUSS] KIP-462 : Use local thread id for KStreams Hi Guozhang, What do you mean exactly with "throttling purposes"? @Boyang: Thank you for t

Re: Fw: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-30 Thread Bruno Cadonna
> On Mon, Apr 29, 2019 at 3:42 PM Boyang Chen wrote: > > > FYI > > > > > > > > From: Boyang Chen > > Sent: Tuesday, April 30, 2019 4:32 AM > > To: dev@kafka.apache.org > > Subject: Re: [DI

Re: Fw: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-29 Thread Guozhang Wang
comments. Guozhang On Mon, Apr 29, 2019 at 3:42 PM Boyang Chen wrote: > FYI > > > > From: Boyang Chen > Sent: Tuesday, April 30, 2019 4:32 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-462 : Use local thread id for K

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-29 Thread Boyang Chen
Could we get more discussions on this thread? Boyang From: Boyang Chen Sent: Friday, April 26, 2019 10:51 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams Thanks for the explanation Matthias! Will enhance the KIP

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Boyang Chen
Thanks for the explanation Matthias! Will enhance the KIP motivation by your example. From: Matthias J. Sax Sent: Friday, April 26, 2019 3:42 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-462 : Use local thread id for KStreams Thanks for the KIP! I

Re: [DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Matthias J. Sax
Thanks for the KIP! I agree that the change makes sense, and not only for the static group membership case. For example, if a user `closes()` a `KafkaStreams` client and creates a new one (for example to recover failed threads), while the JVM is still running, it is more intuitive that the

[DISCUSS] KIP-462 : Use local thread id for KStreams

2019-04-26 Thread Boyang Chen
Hey friends, I would like to start discussion for a very small KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-462%3A+Use+local+thread+id+for+KStreams it is trying to avoid sharing thread-id increment between multiple stream instances configured in one JVM. This is an important fix