Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-13 Thread Anastasia Vela
Hey! Thanks for looking over this KIP. These are all partitions per manager. I'll clear this up in the KIP. Anastasia On Sat, Jul 13, 2019, 2:15 PM Stanislav Kozlovski wrote: > Hey there, > > Thanks for the KIP! I always smile when I see new metrics > I have just one quick question - are these

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-13 Thread Stanislav Kozlovski
Hey there, Thanks for the KIP! I always smile when I see new metrics I have just one quick question - are these metrics per partition or a total of all the partitions per manager? The KIP has conflicting sentences so I'm not sure what it is. Thanks, Stanislav On Wed, Jul 3, 2019 at 9:13 PM Gwen

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-03 Thread Gwen Shapira
It looks great! If there are no more concerns, lets start a vote. On Tue, Jul 2, 2019 at 2:59 PM Anastasia Vela wrote: > > After further discussion with Anna, we decided the following: > - add the average metric, but noted in the KIP that the average value may > look low at times when there are m

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-02 Thread Anastasia Vela
After further discussion with Anna, we decided the following: - add the average metric, but noted in the KIP that the average value may look low at times when there are many empty partitions that have a 0ms load time - set the window to 30sec, because there is no significance difference if we set t

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-07-01 Thread Anastasia Vela
Hey Gwen! Thanks for reviewing my KIP! 1. I did consider adding an Avg metric as well. Anna and I decided that a max would provide the crucial information. We just need to know if there was a long load time, and expose what that duration was so we understand there's downtime for such a long time.

Re: [DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-06-28 Thread Gwen Shapira
Hey, Thank you for proposing this! Sounds really useful - we have definitely seem some difficult to explain pauses in consumer activity and this metric will let us correlate those. Few questions: 1. Did you consider adding both Max and Avg metrics? Many of our metrics have both (batch-size and me

[DISCUSS] KIP-484: Expose metrics for group and transaction metadata loading duration

2019-06-25 Thread Anastasia Vela
Hi all, I'd like to discuss KIP-484: https://cwiki.apache.org/confluence/display/KAFKA/KIP-484%3A+Expose+metrics+for+group+and+transaction+metadata+loading+duration Let me know what you think! Thanks, Anastasia