Re: Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-26 Thread Sandeep Mopuri
Hi Rajini, updated the KIP to reflect the ordering of the providers passed and added information about the configured providers taking precedence over the login module providers in case of SASL. Also updated the config name. Please take a look and if everything looks good, I can start a vote. On F

Re: Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-26 Thread Rajini Sivaram
Hi Harsha, Since one provider can implement multiple things, excluding SASL may mean not adding providers which implement any SASL mechanism even though you are actually interested only in one SSL algorithm that also happens to be in the provider. Perhaps it would be simpler to allow SASL as well,

Re: Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-25 Thread Harsha
Thanks Rajini . > 4) The main difference between SSL and SASL is that for SSL, you register a > provider with your own algorithm name and you specify your algorithm name > in a separate config. This algorithm name can be anything you choose. For > SASL, we register providers for standard SASL mech

Re: Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-25 Thread Rajini Sivaram
Hi Sandeep/Harsha, I don't have any major concerns about this KIP since it solves a specific issue and is a relatively minor change. I am unconvinced about the SASL case, but it probably is better to add as a config that can be used with SASL as well in future anyway. Just to complete the convers

Re: Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-24 Thread Harsha
Thanks for the details. Rajini, Can you please take a look and let us know if these addresses your concerns. Thanks, Harsha On Mon, Jul 22, 2019, at 9:36 AM, Sandeep Mopuri wrote: > Hi Rajini, > Thanks for raising the above questions. Please find the > replies below > > On Wed, Ju

Fwd: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-22 Thread Sandeep Mopuri
Hi Rajini, Thanks for raising the above questions. Please find the replies below On Wed, Jul 17, 2019 at 2:49 AM Rajini Sivaram wrote: > Hi Sandeep, > > Thanks for the KIP. A few questions below: > >1. Is the main use case for this KIP adding security providers for SSL? >If

Re: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-17 Thread Rajini Sivaram
Hi Sandeep, Thanks for the KIP. A few questions below: 1. Is the main use case for this KIP adding security providers for SSL? If so, wouldn't a more generic solution like KIP-383 work for this? 2. Presumably this config would also apply to clients. If so, have we thought through the

Re: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-16 Thread Harsha
Thanks for the KIP Sandeep. LGTM. Mani & Rajini, can you please look at the KIP as well. Thanks, Harsha On Tue, Jul 16, 2019, at 2:54 PM, Sandeep Mopuri wrote: > Thanks for the suggestions, made changes accordingly. > > On Tue, Jul 16, 2019 at 9:27 AM Satish Duggana > wrote: > > > Hi Sandeep,

Re: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-16 Thread Sandeep Mopuri
Thanks for the suggestions, made changes accordingly. On Tue, Jul 16, 2019 at 9:27 AM Satish Duggana wrote: > Hi Sandeep, > Thanks for the KIP, I have few comments below. > > >>“To take advantage of these custom algorithms, we want to support java > security provider parameter in security config

Re: [DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-16 Thread Satish Duggana
Hi Sandeep, Thanks for the KIP, I have few comments below. >>“To take advantage of these custom algorithms, we want to support java >>security provider parameter in security config. This param can be used by >>kafka brokers or kafka clients(when connecting to the kafka brokers). The >>security

[DISCUSS] KIP-492 Add java security providers in Kafka Security config

2019-07-15 Thread Sandeep Mopuri
Hello all, I'd like to start a discussion thread for KIP-492. This KIP plans on introducing a new security config parameter for a custom security providers. Please take a look and let me know what do you think. More information can be found here: https://cwiki.apache.org/confluence/display/KAFKA/