Hi Cyrus,
Thanks for the KIP.
In the motivation I can see how having a guaranteed iteration order might
be useful for some connectors, but I couldn't see how a Connector developer
would benefit from using List.get(int). Could you elaborate? Can you offer
any numbers to show that the cost of
Almog, I think that's a great point -- I will update the KIP to reflect
your suggestion!
On Tue, Sep 24, 2019 at 12:46 PM Almog Gavra wrote:
> Thanks Cyrus! I think this change is a good step in hardening the API. I do
> believe that APIs should be defined by functionality and not performance
>
Thanks Cyrus! I think this change is a good step in hardening the API. I do
believe that APIs should be defined by functionality and not performance
characteristics, so I'd prefer using List<> over ArrayList<> (the
alternative you mention in rejected). That also gives us leeway in the
future to
Hi all,
I've written a KIP to update the SinkTask abstract class to specify that
the `put` method will take ArrayList. I think this will greatly simplify
connector development, so you aren't limited to the simplest iterations. It
will also harden the ordering guarantees of the API.
Looking
