Re: [DISCUSS] KIP-565: Using AclCommand,avoid call the global method loadcache in SimpleAclAuthorizer

2020-02-28 Thread Rajini Sivaram
Hi Steven, Since we are deprecating ZooKeeper options in AclCommand due to KIP-500 in favour of using bootstrap servers, it is not clear why we need this change. Can you explain why you want to use ZK rather than the secure `--bootstrap-server` option for updating ACLs? Since brokers always have

Re: [DISCUSS] KIP-565: Using AclCommand,avoid call the global method loadcache in SimpleAclAuthorizer

2020-02-27 Thread Steven Lu
Thanks for your replay, this switch same not the best.I have changed another way to solve this problom,can you help me review the pr: https://github.com/apache/kafka/pull/7706/files On 2020/01/21 09:48:00, Rajini Sivaram wrote: > Hi Steven, > > Thanks for the KIP. A few questions/comments:

Re: [DISCUSS] KIP-565: Using AclCommand,avoid call the global method loadcache in SimpleAclAuthorizer

2020-02-16 Thread Steven Lu
Thanks for your replay, this switch same not the best.I have changed another way to solve this problom,can you help me review the pr: https://github.com/apache/kafka/pull/7706/files On 2020/01/21 09:48:00, Rajini Sivaram wrote: > Hi Steven, > > Thanks for the KIP. A few questions/comments:

Re: [DISCUSS] KIP-565: Using AclCommand,avoid call the global method loadcache in SimpleAclAuthorizer

2020-01-21 Thread Rajini Sivaram
Hi Steven, Thanks for the KIP. A few questions/comments: 1) The command line option for AclCommand makes it the user's responsibility to determine whether cache should be loaded. That doesn't feel like a good idea. If you are listing ACLs, you need the cache. More importantly, you need the cache

[DISCUSS] KIP-565: Using AclCommand,avoid call the global method loadcache in SimpleAclAuthorizer

2020-01-20 Thread Steven Lu
Hello all, In the class Named AclCommand,configure SimpleAclAuthorizer,but no need call loadCache. now we have 20,000 topics in kafka cluster,everytime I run AclCommand,all these topics's Alcs need to be authed, it will be very slow. The purpose of this optimization is:we can choose to not load