Hi Jeff,
Thanks for the updated KIP, looks good.
Regards,
Rajini
On Fri, May 15, 2020 at 5:57 PM Jeff Huang wrote:
> Hi David,
>
> Thanks for your suggestions. I updated KIP based on your comments 1,2 and
> 4. For comment 3), I think the approach which Authorizer extend Monitorable
> would b
Hi David,
Thanks for your suggestions. I updated KIP based on your comments 1,2 and 4.
For comment 3), I think the approach which Authorizer extend Monitorable would
be simple for broker calling monitor function without checking whether Object
implemented Monitorable function or not and make it
Hey Jeff,
Thanks for the updated KIP. The interface looks good to me. I've got couple
of comments:
1. You say: "Other broker or client plugins could potentially implement the
interface and get the
broker's or client's Metrics instance to add additional metrics from
sub-components." Does it
imply
Hey David,
I accepted your suggestion and add Monitorable interface. Thanks for great
suggestion. Please review KIP-608 again and see any suggestion on name of
function or other stuff.
jeff.
On 2020/05/11 15:16:30, David Jacot wrote:
> Hey,
>
> Thanks for the KIP.
>
> I think that having th
Hi David,
I had thought about this before. I changed mind due to we want the metrics in
Authorizer in 2.6 and time restraint. But I will reconsider this. Thanks for
this suggestion.
Jeff.
On 2020/05/11 15:16:30, David Jacot wrote:
> Hey,
>
> Thanks for the KIP.
>
> I think that having th
Hey,
Thanks for the KIP.
I think that having the possibilities to expose metrics in plugins such as
the authorizer in a
nice improvement. I do wonder if we could come up with a more generic way
to do this that
would apply to all plugins instead of having something specific for the
authorized.
Fo
Will update KIP.
thanks!
On 2020/05/06 15:09:53, Rajini Sivaram wrote:
> Hi Jeff,
>
> Thanks for the KIP. It looks useful since it allows authorizers to use the
> broker's metrics instance. We could perhaps use this in AclAuthorizer to
> generate authorizer metrics?
>
> Regards,
>
> Rajini
1. It is intended to return broker metrics.
2. I did searching, there is no any public API return broker Metrics class so
far. So this will be first time. I did find connect also expose the Metrics
class, but it is not in public API.
org.apache.kafka.connect.runtime.ConnectMetrics
/**
* Get the
Thanks for the KIP. A couple of questions:
1. Is it intended for this method to return null or the broker metrics
instance?
2. Is the Metrics class returned in any public APIs today or this the first
time we are doing it?
Ismael
On Wed, May 6, 2020 at 8:10 AM Rajini Sivaram
wrote:
> Hi Jeff,
>
Hi Jeff,
Thanks for the KIP. It looks useful since it allows authorizers to use the
broker's metrics instance. We could perhaps use this in AclAuthorizer to
generate authorizer metrics?
Regards,
Rajini
On Tue, May 5, 2020 at 9:04 PM Zhiguo Huang wrote:
>
> https://cwiki.apache.org/confluence/
https://cwiki.apache.org/confluence/display/KAFKA/KIP-608+-+Add+a+new+method+to+AuthorizerServerInfo+Interface
11 matches
Mail list logo
