The pull request has been submitted with the changes to implement the KIP
https://github.com/apache/kafka/pull/10740
Please take a look when you have a moment
Thanks.
On Wed, Apr 28, 2021 at 5:12 PM Israel Ekpo wrote:
> Excellent Sophie.
>
> I have the initial changes (without the Unit tests
Excellent Sophie.
I have the initial changes (without the Unit tests yet) here
https://github.com/izzyacademy/kafka/commit/c7094fae666f407e413c2b9d40e980a68aebf81f
Please let me know what you think. I will be working on the Unit tests in
about a day and will submit a PR once the Unit tests are
Oh, yeah, looks like a copy/paste error. I'll admit I didn't type out each
of these method signatures
by hand from scratch. Thanks for catching this!
Added you so you should be able to edit the KIP now and fix this up.
On Wed, Apr 28, 2021 at 1:29 PM Israel Ekpo wrote:
> I was not able to
I was not able to edit the wiki page for the KIP.
When you have a moment, please could you grant me permissions?
https://cwiki.apache.org/confluence/display/~iekpo
On Wed, Apr 28, 2021 at 4:17 PM Israel Ekpo wrote:
>
> Hi Everyone,
>
> I noticed that the method signature in the KIP had the
Hi Everyone,
I noticed that the method signature in the KIP had the incorrect return
value.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-633:+Drop+24+hour+default+of+grace+period+in+Streams
Should I go ahead and update this in the KIP? I just noticed the error
during my implementation
Thanks!
On 4/8/21 2:06 PM, Sophie Blee-Goldman wrote:
> 1) Since the new APIs (eg ofSizeWithNoGrace and ofSizeAndGrace) are the
> only static constructors
> after this change, there seems to be no reason to keep the .grace around --
> you've already specified
> it with your choice of the static
1) Since the new APIs (eg ofSizeWithNoGrace and ofSizeAndGrace) are the
only static constructors
after this change, there seems to be no reason to keep the .grace around --
you've already specified
it with your choice of the static constructor.
2) Ack, updated the KIP
3) Ack, fixed
On Tue, Apr
Thanks for the KIP Sophie. It make total sense to get rid of default
grace period of 24h.
Some questions/comments:
(1) Is there any particular reason why we want to remove
`grace(Duration)` method?
(2) About `SlidingWindows#withTimeDifferenceAndGrace` -- personally I
think it's worth to clean
Hello Sophie,
I agree that the old 24-hour grace period should be updated, and I also
think now it is a better idea to make the grace period "mandatory" from the
API names since it is a very important concept and hence worth emphasizing
to users up front.
Guozhang
On Wed, Mar 31, 2021 at 1:58
Thanks for bringing this up, Sophie!
This has indeed been a pain point for a lot of people.
It's a really thorny issue with no obvious "right" solution.
I think your proposal is a good one.
Thanks,
-John
On Wed, 2021-03-31 at 13:28 -0700, Sophie Blee-Goldman
wrote:
> Hey all,
>
> It's finally
Hey all,
It's finally time to reconsider the default grace period in Kafka Streams,
and hopefully save a lot of suppression users from the pain of figuring out
why their results don't show up until 24 hours later. Please check out the
proposal and let me know what you think.
KIP:
11 matches
Mail list logo
