Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-09-09 Thread Ryan Dielher
Hi again, First of all, I apologize for the duplicate email I did not mean to send 2. > I added the / dynamic / config `supported.configs` to the KIP. This is a map > of client software name and version to a list of supported configs registered > with that software name and version. > > e.g.

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-09-08 Thread Ryan Dielher
Hi Jason, Thank you again for all of your feedback, it is greatly appreciated. Here are some more changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158869615=21=17 > 1. I wonder if we need to bother with `enable.dynamic.config`, especially > if the

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-09-08 Thread Ryan Dielher
Hi Jason, Thank you again for all of your feedback, it is greatly appreciated. Here are some more changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158869615=21=17 > 1. I wonder if we need to bother with `enable.dynamic.config`, especially > if the

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-10 Thread Ryan Dielhenn
Hi Jason, I hope you're having a good start to your week! I made these changes to the KIP and they are reflected in the PR. These changes include 1. Scoping dynamic configs by user-principal to address

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-07 Thread Ryan Dielhenn
Hi Jason, Thank you for this feedback it was very insightful and helpful. > 1. I wonder if we need to bother with `enable.dynamic.config`, especially > if the default is going to be true anyway. I think users who don't want to > use this capability can just not set dynamic configs. The only case

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-05 Thread Jason Gustafson
Hi Ryan, Thanks for the proposal. Just a few quick questions: 1. I wonder if we need to bother with `enable.dynamic.config`, especially if the default is going to be true anyway. I think users who don't want to use this capability can just not set dynamic configs. The only case I can see an

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-03 Thread Ryan Dielhenn
Hi David, Here are some additional thoughts... > 1. Once dynamic configs have been loaded and resolved, how can a client > know what values are selected? A copy of the original user-provided configs is kept by the client. Currently these are used to revert to the user-provided config if a

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-03 Thread Ryan Dielhenn
Hi David, Thank you for the comments, they were helpful. Here are the changes I made to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158869615=12=11 > 1. Once dynamic configs have been loaded and resolved, how can a client > know what values are selected?

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-08-03 Thread David Arthur
Hey Ryan, thanks for the KIP. This will be a really useful feature. Few questions 1. Once dynamic configs have been loaded and resolved, how can a client know what values are selected? Will we log the actual resolved values once they are loaded? 2. Do we want to support the case that we load

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-07-31 Thread Ryan Dielhenn
Thanks Jose, Here are the changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158869615=10=9 1. Done. 2. Done. 3. Done. 4. Yes metadata.max.age.ms will be use, I updated the KIP with this. > 5. > The Consumer Changes section mentions that the consumer

Re: [DISCUSS] KIP-649: Dynamic Client Configuration

2020-07-31 Thread Jose Garcia Sancio
Thanks for the KIP Ryan. Here are some of my observations. 1. > We will also be adding a new client configuration enable.dynamic.config to > both the producer and consumer that will be true by default so that the user > has the option to disable this feature. How about? "The Java producer and

[DISCUSS] KIP-649: Dynamic Client Configuration

2020-07-29 Thread Ryan Dielhenn
Hi everyone, I would like to start a discussion on KIP 649: https://cwiki.apache.org/confluence/display/KAFKA/KIP-649%3A+Dynamic+Client+Configuration This proposal specifies the mechanisms that will enable dynamic configuration of producers and consumers. We have cherry picked a few producer