Re: [DISCUSS] KIP-688: Support dynamic update of delete.topic.enable config

2020-11-25 Thread Gwen Shapira
Harsha, I understand the concern, but the solution of using this flag is a bit weird. First, I can cause similar damage by setting retention.ms=1 on any topic. We also have APIs to delete data from topics directly. All without a "gating" flag. Because as a system we rely on access controls to

Re: [DISCUSS] KIP-688: Support dynamic update of delete.topic.enable config

2020-11-25 Thread Harsha Ch
Hi Gwen, Agree with you ACLs would be a better option. But not all installations will be able to have secure setup and authorizer. In a hosted service where they may not be ACLs or security setup this flag helps prevent accidental topic deletion. This config acted as a good gatekeeper to

Re: [DISCUSS] KIP-688: Support dynamic update of delete.topic.enable config

2020-11-25 Thread Gwen Shapira
Thanks for bringing this up! I disagree that " there is a valid use-case to keep the flag "delete.topic.enable" as "false" in server.properties configs, so that someone doesn't accidentally delete a topic,". The flag was added and set to "false" back in the days when topic deletion was not a

[DISCUSS] KIP-688: Support dynamic update of delete.topic.enable config

2020-11-25 Thread Prateek Agarwal
Hi, I've created KIP-688 to enable support for dynamic update of delete.topic.enable config. https://cwiki.apache.org/confluence/display/KAFKA/KIP-688%3A+Support+dynamic+update+of+delete.topic.enable+config Please take a look and let me know if you have any feedback. Thanks -- Prateek Agarwal