Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Thanks Sophie, Most of these changes should be there in my PR. I will wait for a couple of days into next week to see if concerns are raised. Thanks! Sagar. On Sat, Apr 24, 2021 at 1:07 AM Sophie Blee-Goldman wrote: > Thanks Sagar, these changes make sense to me. I don't think we need to call

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Thanks Sagar, these changes make sense to me. I don't think we need to call for a new vote unless there are any concerns raised, but I feel this is probably not too controversial. Thanks for the update On Fri, Apr 23, 2021 at 3:17 AM Sagar wrote: > Hi All, > > After working on the changes propo

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hi All, After working on the changes proposed in the KIP, it was pointed out by Sophie that the KIP needs to be upgraded to include Serialisers as well. In line with this, I. have updated the KIP with the following changes: 1) Renamed the newly proposed config window.inner.class.deserialiser to w

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

I think you can start the vote, we can always return to the discussion if someone raises a concern during voting. Anyways I think/hope this won't be too controversial since we went through and agreed on a similar interface not long ago with KIP-659

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Thanks Leah/Sophie. I have updated the KIP with the new config. Do you think we can proceed with the voting process for the KIP or should we wait a bit longer? Thanks! Sagar. On Fri, Apr 2, 2021 at 11:59 PM Sophie Blee-Goldman wrote: > Yeah sure, window.inner.class.deserializer sounds good to

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Yeah sure, window.inner.class.deserializer sounds good to me On Fri, Apr 2, 2021 at 11:28 AM Leah Thomas wrote: > Hey Sagar, > > Thanks for picking this up! The proposal looks good to me after Sophie and > John's changes. > > Cheers, > Leah > > On Fri, Apr 2, 2021 at 6:21 AM Sagar wrote: > > >

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hey Sagar, Thanks for picking this up! The proposal looks good to me after Sophie and John's changes. Cheers, Leah On Fri, Apr 2, 2021 at 6:21 AM Sagar wrote: > Thanks John! > > Yeah I think window.inner.class.deserializer sounds good. Your thoughts > @Sophie? > > Thanks! > Sagar. > > > On Fri

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Thanks John! Yeah I think window.inner.class.deserializer sounds good. Your thoughts @Sophie? Thanks! Sagar. On Fri, Apr 2, 2021 at 5:23 AM John Roesler wrote: > Hi Sagar, > > I think this is a good proposal. > > The only change I might recommend is to change the config to more closely > alig

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hi Sagar, I think this is a good proposal. The only change I might recommend is to change the config to more closely align with the other one, for example: “window.inner.class.deserializer” But it’s very minor; I leave it to your judgement. Thanks, John On Fri, Mar 26, 2021, at 03:36, Sagar

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Thanks Sagar! The KIP looks good to me now. Let's see what others think On Fri, Mar 26, 2021 at 1:36 AM Sagar wrote: > Hi Sophie, > > Thanks for the feedback! I have updated the KIP inline with whatever you > suggested. > > Regarding point 5, I have added the note as it makes sense to not set th

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hi Sophie, Thanks for the feedback! I have updated the KIP inline with whatever you suggested. Regarding point 5, I have added the note as it makes sense to not set the config via the KafkaStreams app. Thanks! Sagar. On Wed, Mar 24, 2021 at 7:52 AM Sophie Blee-Goldman wrote: > Hey Sagar, > >

Re: [DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hey Sagar, Thanks for the KIP! The overall proposal looks good to me, but I had some miscellaneous notes: 1) Some general KIP-writing advice: - You don't need to list any implementation details, only public interfaces that are being added, modified, or deprecated. It's better to describ

[DISCUSS] KIP-725: Streamlining configurations for TimeWindowedDeserializer.

Hi All, I would like to start a discussion on the following KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=177047930 Thanks! Sagar.