Perfect, thanks guys, will do!
On Fri, May 21, 2021, 6:30 AM Matthew de Detrich
wrote:
> Thanks for this, I wasn't aware of the co-authored capabilities for
> git/github. In this case @Ryanne I don't think I need to split apart my
> commits, you can just add my email/name to the commit. Also mak
Thanks for this, I wasn't aware of the co-authored capabilities for
git/github. In this case @Ryanne I don't think I need to split apart my
commits, you can just add my email/name to the commit. Also make sure to
add ivanyu (https://github.com/ivanyu) since he made the original PR/tests
at https://
When merging, all commits will be squashed.
However, a committer can set "Co-authored-by" tags in the commit
message to credit all authors. Just make sure it's clearly stated in
the PR, so the committer is aware of it.
https://docs.github.com/en/github/committing-changes-to-your-project/creating-a
Sure thing, i will split out my PR into 2 commits by EOD today so that you
can cherry pick the test commit in your PR.
Thanks a lot for the work!
On Fri, May 21, 2021 at 12:53 AM Ryanne Dolan wrote:
> Matthew, I stole your integration tests to prove that point, but I would
> like to make sure y
Matthew, I stole your integration tests to prove that point, but I would
like to make sure you get credit for them in the commit history. If you
want to break out your tests into a separate commit, I can cherry-pick them
into my PR.
That would yield a PR with:
- a couple bug fixes from me in Mirro
@Ryanne,
I just noted you updated your PR at
https://github.com/apache/kafka/pull/10652/files#diff-79a09517576a35906123533490ed39c0e1a9416878e284d7b71f5f4c53eeca29R31
and I was mistaken in regards to the API changes being required. In this
case we can just use your PR instead of mine without the n
Hey Ryanne,
Thanks for the reply, personally I have a slight preference for my
implementation since it doesn't require the "cheating" with the
remote.topic.suffix as you mentioned (this also makes my implementation a
bit more clean/simple) but I am definitely not opposed to adjusting to use
your m
Hey Matthew, as you call out in the KIP there are few impls floating
around, including my WIP PR here:
https://github.com/apache/kafka/pull/10652
The tests are currently passing except for a couple asserts related to
failback (commented out). It appears your PR doesn't address failback, so I
thin
Hello everyone.
I have a KIP that involves adding a public method to the ReplicationPolicy
interface called canTrackSource. The intention behind creating this method
is to implement an IdentityReplicationPolicy (aka LegacyReplicationPolicy)
which is a MirrorMaker2 ReplicationPolicy that behaves th
