Re: [DISCUSS] KIP-780: Support fine-grained compression options

2021-10-18 Thread Dongjin Lee
Hi Ismael, do you have any opinion on this approach and benchmark results? Thanks, Dongjin On Wed, Oct 13, 2021 at 8:09 PM Dongjin Lee wrote: > Hi Chen, > > > It said, available value is [10, 22], but default is a value out of that > range, which should be wrong. > > Oh yes, it was a mistake!

Re: [DISCUSS] KIP-780: Support fine-grained compression options

2021-10-13 Thread Dongjin Lee
Hi Chen, > It said, available value is [10, 22], but default is a value out of that range, which should be wrong. Oh yes, it was a mistake! Thank you for reading the proposal so carefully. '0 or [10, 22]' is right. (I just fixed it.) Best, Dongjin On Wed, Oct 13, 2021 at 6:17 PM Luke Chen

Re: [DISCUSS] KIP-780: Support fine-grained compression options

2021-10-13 Thread Luke Chen
Hi Dongjin, Thanks for the KIP, and the benchmark results. It makes sense to me. Just one question: > compression.zstd.window: enables long mode; the log of the window size that zstd uses to memorize the compressing data. (available: [10, 22], default: 0 (disables long mode.)) It said, available

[DISCUSS] KIP-780: Support fine-grained compression options

2021-10-10 Thread Dongjin Lee
Hi Kafka dev, I would like to start the discussion of KIP-780: Support fine-grained compression options. https://cwiki.apache.org/confluence/display/KAFKA/KIP-780%3A+Support+fine-grained+compression+options Here is some context or history on this feature; initially, this feature was intended to