Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-12-10 Thread Vasiliki Papavasileiou
Hey Guozhang, Thank you for looking into the KIP. Windowed stores are addressed in another KIP. FYI, I made a change to the KIP and removed the `RawRangeQuery`. After some more thought, it doesn't provide us with many benefits (we save on one cast) which doesn't justify the cost of adding an

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-12-09 Thread Guozhang Wang
Hi Vicky, Thanks for the KIP. Just for a bit more clarification, could you elaborate an example for windowed stores, beyond a key-value store (I think the `myStore` is for kv-store right?). Otherwise LGTM. Guozhang On Wed, Dec 8, 2021 at 4:18 PM Matthias J. Sax wrote: > Thanks for the

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-12-08 Thread Matthias J. Sax
Thanks for the details! I also chatted with John about it, and he filed https://issues.apache.org/jira/browse/KAFKA-13526 to incorporate some feedback as follow up work. IMHO, the hard coded query translation is not ideal and should be plugable. But for a v1 of IQv2 (pun intended) the

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-12-08 Thread Vasiliki Papavasileiou
Hey Matthias, Thank you for looking into the KIP! We are adding raw versions of typed queries, like `RawRangeQuery` because it simplifies internal query handling since the bytes stores only support raw queries. A typed RangeQuery is handled by the `MeteredStore` which creates a new

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-12-06 Thread Matthias J. Sax
Thanks for the KIP. Overall, make sense. One question: What is the purpose to `RawRangeQuery`? Seems not very user friendly. -Matthias On 11/30/21 12:48 PM, Vasiliki Papavasileiou wrote: Thank you John! Yes, that was a typo from copying and I fixed it. Since there have been no more

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-11-30 Thread Vasiliki Papavasileiou
Thank you John! Yes, that was a typo from copying and I fixed it. Since there have been no more comments, I will start the vote. Best, Vicky On Tue, Nov 30, 2021 at 5:22 AM John Roesler wrote: > Thanks for the KIP, Vicky! > > This KIP will help fill in the parity gap between IQ and > IQv2. >

Re: [DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-11-29 Thread John Roesler
Thanks for the KIP, Vicky! This KIP will help fill in the parity gap between IQ and IQv2. One thing I noticed, which looks like just a typo is that the value type of the proposed RangeQuery should probably be KeyValueIterator, right? Otherwise, it looks good to me! Thanks, -John On Mon,

[DISCUSS] KIP-805: Add range and scan query support in IQ v2

2021-11-29 Thread Vasiliki Papavasileiou
Hello everyone, I would like to start the discussion for KIP-805: Add range and scan query support in IQ v2 The KIP can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-805%3A+Add+range+and+scan+query+support+in+IQ+v2 Any suggestions are more than welcome. Many thanks,