Re: [DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2022-01-12 Thread Mickael Maison
Hi Tom, That's a good point. I agree, in case 5) it makes more sense to return an error. I've updated the KIP accordingly. Thanks, Mickael On Mon, Jan 10, 2022 at 5:19 PM Tom Bentley wrote: > > Hi Mickael, > > Thanks for the KIP. > > Case 5 in the KIP seems a bit weird to me: > > > > NULL:v0

Re: [DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2022-01-10 Thread Tom Bentley
Hi Mickael, Thanks for the KIP. Case 5 in the KIP seems a bit weird to me: > > NULL:v0mykeymyvalue (5) > This will result in a record with key="mykey", value="myvalue" and > headers={"NULL": "v0"} This is because headers cannot have a null key. > To me this feels like it's more su

Re: [DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2021-12-20 Thread Mickael Maison
Thanks for the feedback! Chris, I've updated the KIP and added examples to show how the null marker will be applied. Luke, Good point, I've updating the KIP to mention the user will get an error message if the marker collides with other flags. Thanks, Mickael On Thu, Dec 16, 2021 at 2:00 PM Lu

Re: [DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2021-12-16 Thread Luke Chen
Hi Mickael, Thanks for the KIP! This will be a helpful feature for debugging, for sure! I have one question: Will we have some safe net for the collision of `key.separator` and the new introduced `null.marker`. That is, what if user set the same or overlapped `key.separator` and `null.marker`, h

Re: [DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2021-12-15 Thread Chris Egerton
Hi Mickael, Thanks for the KIP. Given how important tombstone records are it's hard to believe that the console producer doesn't already support them! I wanted to clarify the intended behavior and how it will play with the parse.key and the newly-introduced (as of KIP-798 [1]) parse.headers prope

[DISCUSS] KIP-810: Allow producing records with null values in Kafka Console Producer

2021-12-15 Thread Mickael Maison
Hi all, I opened a KIP to add the option to produce records with a null value using the Console Producer: https://cwiki.apache.org/confluence/display/KAFKA/KIP-810%3A+Allow+producing+records+with+null+values+in+Kafka+Console+Producer Let me know if you have any feedback. Thanks, Mickael