Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-03 Thread David Jacot
That's correct. David On Fri, Jun 3, 2022 at 2:11 AM José Armando García Sancio wrote: > > David Jacot wrote: > > At the moment, the KIP stipulates that the broker remains in > > InControlledShutdown state until it is re-registered with a new > > incarnation id. This implies that a broker can

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-02 Thread José Armando García Sancio
David Jacot wrote: > At the moment, the KIP stipulates that the broker remains in > InControlledShutdown state until it is re-registered with a new > incarnation id. This implies that a broker can be both fenced and in > controlled shutdown state. We could make them mutually exclusive but I >

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-02 Thread David Arthur
Good point about the unclean election behavior. I agree we wouldn't want to elect a replica was on a shutting down broker. > Right. There is a note about this in the Compatibility section. Thanks :) I missed that -David On Thu, Jun 2, 2022 at 12:19 PM David Jacot wrote: > Thanks for your

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-02 Thread David Jacot
Thanks for your feedback, David. Please find my answers below. > When an unclean election is performed, I'm assuming we will ignore the two new invariants proposed in the KIP? If so, maybe we should clarify that. I am not sure about this. What's the point of electing a broker which is fenced or

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-02 Thread David Arthur
David, thanks for the KIP! When an unclean election is performed, I'm assuming we will ignore the two new invariants proposed in the KIP? If so, maybe we should clarify that. I understand the use case of persisting the in-controller-shutdown state for controller failover, but are we planning on

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-02 Thread David Jacot
Hi José, At the moment, the KIP stipulates that the broker remains in InControlledShutdown state until it is re-registered with a new incarnation id. This implies that a broker can be both fenced and in controlled shutdown state. We could make them mutually exclusive but I think that there is

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-01 Thread José Armando García Sancio
Thanks for the updates to the KIP. I like enumerating invariants. Is it safe to say that if `InControlledShutdown` is true then `Fenced` must be false.

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-01 Thread David Jacot
Hi Ismael, That's the plan. I just noticed that I forgot to change the version of the field in the AlterPartitionResponse. Let me fix that. Thanks, David On Wed, Jun 1, 2022 at 10:40 AM Ismael Juma wrote: > > Hi David, > > If you are adding topic IDs, should we remove topic names? > > Ismael >

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-01 Thread Ismael Juma
Hi David, If you are adding topic IDs, should we remove topic names? Ismael On Tue, May 31, 2022, 6:36 AM David Jacot wrote: > Hi all, > > Thanks for your feedback. > > I just updated the KIP as follows: > * I propose to add a `TopicId` field at the same time while we are bumping > the

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-31 Thread David Jacot
Hi all, Thanks for your feedback. I just updated the KIP as follows: * I propose to add a `TopicId` field at the same time while we are bumping the AlterPartition API version. * I propose to add the `InShuttingDown` field to the registration records to track if a broker is in controlled

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-24 Thread José Armando García Sancio
Hi David, Thanks for the KIP. In the "Compatibility, Deprecation, and Migration Plan", you have: > The change is backward compatible. I assume that we don't need to increase the metadata.version/IBP for AlterPartition because AlterPartitionManager uses ApiVersions for that channel. Should we

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-22 Thread Colin McCabe
Hi David, Thanks for the KIP. LGTM! best, Colin On Wed, May 18, 2022, at 08:55, David Jacot wrote: > Hi, > > I created a small KIP to strengthen the AlterPartition API in KRaft mode: > https://cwiki.apache.org/confluence/x/phmhD > > Let me know what you think. > > Best, > David

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-22 Thread Colin McCabe
Hi Artem, In ZK mode, the concept of fenced replicas does not exist -- brokers are either in the cluster or out, and if they're out, we scrub all information about them from the metadata. (With the exception of replica sets they are in.) best, Colin On Fri, May 20, 2022, at 10:17, Artem

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-20 Thread Artem Livshits
The KIP LGTM. My only question is why it's an issue with KRaft -- looks like ZK would have the same issue? -Artem On Fri, May 20, 2022 at 8:51 AM David Jacot wrote: > This KIP is pretty straight forward. I will start a vote on Monday > if no one objects. > > Best, > David > > On Wed, May 18,

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-20 Thread David Jacot
This KIP is pretty straight forward. I will start a vote on Monday if no one objects. Best, David On Wed, May 18, 2022 at 5:55 PM David Jacot wrote: > > Hi, > > I created a small KIP to strengthen the AlterPartition API in KRaft mode: > https://cwiki.apache.org/confluence/x/phmhD > > Let me

[DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-18 Thread David Jacot
Hi, I created a small KIP to strengthen the AlterPartition API in KRaft mode: https://cwiki.apache.org/confluence/x/phmhD Let me know what you think. Best, David