Updated metric description as well.
-Artem
On Fri, Jul 8, 2022 at 9:22 AM Jun Rao wrote:
> Hi, Artem,
>
> Thanks for the reply. It would be useful to add that clarification in the
> description of the metric. Other than that, the KIP looks good to me.
>
> Jun
>
> On Tue, Jul 5, 2022 at 5:57 PM
Hi, Artem,
Thanks for the reply. It would be useful to add that clarification in the
description of the metric. Other than that, the KIP looks good to me.
Jun
On Tue, Jul 5, 2022 at 5:57 PM Artem Livshits
wrote:
> I've updated the KIP to clarify that the metric reflects the total amount
> of
I've updated the KIP to clarify that the metric reflects the total amount
of producer ids in all partitions maintained in the broker.
-Artem
On Thu, Jun 30, 2022 at 11:46 AM Jun Rao wrote:
> Hi, Artem,
>
> Thanks for the reply.
>
> The memory usage on the broker is proportional to the number
Hi, Artem,
Thanks for the reply.
The memory usage on the broker is proportional to the number of (partition,
pid) combinations. So, I am wondering if we could have a metric that
captures that. The proposed pid count metric doesn't fully capture that
since each pid could be associated with a
Hi Artem,
Thanks for the update to include motivation. Makes sense to me.
Justine
On Wed, Jun 29, 2022 at 6:51 PM Luke Chen wrote:
> Hi Artem,
>
> Thanks for the update.
> LGTM.
>
> Luke
>
> On Thu, Jun 30, 2022 at 6:51 AM Artem Livshits
> wrote:
>
> > Thank you for your feedback. I've updated
Hi Artem,
Thanks for the update.
LGTM.
Luke
On Thu, Jun 30, 2022 at 6:51 AM Artem Livshits
wrote:
> Thank you for your feedback. I've updated the KIP to elaborate on the
> motivation and provide some background on producer ids and how we measure
> them.
>
> Also, after some thinking and
Thank you for your feedback. I've updated the KIP to elaborate on the
motivation and provide some background on producer ids and how we measure
them.
Also, after some thinking and discussing it offline with some folks, I
think that we don't really need partitioner level metrics. We can use
Hi Artem,
Could you elaborate more in the motivation section?
I'm interested to know what kind of scenarios this metric can benefit for.
What could it bring to us when a topic partition has 100 ProducerIdCount VS
another topic partition has 10 ProducerIdCount?
Thank you.
Luke
On Wed, Jun 29,
Hi, Artem,
Thanks for the KIP.
Could you explain the partition level ProducerIdCount a bit more? Does that
reflect the number of PIDs ever produced to a partition since the broker is
started? Do we reduce the count after a PID expires?
Thanks,
Jun
On Wed, Jun 22, 2022 at 1:08 AM David Jacot
Hi Artem,
The KIP LGTM.
Thanks,
David
On Tue, Jun 21, 2022 at 9:32 PM Artem Livshits
wrote:
>
> If there is no other feedback I'm going to start voting in a couple days.
>
> -Artem
>
> On Fri, Jun 17, 2022 at 3:50 PM Artem Livshits
> wrote:
>
> > Thank you for your feedback. Updated the KIP
If there is no other feedback I'm going to start voting in a couple days.
-Artem
On Fri, Jun 17, 2022 at 3:50 PM Artem Livshits
wrote:
> Thank you for your feedback. Updated the KIP and added the Rejected
> Alternatives section.
>
> -Artem
>
> On Fri, Jun 17, 2022 at 1:16 PM Ismael Juma
Thank you for your feedback. Updated the KIP and added the Rejected
Alternatives section.
-Artem
On Fri, Jun 17, 2022 at 1:16 PM Ismael Juma wrote:
> If we don't track them separately, then it makes sense to keep it as one
> metric. I'd probably name it ProducerIdCount in that case.
>
>
If we don't track them separately, then it makes sense to keep it as one
metric. I'd probably name it ProducerIdCount in that case.
Ismael
On Fri, Jun 17, 2022 at 12:04 PM Artem Livshits
wrote:
> Do you propose to have 2 metrics instead of one? Right now we don't track
> if the producer id
Do you propose to have 2 metrics instead of one? Right now we don't track
if the producer id was transactional or idempotent and for metric
collection we'd either have to pay the cost of iterating over producer ids
(which could be a lot) or split the producer map into 2 or cache the
counts, which
I like the suggestion to have IdempotentProducerCount and
TransactionalProducerCount metrics.
Ismael
On Thu, Jun 16, 2022 at 2:27 PM Artem Livshits
wrote:
> Hi Ismael,
>
> Thank you for your feedback. Yes, this is counting the number of producer
> ids tracked by the partition and broker.
Hi Ismael,
Thank you for your feedback. Yes, this is counting the number of producer
ids tracked by the partition and broker. Another options I was thinking of
are the following:
- IdempotentProducerCount
- TransactionalProducerCount
- ProducerIdCount
Let me know if one of these seems better,
Thanks for the KIP.
ProducerCount seems like a misleading name since producers without a
producer id are not counted. Is this meant to count the number of producer
IDs tracked by the broker?
Ismael
On Wed, Jun 15, 2022, 3:12 PM Artem Livshits
wrote:
> Hello,
>
> I'd like to start a discussion
Hello,
I'd like to start a discussion on the KIP-847:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-847%3A+Add+ProducerCount+metrics
.
-Artem
18 matches
Mail list logo
