Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-12-05 Thread Chris Egerton
imilar to > https://cwiki.apache.org/confluence/display/KAFKA/KIP-419%3A+Safely+notify+Kafka+Connect+SourceTask+is+stopped, > just took a different approach. > > > From: dev@kafka.apache.org At: 11/29/22 15:31:31 UTC-5:00To: > dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-883: Add del

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-30 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
uence/display/KAFKA/KIP-419%3A+Safely+notify+Kafka+Connect+SourceTask+is+stopped, just took a different approach. From: dev@kafka.apache.org At: 11/29/22 15:31:31 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API Hi Hector, Thanks for

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-29 Thread Chris Egerton
; > Cheers, > Hector > > From: Hector Geraldino (BLOOMBERG/ 919 3RD A) At: 11/16/22 17:38:59 > UTC-5:00To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API > > Hi Mickael, > > I agree that the new STOPPED state proposed in

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-17 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
it the existing one. Please let me know what your thoughts are. Cheers, Hector From: Hector Geraldino (BLOOMBERG/ 919 3RD A) At: 11/16/22 17:38:59 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API Hi Mickael, I agree that the ne

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-16 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
feedback! From: dev@kafka.apache.org At: 11/16/22 11:13:17 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API Hi Hector, Thanks for the KIP. One tricky aspect is that currently there's no real way to stop a connector so to do so peo

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-16 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
mplest option would be to provide an overloaded method (with a default implementation) that connectors can override. Wdyt? From: dev@kafka.apache.org At: 11/15/22 11:40:26 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API Hey Hector, Th

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-16 Thread Mickael Maison
l the possibilities, or if we shoold keeping it more > > narrow-focused on providing a callback mechanism for when connectors are > > deleted, and what the expectations are around this newly introduced method. > > What do you think? > > > > > > From: dev@kafka.ap

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-15 Thread Sagar
ou think? > > > From: dev@kafka.apache.org At: 11/09/22 16:55:04 UTC-5:00To: > dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API > > Hi Hector, > > Thanks for the KIP! > > This is certainly missing functionality from

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-11 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
rom: dev@kafka.apache.org At: 11/09/22 16:55:04 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-883: Add delete callback method to Connector API Hi Hector, Thanks for the KIP! This is certainly missing functionality from the native Connect framework, and we should try to make it poss

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-09 Thread Greg Harris
Hi Hector, Thanks for the KIP! This is certainly missing functionality from the native Connect framework, and we should try to make it possible to inform connectors about this part of their lifecycle. However, as with most functionality that was left out of the initial implementation of the frame

[DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-03 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
Hi everyone, I've submitted KIP-883, which introduces a callback to the public Connector API called when deleting a connector: https://cwiki.apache.org/confluence/display/KAFKA/KIP-883%3A+Add+delete+callback+method+to+Connector+API It adds a new `deleted()` method (open to better naming suggest