Another questions regarding the kafka-merge-pr.py script: once a
committer gives a LGTM on the PR, could the contributor use the script to
push to the git repo himself, or it must be executed by the committer? I
thought it is the former case but seems not. If not we need to make it
clear on the
The script just runs a git push, it will be with your user (from git
configuration), so you need privileges to push.
On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang wangg...@gmail.com wrote:
Another questions regarding the kafka-merge-pr.py script: once a
committer gives a LGTM on the PR, could
Thanks Gwen, will update the wiki then.
On Wed, Jul 15, 2015 at 1:03 PM, Gwen Shapira gshap...@cloudera.com wrote:
The script just runs a git push, it will be with your user (from git
configuration), so you need privileges to push.
On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang
Hi Jun,
On Tue, Jul 14, 2015 at 2:09 AM, Jun Rao j...@confluent.io wrote:
Ismael,
I followed the instructions in KAFKA-2320 and created a new Jenkins job (
https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it
works?
Thanks! It seems to be building when trunk changes
On Tue, Jul 14, 2015 at 6:15 PM, Jun Rao j...@confluent.io wrote:
I made a couple of changes to the new Jenkins job. Could you try again?
It's still not working, unfortunately. It may or may not be related to:
https://blogs.apache.org/infra/entry/mirroring_to_github_issues
For b, if we can't
Ismael,
I followed the instructions in KAFKA-2320 and created a new Jenkins job (
https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it
works?
As for wiki, I have a couple of minor comments.
a. Could we add the following to the wiki?
To avoid conflicts, assign a jira to
Hi Ismael,
I have a couple of comments on the wiki pages / merge scripts:
1. In the wiki page it mentions If the change is new, then it usually
needs a new JIRA. However, trivial changes, where what should change is
virtually the same as how it should change do not require a JIRA.
Example: Fix
Hi Guozhang,
Comments inline.
On Fri, Jul 10, 2015 at 8:47 PM, Guozhang Wang wangg...@gmail.com wrote:
I have a couple of comments on the wiki pages / merge scripts:
Thanks, it's important to discuss these things as the current version is
based on what the Spark project does and may not
Commends inlined.
On Fri, Jul 10, 2015 at 2:10 PM, Ismael Juma ism...@juma.me.uk wrote:
Hi Guozhang,
Comments inline.
On Fri, Jul 10, 2015 at 8:47 PM, Guozhang Wang wangg...@gmail.com wrote:
I have a couple of comments on the wiki pages / merge scripts:
Thanks, it's important to
An update on this.
On Thu, Apr 30, 2015 at 2:12 PM, Ismael Juma ism...@juma.me.uk wrote:
1. CI builds triggered by GitHub PRs (this is supported by Apache
Infra, we need to request it for Kafka and provide whatever configuration
is needed)
Filed
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
One thing I noticed is that when you try to generate a PR it defaults to
the 0.8.2 branch. Can we fix that up to be trunk by default?
I filed an INFRA ticket for this:
Hi Jun,
On Sat, May 2, 2015 at 2:50 PM, Jun Rao j...@confluent.io wrote:
We will also need to figure out if we need CONTRIBUTING.md like the
following to take care of the Apache licensing stuff.
https://github.com/apache/spark/blob/master/CONTRIBUTING.md
Yes indeed. That is in step 3 of
Hi Ewen,
Comments inline.
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
Also +1. There are some drawbacks to using Github for reviews, e.g. lots of
emails for each review because they don't let you publish your entire
review in one go like RB does, but it
Ismael,
We will also need to figure out if we need CONTRIBUTING.md like the
following to take care of the Apache licensing stuff.
https://github.com/apache/spark/blob/master/CONTRIBUTING.md
As for merging changes, I think squashing the commits will be ideal during
merge. Also, it would be great
+1!
-Jay
On Thu, Apr 30, 2015 at 6:12 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
Kafka currently uses a combination of Review Board and JIRA for
contributions and code review. In my opinion, this makes contribution and
code review a bit harder than it has to be.
I think the
+1.
Thanks
Parth
On 5/1/15, 12:38 AM, Ewen Cheslack-Postava e...@confluent.io wrote:
Also +1. There are some drawbacks to using Github for reviews, e.g. lots
of
emails for each review because they don't let you publish your entire
review in one go like RB does, but it drastically lowers the
Hi all,
Kafka currently uses a combination of Review Board and JIRA for
contributions and code review. In my opinion, this makes contribution and
code review a bit harder than it has to be.
I think the approach used by Spark would improve the current situation:
Generally, Spark uses JIRA to
I think this will help a lot in contributions. Some of my local changes
that I want to contribute back have been pending because I sometimes
switch machines and I then have to go through setting up the Ruby/python
and other stuff for the current review process. Using just github is
going to
Thanks a bunch for taking this up, Ismael!
+1, I think it will be much more convenient to sunset RB and move to
github. Especially looking forward to the CIs on PRs and also the merge
script.
Alas, my wonderful patch-review script will be retired :-)
On Thu, Apr 30, 2015 at 6:12 AM, Ismael Juma
19 matches
Mail list logo
