Re: 答复: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-29 Thread Jun Rao
P. Could we vote now? > > > > 发件人: Jun Rao <j...@confluent.io> > 发送时间: 2017年11月23日 6:21 > 收件人: dev@kafka.apache.org > 主题: Re: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition > lead metrics to KafkaConsumer > > Hi, Hu, > &

答复: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-28 Thread Hu Xi
nt.io> > 发送时间: 2017年11月21日 3:55 > 收件人: dev@kafka.apache.org > 主题: Re: 答复: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and > per-partition lead metrics to KafkaConsumer > > Hi, Hu, > > For the new partition level metrics that you are adding, it seems it's > better t

答复: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-22 Thread Hu Xi
gain. Thanks. 发件人: Jun Rao <j...@confluent.io> 发送时间: 2017年11月23日 6:21 收件人: dev@kafka.apache.org 主题: Re: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hi, Hu, There are two types of names. One is the sens

Re: REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-22 Thread Jun Rao
/partition > > tags for those metrics as well as keep the prefix? If those prefixes > should > > really be removed, does this KIP need to do the same thing for `lag` > ones? > > > > ________________________ > > 发件人: Jun Rao <j...@confluent.io> > >

REPLY: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-20 Thread Hu Xi
the same thing for `lag` ones? > > > 发件人: Jun Rao <j...@confluent.io> > 发送时间: 2017年11月18日 8:55 > 收件人: dev@kafka.apache.org > 主题: Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and > per-partition lead metrics to KafkaConsumer > > H

Re: 答复: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-20 Thread Jun Rao
> 发件人: Jun Rao <j...@confluent.io> > 发送时间: 2017年11月18日 8:55 > 收件人: dev@kafka.apache.org > 主题: Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and > per-partition lead metrics to KafkaConsumer > > Hi, Charly, > > Thanks for the input. It makes sense

答复: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-19 Thread Hu Xi
.io> 发送时间: 2017年11月18日 8:55 收件人: dev@kafka.apache.org 主题: Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hi, Charly, Thanks for the input. It makes sense. Hi, Hu, Perhaps we can keep the per partition records-lead-min and records-le

Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-17 Thread Jun Rao
stem. > > > > > > > > 2 Tag partition-level records-lead with topic info > > > > > > > > > > > > If they are the case you expect, do we need to do the same thing for > > > those > > > > `lag` metrics? Seems partition

Reply: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-15 Thread Hu Xi
017年11月15日 20:58 收件人: dev@kafka.apache.org 抄送: Jiangjie Qin 主题: Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hi Jun, Jiangle, I'd just like to clarify that KIP-225 seems to be using per partition metric the same way as KIP-223 see

Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-15 Thread charly molter
opic info > > > > > > > > > If they are the case you expect, do we need to do the same thing for > > those > > > `lag` metrics? Seems partition-level records-lag metrics are not tagged > > > with topic information which might deserve a bug. > > > > > > &g

Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-14 Thread Jun Rao
mation which might deserve a bug. > > > > > > huxihx > > > > > > ____________ > > 发件人: Jun Rao <j...@confluent.io> > > 发送时间: 2017年11月14日 12:44 > > 收件人: dev@kafka.apache.org > > 主题: Re: 答复: [DISCUSS]KIP-223 - Add

Re: 答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-14 Thread charly molter
rmation which might deserve a bug. > > > huxihx > > > > 发件人: Jun Rao <j...@confluent.io> > 发送时间: 2017年11月14日 12:44 > 收件人: dev@kafka.apache.org > 主题: Re: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition > l

答复: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-14 Thread Hu Xi
xihx > > > > > > ---------- > *发件人:* Jun Rao <j...@confluent.io> > *发送时间:* 2017年11月14日 1:48 > *收件人:* dev@kafka.apache.org > *主题:* Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition > lead metrics to KafkaConsumer > > Hi, H

Re: 答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Jun Rao
records-lead-min don't need the partition prefix since they are aggregates > across all partitions*` seemed to break the naming rule above. Do we > still have to keep the same rule with the "lag" metrics? > > > huxihx > > > > > > ---------------

答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Hu Xi
e aggregates across all partitions` seemed to break the naming rule above. Do we still have to keep the same rule with the "lag" metrics? huxihx 发件人: Jun Rao <j...@confluent.io> 发送时间: 2017年11月14日 1:48 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS]KIP-

Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-13 Thread Jun Rao
Hi, Hu, Thanks for the KIP. Looks good overall. Could you document the mbean name for the new metrics? We probably want the name to be consistent with records-max-lag as described in http://kafka.apache.org/documentation/#monitoring. Also, it seems that records-lead-avg and records-lead-min don't

答复: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-09 Thread Hu Xi
Yu, thanks for your comments. Already explicitly showed the jira number and refined the exact metric names. 发件人: Ted Yu <yuzhih...@gmail.com> 发送时间: 2017年11月10日 1:51 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-par

Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-09 Thread Ted Yu
Can you fill out JIRA number ? "TOPIC-PARTITION_ID.record-lead" In the code sample, "records-" is used. Please make them consistent. On Thu, Nov 9, 2017 at 1:03 AM, Hu Xi wrote: > Hi all, > > > As per Jun Rao's suggestion, I opened up the KIP-223(https://cwiki.apache. >

[DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-09 Thread Hu Xi
Hi all, As per Jun Rao's suggestion, I opened up the KIP-223(https://cwiki.apache.org/confluence/display/KAFKA/KIP-223+-+Add+per-topic+min+lead+and+per-partition+lead+metrics+to+KafkaConsumer) concerning adding new kinds of lag metrics for KafkaConsumer. Be free to leave your comments here.