junrao commented on a change in pull request #343:
URL: https://github.com/apache/kafka-site/pull/343#discussion_r600850419
##########
File path: css/styles.css
##########
@@ -444,15 +444,15 @@ tr:nth-child(odd) {
}
.logo-link {
display: inline-block;
- width: 220px;
- height: 64.77px;
- background: url("/images/logo.png");
- background-size: 217px auto;
+ width: 117px;
+ height: 65px;
+ background: url("/logos/kafka_logo--simple.png");
+ background-size: auto 65px;
background-repeat: no-repeat;
/* small: 168 x 50 */
}
.page-dark .logo-link {
- background: url('/logos/kafka-white.svg');
+ background: url('/logos/kafka_logo--white-simple.png.svg');
Review comment:
kafka_logo--white-simple.png.svg => kafka_logo--white-simple.png ?
##########
File path: css/styles.css
##########
@@ -444,15 +444,15 @@ tr:nth-child(odd) {
}
.logo-link {
display: inline-block;
- width: 220px;
- height: 64.77px;
- background: url("/images/logo.png");
Review comment:
Should we remove the old logo image file?
##########
File path: css/styles.css
##########
@@ -444,15 +444,15 @@ tr:nth-child(odd) {
}
.logo-link {
display: inline-block;
- width: 220px;
- height: 64.77px;
- background: url("/images/logo.png");
- background-size: 217px auto;
+ width: 117px;
+ height: 65px;
+ background: url("/logos/kafka_logo--simple.png");
+ background-size: auto 65px;
background-repeat: no-repeat;
/* small: 168 x 50 */
}
.page-dark .logo-link {
- background: url('/logos/kafka-white.svg');
Review comment:
Should we remove the old logo image file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
